From: "lihuisong (C)" <lihuisong@huawei.com>
To: Sudeep Holla <sudeep.holla@kernel.org>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <acpica-devel@lists.linux.dev>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Saket Dumbre <saket.dumbre@intel.com>, <lihuisong@huawei.com>
Subject: Re: [PATCH 4/4] ACPI: PCC: Cache OpRegion command timeout
Date: Tue, 21 Jul 2026 19:53:00 +0800 [thread overview]
Message-ID: <ca68550e-9ce3-4cad-aecf-090dcaf36cd6@huawei.com> (raw)
In-Reply-To: <20260717081005.470013-5-sudeep.holla@kernel.org>
On 7/17/2026 4:10 PM, Sudeep Holla wrote:
> The PCC OperationRegion handler computes the same command completion
> wait timeout each time it sends a command. The timeout is derived from
> static channel properties, so compute it once when the PCC channel is
> set up and store the millisecond value in the mailbox client timeout
> field.
>
> Use the cached timeout when waiting for the OperationRegion command to
> complete. This keeps the timeout calculation in one place and avoids
> recomputing it for every command.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
> ---
LGTM,
Reviewed-by: Huisong Li <lihuisong@huawei.com>
prev parent reply other threads:[~2026-07-21 11:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:10 [PATCH 0/4] ACPI/PCC: Correct PCC OperationRegion handling Sudeep Holla
2026-07-17 8:10 ` [PATCH 1/4] ACPICA: Fix PCC OperationRegion command offsets Sudeep Holla
2026-07-17 8:10 ` [PATCH 2/4] ACPI: PCC: Preserve shared memory signature in OpRegion handler Sudeep Holla
2026-07-21 11:43 ` lihuisong (C)
2026-07-21 12:27 ` Sudeep Holla
2026-07-21 19:20 ` Rafael J. Wysocki (Intel)
2026-07-22 8:47 ` Sudeep Holla
2026-07-17 8:10 ` [PATCH 3/4] ACPI: PCC: Free channel on OpRegion deactivation Sudeep Holla
2026-07-22 1:15 ` lihuisong (C)
2026-07-22 8:45 ` Sudeep Holla
2026-07-17 8:10 ` [PATCH 4/4] ACPI: PCC: Cache OpRegion command timeout Sudeep Holla
2026-07-21 11:53 ` lihuisong (C) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca68550e-9ce3-4cad-aecf-090dcaf36cd6@huawei.com \
--to=lihuisong@huawei.com \
--cc=acpica-devel@lists.linux.dev \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saket.dumbre@intel.com \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox