From: "lihuisong (C)" <lihuisong@huawei.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: <acpica-devel@lists.linux.dev>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Saket Dumbre <saket.dumbre@intel.com>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lihuisong@huawei.com>
Subject: Re: [PATCH 3/4] ACPI: PCC: Free channel on OpRegion deactivation
Date: Wed, 22 Jul 2026 09:15:40 +0800 [thread overview]
Message-ID: <fcedb818-fb09-4a0b-a916-d65f762e5905@huawei.com> (raw)
In-Reply-To: <20260717081005.470013-4-sudeep.holla@kernel.org>
On 7/17/2026 4:10 PM, Sudeep Holla wrote:
> ACPICA calls the address space setup callback with
> ACPI_REGION_DEACTIVATE when a PCC OperationRegion is torn down.
>
> The PCC setup callback currently allocates a fresh pcc_data and requests
> the mailbox channel before looking at the function argument. If ACPICA
> deactivates a region, this can leave the existing region context and
> mailbox channel unreleased, and may also request a channel during
> teardown.
>
> Handle ACPI_REGION_DEACTIVATE before allocation. Free the PCC mailbox
> channel, release the region context and clear the context pointer.
>
> Fixes: 77e2a04745ff ("ACPI: PCC: Implement OperationRegion handler for the PCC Type 3 subtype")
> Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
> ---
How to trigger this region deactivate at runtime?
Overall looks good to me.
Reviewed-by: Huisong Li <lihuisong@huawei.com>
next prev parent reply other threads:[~2026-07-22 1:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:10 [PATCH 0/4] ACPI/PCC: Correct PCC OperationRegion handling Sudeep Holla
2026-07-17 8:10 ` [PATCH 1/4] ACPICA: Fix PCC OperationRegion command offsets Sudeep Holla
2026-07-17 8:10 ` [PATCH 2/4] ACPI: PCC: Preserve shared memory signature in OpRegion handler Sudeep Holla
2026-07-21 11:43 ` lihuisong (C)
2026-07-21 12:27 ` Sudeep Holla
2026-07-21 19:20 ` Rafael J. Wysocki (Intel)
2026-07-22 8:47 ` Sudeep Holla
2026-07-17 8:10 ` [PATCH 3/4] ACPI: PCC: Free channel on OpRegion deactivation Sudeep Holla
2026-07-22 1:15 ` lihuisong (C) [this message]
2026-07-22 8:45 ` Sudeep Holla
2026-07-17 8:10 ` [PATCH 4/4] ACPI: PCC: Cache OpRegion command timeout Sudeep Holla
2026-07-21 11:53 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcedb818-fb09-4a0b-a916-d65f762e5905@huawei.com \
--to=lihuisong@huawei.com \
--cc=acpica-devel@lists.linux.dev \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saket.dumbre@intel.com \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).