Alpha arch development list
 help / color / mirror / Atom feed
From: Michael Cree <mcree@orcon.net.nz>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-alpha@vger.kernel.org, paul.gortmaker@windriver.com,
	rth@twiddle.net, mattst88@gmail.com, patches@linaro.org
Subject: Re: [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h
Date: Tue, 20 Nov 2012 07:30:15 +1300	[thread overview]
Message-ID: <20121119183015.GA2325@omega> (raw)
In-Reply-To: <1353323499-8638-1-git-send-email-sachin.kamat@linaro.org>

On Mon, Nov 19, 2012 at 04:41:39PM +0530, Sachin Kamat wrote:
> asm/xchg.h was included twice.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/alpha/include/asm/cmpxchg.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h
> index 429e8cd..8df1674 100644
> --- a/arch/alpha/include/asm/cmpxchg.h
> +++ b/arch/alpha/include/asm/cmpxchg.h
> @@ -40,7 +40,6 @@
>  #undef ____cmpxchg
>  #define ____xchg(type, args...)		__xchg ##type(args)
>  #define ____cmpxchg(type, args...)	__cmpxchg ##type(args)
> -#include <asm/xchg.h>

asm/xchg.h is intended to be included twice.  Your patch will break 
compilation.

Cheers
Michael.


  reply	other threads:[~2012-11-19 18:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 11:11 [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h Sachin Kamat
2012-11-19 18:30 ` Michael Cree [this message]
2012-11-20  3:24   ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119183015.GA2325@omega \
    --to=mcree@orcon.net.nz \
    --cc=linux-alpha@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=patches@linaro.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rth@twiddle.net \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox