* [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h
@ 2012-11-19 11:11 Sachin Kamat
2012-11-19 18:30 ` Michael Cree
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2012-11-19 11:11 UTC (permalink / raw)
To: linux-alpha; +Cc: paul.gortmaker, rth, mattst88, sachin.kamat, patches
asm/xchg.h was included twice.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/alpha/include/asm/cmpxchg.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h
index 429e8cd..8df1674 100644
--- a/arch/alpha/include/asm/cmpxchg.h
+++ b/arch/alpha/include/asm/cmpxchg.h
@@ -40,7 +40,6 @@
#undef ____cmpxchg
#define ____xchg(type, args...) __xchg ##type(args)
#define ____cmpxchg(type, args...) __cmpxchg ##type(args)
-#include <asm/xchg.h>
#define xchg(ptr, x) \
({ \
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h
2012-11-19 11:11 [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h Sachin Kamat
@ 2012-11-19 18:30 ` Michael Cree
2012-11-20 3:24 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Michael Cree @ 2012-11-19 18:30 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-alpha, paul.gortmaker, rth, mattst88, patches
On Mon, Nov 19, 2012 at 04:41:39PM +0530, Sachin Kamat wrote:
> asm/xchg.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/alpha/include/asm/cmpxchg.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h
> index 429e8cd..8df1674 100644
> --- a/arch/alpha/include/asm/cmpxchg.h
> +++ b/arch/alpha/include/asm/cmpxchg.h
> @@ -40,7 +40,6 @@
> #undef ____cmpxchg
> #define ____xchg(type, args...) __xchg ##type(args)
> #define ____cmpxchg(type, args...) __cmpxchg ##type(args)
> -#include <asm/xchg.h>
asm/xchg.h is intended to be included twice. Your patch will break
compilation.
Cheers
Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h
2012-11-19 18:30 ` Michael Cree
@ 2012-11-20 3:24 ` Sachin Kamat
0 siblings, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2012-11-20 3:24 UTC (permalink / raw)
To: Michael Cree, Sachin Kamat, linux-alpha, paul.gortmaker, rth,
mattst88, patches
On 20 November 2012 00:00, Michael Cree <mcree@orcon.net.nz> wrote:
> On Mon, Nov 19, 2012 at 04:41:39PM +0530, Sachin Kamat wrote:
>> asm/xchg.h was included twice.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> arch/alpha/include/asm/cmpxchg.h | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h
>> index 429e8cd..8df1674 100644
>> --- a/arch/alpha/include/asm/cmpxchg.h
>> +++ b/arch/alpha/include/asm/cmpxchg.h
>> @@ -40,7 +40,6 @@
>> #undef ____cmpxchg
>> #define ____xchg(type, args...) __xchg ##type(args)
>> #define ____cmpxchg(type, args...) __cmpxchg ##type(args)
>> -#include <asm/xchg.h>
>
> asm/xchg.h is intended to be included twice. Your patch will break
> compilation.
I did not realise it. I thought it was an unconditional include. Sorry
for the noise.
>
> Cheers
> Michael.
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-20 3:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-19 11:11 [PATCH 1/1] alpha: Remove duplicate inclusion of asm/xchg.h Sachin Kamat
2012-11-19 18:30 ` Michael Cree
2012-11-20 3:24 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox