From: Richard Henderson <rth@twiddle.net>
To: Phil Carmody <pc+lkml@asdf.org>
Cc: linux-alpha@vger.kernel.org
Subject: Re: [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq
Date: Wed, 17 Jul 2013 06:03:18 -0700 [thread overview]
Message-ID: <51E69616.3000500@twiddle.net> (raw)
In-Reply-To: <20130716211259.GA11841@fatphil.org>
On 07/16/2013 02:12 PM, Phil Carmody wrote:
> Greetings Richard,
>
> Your
>
> + struct pci_dev *dev = (struct pci_dev *)dev;
>
> should surely (i.e. I'm nowhere near a compiler or kernel tree
> presently) be
>
> + struct pci_dev *dev = (struct pci_dev *)cdev;
>
> I guess post that, you can have:
>
> Acked-by: Phil Carmody <pc+lkml@asdf.org>
Ug. Self-assignment suppressing uninitialized variable warning
is the stupidest extension evar.
Good eyes, thanks.
r~
next prev parent reply other threads:[~2013-07-17 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 21:12 [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq Phil Carmody
2013-07-17 13:03 ` Richard Henderson [this message]
2013-07-17 14:42 ` Phil Carmody
-- strict thread matches above, loose matches on Subject: below --
2013-07-16 17:04 [PATCH 0/7] Minor Alpha updates for 3.11 Richard Henderson
2013-07-16 17:04 ` [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E69616.3000500@twiddle.net \
--to=rth@twiddle.net \
--cc=linux-alpha@vger.kernel.org \
--cc=pc+lkml@asdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox