Re: [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq

Re: [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq

[Phil Carmody]

Greetings Richard,

Your

+       struct pci_dev *dev = (struct pci_dev *)dev;

should surely (i.e. I'm nowhere near a compiler or kernel tree 
presently) be

+       struct pci_dev *dev = (struct pci_dev *)cdev;

I guess post that, you can have:

Acked-by: Phil Carmody <pc+lkml@asdf.org>

Cheers,
Phil

Re: [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq

[Richard Henderson]

On 07/16/2013 02:12 PM, Phil Carmody wrote:
> Greetings Richard,
> 
> Your
> 
> +       struct pci_dev *dev = (struct pci_dev *)dev;
> 
> should surely (i.e. I'm nowhere near a compiler or kernel tree 
> presently) be
> 
> +       struct pci_dev *dev = (struct pci_dev *)cdev;
> 
> I guess post that, you can have:
> 
> Acked-by: Phil Carmody <pc+lkml@asdf.org>

Ug.  Self-assignment suppressing uninitialized variable warning
is the stupidest extension evar.

Good eyes, thanks.


r~

Re: [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq

[Phil Carmody]

On 17/07/13 06:03 -0700, Richard Henderson wrote:
> On 07/16/2013 02:12 PM, Phil Carmody wrote:
> > Greetings Richard,
> > 
> > Your
> > 
> > +       struct pci_dev *dev = (struct pci_dev *)dev;
> > 
> > should surely (i.e. I'm nowhere near a compiler or kernel tree 
> > presently) be
> > 
> > +       struct pci_dev *dev = (struct pci_dev *)cdev;
> > 
> > I guess post that, you can have:
> > 
> > Acked-by: Phil Carmody <pc+lkml@asdf.org>
> 
> Ug.  Self-assignment suppressing uninitialized variable warning
> is the stupidest extension evar.

That complaint gets my Ack too!
 
> Good eyes, thanks.

I don't have much to offer, but I never forget how enormously in debt 
I am to those who enabled my shiny new '164 to run linux way way back. 

Phil
-- 
If "law-abiding citizens have nothing to fear" from privacy-invading 
technologies and policies, then law-abiding governments should have
nothing to fear from whistleblowers.

[PATCH 0/7] Minor Alpha updates for 3.11

[Richard Henderson]

Here's a set of minor updates for arch/alpha that should not
be controversial.


r~


The following changes since commit 47188d39b5deeebf41f87a02af1b3935866364cf:

  Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2013-07-14 21:47:51 -0700)

are available in the git repository at:


  git://github.com/rth7680/linux.git axp-next

for you to fetch changes up to fd60fe7052eceab1b1e7c8691263ec2b2634ace0:

  alpha: Fix type compatibility warning for marvel_map_irq (2013-07-16 09:55:06 -0700)

----------------------------------------------------------------
Richard Henderson (7):
      alpha: Add kcmp and finit_module syscalls
      alpha: Eliminate compiler warning from memset macro
      alpha: Modernize lib/mpi/longlong.h
      alpha: Improve atomic_add_unless
      alpha: Implement atomic64_dec_if_positive
      alpha: Generate dwarf2 unwind info for various kernel entry points.
      alpha: Fix type compatibility warning for marvel_map_irq

 arch/alpha/Kconfig                   |   1 +
 arch/alpha/include/asm/atomic.h      |  88 ++++++--
 arch/alpha/include/asm/string.h      |  18 +-
 arch/alpha/include/asm/unistd.h      |   3 +-
 arch/alpha/include/uapi/asm/unistd.h |   2 +
 arch/alpha/kernel/entry.S            | 399 +++++++++++++++++++++++++----------
 arch/alpha/kernel/sys_marvel.c       |   3 +-
 arch/alpha/kernel/systbls.S          |   2 +
 lib/mpi/longlong.h                   |  17 +-
 9 files changed, 380 insertions(+), 153 deletions(-)

[PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq

[Richard Henderson]

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 arch/alpha/kernel/sys_marvel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/alpha/kernel/sys_marvel.c b/arch/alpha/kernel/sys_marvel.c
index 407accc..53d6e4a 100644
--- a/arch/alpha/kernel/sys_marvel.c
+++ b/arch/alpha/kernel/sys_marvel.c
@@ -317,8 +317,9 @@ marvel_init_irq(void)
 }
 
 static int 
-marvel_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
+marvel_map_irq(const struct pci_dev *cdev, u8 slot, u8 pin)
 {
+	struct pci_dev *dev = (struct pci_dev *)dev;
 	struct pci_controller *hose = dev->sysdata;
 	struct io7_port *io7_port = hose->sysdata;
 	struct io7 *io7 = io7_port->io7;
-- 
1.8.1.4