Re: [PATCH] alpha: Use generic <asm-generic/io.h>

[Guenter Roeck <linux@roeck-us.net>]

On 10/3/22 06:03, Arnd Bergmann wrote:
> On Mon, Oct 3, 2022, at 12:45 AM, Guenter Roeck wrote:
> 
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Link: https://lore.kernel.org/linux-mm/202208181447.G9FLcMkI-lkp@intel.com/
>>> Cc: Mark Brown <broonie@kernel.org>
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Richard Henderson <richard.henderson@linaro.org>
>>> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
>>> Cc: Matt Turner <mattst88@gmail.com>
>>> Cc: linux-arch@vger.kernel.org
>>> Cc: linux-alpha@vger.kernel.org
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> This patch results in the following build errors when trying to build
>> alpha:allmodconfig.
>>
>> ERROR: modpost: "ioread64" [drivers/pci/switch/switchtec.ko] undefined!
>> ERROR: modpost: "ioread64"
>> [drivers/net/ethernet/freescale/enetc/fsl-enetc.ko] undefined!
>> ERROR: modpost: "ioread64"
>> [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
>> ERROR: modpost: "iowrite64"
>> [drivers/net/ethernet/xilinx/xilinx_emac.ko] undefined!
>> ERROR: modpost: "iowrite64" [drivers/net/wwan/t7xx/mtk_t7xx.ko]
>> undefined!
>> ERROR: modpost: "ioread64" [drivers/net/wwan/t7xx/mtk_t7xx.ko]
>> undefined!
>> ERROR: modpost: "iowrite64" [drivers/firmware/arm_scmi/scmi-module.ko]
>> undefined!
>> ERROR: modpost: "ioread64" [drivers/firmware/arm_scmi/scmi-module.ko]
>> undefined!
>> ERROR: modpost: "iowrite64" [drivers/vfio/pci/vfio-pci-core.ko]
>> undefined!
>> ERROR: modpost: "ioread64" [drivers/ntb/hw/mscc/ntb_hw_switchtec.ko]
>> undefined!
>>
>> Reverting it doesn't help because that just reintroduces the problem
>> that was supposed to be fixed by this patch.
> 
> Thanks for the report, I've now added this patch on top.
> 
> Matt, can you take a look if this look correct?
> 

Looks like something was missed. When building alpha:allnoconfig
in next-20221004:

Building alpha:allnoconfig ... failed
--------------
Error log:
<stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
arch/alpha/kernel/core_marvel.c:807:1: error: conflicting types for 'marvel_ioread8'; have 'unsigned int(const void *)'
   807 | marvel_ioread8(const void __iomem *xaddr)
       | ^~~~~~~~~~~~~~
In file included from arch/alpha/kernel/core_marvel.c:10:
arch/alpha/include/asm/core_marvel.h:335:11: note: previous declaration of 'marvel_ioread8' with type 'u8(const void *)' {aka 'unsigned char(const void *)'}
   335 | extern u8 marvel_ioread8(const void __iomem *);
       |           ^~~~~~~~~~~~~~

Guenter