From: "Arnd Bergmann" <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
linux-alpha@vger.kernel.org, kernel test robot <lkp@intel.com>,
Mark Brown <broonie@kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
regressions@lists.linux.dev
Subject: Re: [PATCH] alpha: Use generic <asm-generic/io.h>
Date: Wed, 12 Oct 2022 17:32:59 +0200 [thread overview]
Message-ID: <e99d33ff-4bfe-4727-a5ca-f4987b871ccd@app.fastmail.com> (raw)
In-Reply-To: <20221012140519.GA2405113@roeck-us.net>
On Wed, Oct 12, 2022, at 4:05 PM, Guenter Roeck wrote:
> On Tue, Oct 04, 2022 at 10:28:24PM +0200, Arnd Bergmann wrote:
>> On Tue, Oct 4, 2022, at 9:42 PM, Guenter Roeck wrote:
>> > On 10/3/22 06:03, Arnd Bergmann wrote:
>> >> On Mon, Oct 3, 2022, at 12:45 AM, Guenter Roeck wrote:
>> >
>> > Looks like something was missed. When building alpha:allnoconfig
>> > in next-20221004:
>> >
>> > Building alpha:allnoconfig ... failed
>> > --------------
>> > Error log:
>> > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>> > arch/alpha/kernel/core_marvel.c:807:1: error: conflicting types for
>> > 'marvel_ioread8'; have 'unsigned int(const void *)'
>> > 807 | marvel_ioread8(const void __iomem *xaddr)
>> > | ^~~~~~~~~~~~~~
>> > In file included from arch/alpha/kernel/core_marvel.c:10:
>> > arch/alpha/include/asm/core_marvel.h:335:11: note: previous declaration
>> > of 'marvel_ioread8' with type 'u8(const void *)' {aka 'unsigned
>> > char(const void *)'}
>> > 335 | extern u8 marvel_ioread8(const void __iomem *);
>> > | ^~~~~~~~~~~~~~
>>
>> Right, I already noticed this and uploaded a fixed branch earlier today.
>> Should be ok tomorrow.
>>
>
> Unfortunately that did not completely fix the problem, or maybe the fix got
> lost. In mainline, when building alpha:allnoconfig:
>
> arch/alpha/kernel/core_marvel.c:807:1: error: expected '=', ',', ';',
> 'asm' or '__attribute__' before 'marvel_ioread8'
> 807 | marvel_ioread8(const void __iomem *xaddr)
>
> The code is:
>
> unsigned u8
> marvel_ioread8(const void __iomem *xaddr)
>
> The compiler doesn't like "unsigned u8".
Right, I fixed up a different bug and introduced this wrong type.
I didn't catch my mistake until after the pull request was
merged, but fixed it in
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/commit/?id=2e21c1575208
which should be in linux-next. I was giving it a little more
time to be see if there are any other regressions I caused.
Arnd
next prev parent reply other threads:[~2022-10-12 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 9:20 [PATCH] alpha: Use generic <asm-generic/io.h> Linus Walleij
2022-08-18 10:28 ` Arnd Bergmann
2022-09-05 19:30 ` Linus Walleij
2022-09-05 20:52 ` Arnd Bergmann
2022-09-06 14:59 ` Matt Turner
2022-10-02 22:45 ` Guenter Roeck
2022-10-03 13:03 ` Arnd Bergmann
2022-10-03 15:07 ` Guenter Roeck
2022-10-03 18:49 ` Linus Walleij
2022-10-04 19:42 ` Guenter Roeck
2022-10-04 20:28 ` Arnd Bergmann
2022-10-12 14:05 ` Guenter Roeck
2022-10-12 15:32 ` Arnd Bergmann [this message]
2022-10-13 12:36 ` [PATCH] alpha: Use generic <asm-generic/io.h> #forregzbot Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e99d33ff-4bfe-4727-a5ca-f4987b871ccd@app.fastmail.com \
--to=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linus.walleij@linaro.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=mattst88@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox