Alpha arch development list
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Matthew Wilcox <willy@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ankur Arora <ankur.a.arora@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
	akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	mgorman@suse.de, rostedt@goodmis.org, jon.grimm@amd.com,
	bharata@amd.com, raghavendra.kt@amd.com,
	boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
	jgross@suse.com, andrew.cooper3@citrix.com,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@lists.linux-m68k.org,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipso>
Subject: Re: Arches that don't support PREEMPT
Date: Tue, 19 Sep 2023 19:58:31 +0200	[thread overview]
Message-ID: <64746d98b60f1677cecd26501511f140688801e1.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <CAHk-=wgUimqtF7PqFfRw4Ju5H1KYkp6+8F=hBz7amGQ8GaGKkA@mail.gmail.com>

Hi Linus!

On Tue, 2023-09-19 at 10:25 -0700, Linus Torvalds wrote:
> On Tue, 19 Sept 2023 at 06:48, John Paul Adrian Glaubitz
> <glaubitz@physik.fu-berlin.de> wrote:
> > 
> > As Geert poined out, I'm not seeing anything particular problematic with the
> > architectures lacking CONFIG_PREEMPT at the moment. This seems to be more
> > something about organizing KConfig files.
> 
> It can definitely be problematic.
> 
> Not the Kconfig file part, and not the preempt count part itself.
> 
> But the fact that it has never been used and tested means that there
> might be tons of "this architecture code knows it's not preemptible,
> because this architecture doesn't support preemption".
> 
> So you may have basic architecture code that simply doesn't have the
> "preempt_disable()/enable()" pairs that it needs.
> 
> PeterZ mentioned the generic entry code, which does this for the entry
> path. But it actually goes much deeper: just do a
> 
>     git grep preempt_disable arch/x86/kernel
> 
> and then do the same for some other architectures.
> 
> Looking at alpha, for example, there *are* hits for it, so at least
> some of the code there clearly *tries* to do it. But does it cover all
> the required parts? If it's never been tested, I'd be surprised if
> it's all just ready to go.

Thanks for the detailed explanation.

> I do think we'd need to basically continue to support ARCH_NO_PREEMPT
> - and such architectures migth end up with the worst-cast latencies of
> only scheduling at return to user space.

Great to hear, thank you.

And, yes, eventually I would be happy to help get alpha and m68k converted.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

  reply	other threads:[~2023-09-19 17:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87edj64rj1.fsf@oracle.com>
     [not found] ` <CAHk-=wi0bXpgULVVLc2AdJcta-fvQP7yyFQ_JtaoHUiPrqf--A@mail.gmail.com>
     [not found]   ` <87zg1u1h5t.fsf@oracle.com>
     [not found]     ` <CAHk-=whMkp68vNxVn1H3qe_P7n=X2sWPL9kvW22dsvMFH8FcQQ@mail.gmail.com>
     [not found]       ` <20230911150410.GC9098@noisy.programming.kicks-ass.net>
     [not found]         ` <87h6o01w1a.fsf@oracle.com>
     [not found]           ` <20230912082606.GB35261@noisy.programming.kicks-ass.net>
     [not found]             ` <87cyyfxd4k.ffs@tglx>
     [not found]               ` <CAHk-=whnwC01m_1f-gaM1xbvvwzwTiKitrWniA-ChZv+bM03dg@mail.gmail.com>
     [not found]                 ` <87led2wdj0.ffs@tglx>
2023-09-19 13:00                   ` Arches that don't support PREEMPT Matthew Wilcox
2023-09-19 13:34                     ` Geert Uytterhoeven
2023-09-19 13:37                     ` John Paul Adrian Glaubitz
2023-09-19 13:42                       ` Peter Zijlstra
2023-09-19 13:48                         ` John Paul Adrian Glaubitz
2023-09-19 14:16                           ` Peter Zijlstra
2023-09-19 14:24                             ` John Paul Adrian Glaubitz
2023-09-19 14:32                               ` Matthew Wilcox
2023-09-19 15:31                                 ` Steven Rostedt
2023-09-20 14:38                             ` Anton Ivanov
2023-09-21 12:20                             ` Arnd Bergmann
2023-09-19 14:17                           ` Thomas Gleixner
2023-09-19 14:50                             ` H. Peter Anvin
2023-09-19 14:57                               ` Matt Turner
2023-09-19 17:09                               ` Ulrich Teichert
2023-09-19 17:25                           ` Linus Torvalds
2023-09-19 17:58                             ` John Paul Adrian Glaubitz [this message]
2023-09-19 18:31                             ` Thomas Gleixner
2023-09-19 18:38                               ` Steven Rostedt
2023-09-19 18:52                                 ` Linus Torvalds
2023-09-19 19:53                                   ` Thomas Gleixner
2023-09-20  7:32                                 ` Ingo Molnar
2023-09-20  7:29                               ` Ingo Molnar
2023-09-20  8:26                             ` Thomas Gleixner
2023-09-20 10:37                             ` David Laight
2023-09-19 14:21                         ` Anton Ivanov
2023-09-19 15:17                           ` Thomas Gleixner
2023-09-19 15:21                             ` Anton Ivanov
2023-09-19 16:22                               ` Richard Weinberger
2023-09-19 16:41                                 ` Anton Ivanov
2023-09-19 17:33                                   ` Thomas Gleixner
2023-10-06 14:51                     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64746d98b60f1677cecd26501511f140688801e1.camel@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=ankur.a.arora@oracle.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=bharata@amd.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=geert@linux-m68k.org \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=johannes@sipso \
    --cc=jon.grimm@amd.com \
    --cc=juri.lelli@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@amd.com \
    --cc=richard@nod.at \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox