From: Krzysztof Halasa <khc@pm.waw.pl>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org,
Anton Vorontsov <avorontsov@mvista.com>,
Chris Metcalf <cmetcalf@tilera.com>,
Colin Cross <ccross@android.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Miao <eric.y.miao@gmail.com>,
Erik Gilling <konkers@android.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
"H. Peter Anvin" <hpa@zytor.com>, Imre Kaloz <kaloz@openwrt.org>,
Ingo Molnar <mingo@redhat.com>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Lennert Buytenhek <kernel@wantstofly.org>,
Matt Turner <mattst88@gmail.com>,
Nicolas Pitre <nico@fluxnic.net>, Olof Johansson <olof@lixom.net>,
Paul Mundt <lethal@linux-sh.org>,
Richard Henderson <rth@twiddle.net>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Mor ton <akpm@linux-foundation.org>,
linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: Make the struct pci_dev * argument of pci_fixup_irqs const.
Date: Thu, 21 Jul 2011 21:14:24 +0200 [thread overview]
Message-ID: <m3hb6fe99r.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20110610143021.GA26043@linux-mips.org> (Ralf Baechle's message of "Fri, 10 Jun 2011 15:30:21 +0100")
Ralf Baechle <ralf@linux-mips.org> writes:
> Aside of the usual motivation for constification, this function has a
> history of being abused a hook for interrupt and other fixups so I turned
> this function const ages ago in the MIPS code but it should be done
> treewide.
>
> Due to function pointer passing in varous places a few other functions
> had to be constified as well.
> arch/arm/mach-ixp4xx/avila-pci.c | 2 +-
> arch/arm/mach-ixp4xx/coyote-pci.c | 2 +-
> arch/arm/mach-ixp4xx/dsmg600-pci.c | 2 +-
> arch/arm/mach-ixp4xx/fsg-pci.c | 2 +-
> arch/arm/mach-ixp4xx/gateway7001-pci.c | 3 ++-
> arch/arm/mach-ixp4xx/goramo_mlr.c | 2 +-
> arch/arm/mach-ixp4xx/gtwx5715-pci.c | 2 +-
> arch/arm/mach-ixp4xx/ixdp425-pci.c | 2 +-
> arch/arm/mach-ixp4xx/ixdpg425-pci.c | 2 +-
> arch/arm/mach-ixp4xx/nas100d-pci.c | 2 +-
> arch/arm/mach-ixp4xx/nslu2-pci.c | 2 +-
> arch/arm/mach-ixp4xx/vulcan-pci.c | 2 +-
> arch/arm/mach-ixp4xx/wg302v2-pci.c | 2 +-
The IXP4xx part looks good to me.
Acked-by: Krzysztof Hałasa <khc@pm.waw.pl>
--
Krzysztof Halasa
prev parent reply other threads:[~2011-07-21 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 14:30 [PATCH] PCI: Make the struct pci_dev * argument of pci_fixup_irqs const Ralf Baechle
2011-06-11 23:01 ` David Miller
2011-06-13 4:24 ` Paul Mundt
2011-06-13 9:00 ` Guan Xuetao
2011-07-21 19:14 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hb6fe99r.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@mvista.com \
--cc=ccross@android.com \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=eric.y.miao@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jbarnes@virtuousgeek.org \
--cc=kaloz@openwrt.org \
--cc=kernel@wantstofly.org \
--cc=konkers@android.com \
--cc=lethal@linux-sh.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=nico@fluxnic.net \
--cc=olof@lixom.net \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox