Re: [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's

From: Neil Armstrong <neil.armstrong@linaro.org>
To: "Heiner Kallweit" <hkallweit1@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Marc Zyngier" <maz@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's
Date: Tue, 24 Jan 2023 08:16:45 +0100	[thread overview]
Message-ID: <0e48405a-d4e7-92a8-339f-4be2f4ec1378@linaro.org> (raw)
In-Reply-To: <cb62dfc0-cb3d-beba-6d0b-8db18583dda0@gmail.com>

Hi Heiner,

Le 23/01/2023 à 22:22, Heiner Kallweit a écrit :
> At first adjust some existing dtbs's so that they pass dtbs_check
> after switching bindings to yaml.

Thanks for this patchset, but please drop patches 1, 3 & 4, and take
in account the existing compatible usage in your new bindings like
I did in my conversion patchset.

While we did remove some bad compatibles we introduced a few years ago,
now the GXBB, GXL & GXM are now stable a aew LTS releases now and
a few other projects uses them as-is (U-Boot, BSDs, ...) so changing
the compatibles isn't an option anymore... and we can't know which
one they use and how the implementation behaves we must document
the existing usage without breaking any potential users (including linux).

Thanks,
Neil

> 
> Then switch further Amlogic Meson bindings to yaml.
> Tested with make targets dt_binding_check and dtbs_check.
> 
> Heiner Kallweit (8):
>    arm64: dts: meson-gx: Remove invalid pwm compatible
>    arm64: dts: amlogic: Fix non-compliant SD/SDIO node names
>    arm64: dts: meson-gx: Set only one compatible string for mmc
>    arm64: dts: amlogic: Remove invalid compatible string
>      amlogic,meson-gpio-intc
>    dt-bindings: rtc: Add Amlogic Meson vrtc controller binding
>    dt-bindings: pwm: Add Amlogic Meson PWM binding
>    dt-bindings: interrupt-controller: Add Amlogic Meson GPIO interrupt
>      controller binding
>    dt-bindings: pinctrl: Add Amlogic Meson pinctrl binding
> 
>   .../amlogic,meson-gpio-intc.txt               |  38 ------
>   .../amlogic,meson-gpio-intc.yaml              |  72 +++++++++++
>   .../pinctrl/amlogic,meson-pinctrl.yaml        | 121 ++++++++++++++++++
>   .../bindings/pinctrl/meson,pinctrl.txt        |  94 --------------
>   .../devicetree/bindings/pwm/pwm-amlogic.yaml  |  61 +++++++++
>   .../devicetree/bindings/pwm/pwm-meson.txt     |  29 -----
>   .../bindings/rtc/amlogic,meson-vrtc.yaml      |  50 ++++++++
>   .../bindings/rtc/rtc-meson-vrtc.txt           |  22 ----
>   arch/arm64/boot/dts/amlogic/meson-axg.dtsi    |   5 +-
>   .../boot/dts/amlogic/meson-g12-common.dtsi    |   7 +-
>   arch/arm64/boot/dts/amlogic/meson-gx.dtsi     |  15 +--
>   arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi   |   3 +-
>   arch/arm64/boot/dts/amlogic/meson-gxl.dtsi    |   3 +-
>   arch/arm64/boot/dts/amlogic/meson-s4.dtsi     |   3 +-
>   arch/arm64/boot/dts/amlogic/meson-sm1.dtsi    |   3 +-
>   15 files changed, 320 insertions(+), 206 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
>   create mode 100644 Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl.yaml
>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt
>   create mode 100644 Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>   delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-meson.txt
>   create mode 100644 Documentation/devicetree/bindings/rtc/amlogic,meson-vrtc.yaml
>   delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-meson-vrtc.txt
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic