* [PATCH AUTOSEL 5.4 08/35] ASoC: meson: g12a: add tohdmitx reset [not found] <20200316023411.1263-1-sashal@kernel.org> @ 2020-03-16 2:33 ` Sasha Levin 2020-03-16 8:28 ` Jerome Brunet 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2020-03-16 2:33 UTC (permalink / raw) To: linux-kernel, stable Cc: Sasha Levin, alsa-devel, Mark Brown, linux-amlogic, linux-arm-kernel, Jerome Brunet From: Jerome Brunet <jbrunet@baylibre.com> [ Upstream commit 22946f37557e27697aabc8e4f62642bfe4a17fd8 ] Reset the g12a hdmi codec glue on probe. This ensure a sane startup state. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Link: https://lore.kernel.org/r/20200221121146.1498427-1-jbrunet@baylibre.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- sound/soc/meson/g12a-tohdmitx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/meson/g12a-tohdmitx.c b/sound/soc/meson/g12a-tohdmitx.c index 9cfbd343a00c8..8a0db28a6a406 100644 --- a/sound/soc/meson/g12a-tohdmitx.c +++ b/sound/soc/meson/g12a-tohdmitx.c @@ -8,6 +8,7 @@ #include <linux/module.h> #include <sound/pcm_params.h> #include <linux/regmap.h> +#include <linux/reset.h> #include <sound/soc.h> #include <sound/soc-dai.h> @@ -378,6 +379,11 @@ static int g12a_tohdmitx_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; void __iomem *regs; struct regmap *map; + int ret; + + ret = device_reset(dev); + if (ret) + return ret; regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(regs)) -- 2.20.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.4 08/35] ASoC: meson: g12a: add tohdmitx reset 2020-03-16 2:33 ` [PATCH AUTOSEL 5.4 08/35] ASoC: meson: g12a: add tohdmitx reset Sasha Levin @ 2020-03-16 8:28 ` Jerome Brunet 2020-03-22 18:31 ` Jerome Brunet 0 siblings, 1 reply; 4+ messages in thread From: Jerome Brunet @ 2020-03-16 8:28 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: linux-amlogic, alsa-devel, Mark Brown, linux-arm-kernel, Kevin Hilman On Mon 16 Mar 2020 at 03:33, Sasha Levin <sashal@kernel.org> wrote: > From: Jerome Brunet <jbrunet@baylibre.com> > > [ Upstream commit 22946f37557e27697aabc8e4f62642bfe4a17fd8 ] > > Reset the g12a hdmi codec glue on probe. This ensure a sane startup state. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > Link: https://lore.kernel.org/r/20200221121146.1498427-1-jbrunet@baylibre.com > Signed-off-by: Mark Brown <broonie@kernel.org> > Signed-off-by: Sasha Levin <sashal@kernel.org> Hi Sasha, The tohdmitx reset property is not in the amlogic g12a DT in v5.4. Backporting this patch on v5.4 would break the hdmi sound, and probably the related sound card since the reset is not optional. Could you please drop this from v5.4 stable ? It is ok to keep it for v5.5. Thanks Jerome > --- > sound/soc/meson/g12a-tohdmitx.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/soc/meson/g12a-tohdmitx.c b/sound/soc/meson/g12a-tohdmitx.c > index 9cfbd343a00c8..8a0db28a6a406 100644 > --- a/sound/soc/meson/g12a-tohdmitx.c > +++ b/sound/soc/meson/g12a-tohdmitx.c > @@ -8,6 +8,7 @@ > #include <linux/module.h> > #include <sound/pcm_params.h> > #include <linux/regmap.h> > +#include <linux/reset.h> > #include <sound/soc.h> > #include <sound/soc-dai.h> > > @@ -378,6 +379,11 @@ static int g12a_tohdmitx_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > void __iomem *regs; > struct regmap *map; > + int ret; > + > + ret = device_reset(dev); > + if (ret) > + return ret; > > regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(regs)) _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.4 08/35] ASoC: meson: g12a: add tohdmitx reset 2020-03-16 8:28 ` Jerome Brunet @ 2020-03-22 18:31 ` Jerome Brunet 2020-03-22 19:39 ` Sasha Levin 0 siblings, 1 reply; 4+ messages in thread From: Jerome Brunet @ 2020-03-22 18:31 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: linux-amlogic, alsa-devel, Mark Brown, linux-arm-kernel, Kevin Hilman On Mon 16 Mar 2020 at 09:28, Jerome Brunet <jbrunet@baylibre.com> wrote: > On Mon 16 Mar 2020 at 03:33, Sasha Levin <sashal@kernel.org> wrote: > >> From: Jerome Brunet <jbrunet@baylibre.com> >> >> [ Upstream commit 22946f37557e27697aabc8e4f62642bfe4a17fd8 ] >> >> Reset the g12a hdmi codec glue on probe. This ensure a sane startup state. >> >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> >> Link: https://lore.kernel.org/r/20200221121146.1498427-1-jbrunet@baylibre.com >> Signed-off-by: Mark Brown <broonie@kernel.org> >> Signed-off-by: Sasha Levin <sashal@kernel.org> > > Hi Sasha, > > The tohdmitx reset property is not in the amlogic g12a DT in v5.4. > Backporting this patch on v5.4 would break the hdmi sound, and probably > the related sound card since the reset is not optional. > > Could you please drop this from v5.4 stable ? Hi Sasha, I just received a notification that this patch has been applied to 5.4 stable. As explained above, it will cause a regression. Could you please drop it from v5.4 stable ? Thanks Jerome > It is ok to keep it for v5.5. > > Thanks > Jerome > >> --- >> sound/soc/meson/g12a-tohdmitx.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/sound/soc/meson/g12a-tohdmitx.c b/sound/soc/meson/g12a-tohdmitx.c >> index 9cfbd343a00c8..8a0db28a6a406 100644 >> --- a/sound/soc/meson/g12a-tohdmitx.c >> +++ b/sound/soc/meson/g12a-tohdmitx.c >> @@ -8,6 +8,7 @@ >> #include <linux/module.h> >> #include <sound/pcm_params.h> >> #include <linux/regmap.h> >> +#include <linux/reset.h> >> #include <sound/soc.h> >> #include <sound/soc-dai.h> >> >> @@ -378,6 +379,11 @@ static int g12a_tohdmitx_probe(struct platform_device *pdev) >> struct device *dev = &pdev->dev; >> void __iomem *regs; >> struct regmap *map; >> + int ret; >> + >> + ret = device_reset(dev); >> + if (ret) >> + return ret; >> >> regs = devm_platform_ioremap_resource(pdev, 0); >> if (IS_ERR(regs)) _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.4 08/35] ASoC: meson: g12a: add tohdmitx reset 2020-03-22 18:31 ` Jerome Brunet @ 2020-03-22 19:39 ` Sasha Levin 0 siblings, 0 replies; 4+ messages in thread From: Sasha Levin @ 2020-03-22 19:39 UTC (permalink / raw) To: Jerome Brunet Cc: alsa-devel, Kevin Hilman, linux-kernel, stable, Mark Brown, linux-amlogic, linux-arm-kernel On Sun, Mar 22, 2020 at 07:31:31PM +0100, Jerome Brunet wrote: > >On Mon 16 Mar 2020 at 09:28, Jerome Brunet <jbrunet@baylibre.com> wrote: > >> On Mon 16 Mar 2020 at 03:33, Sasha Levin <sashal@kernel.org> wrote: >> >>> From: Jerome Brunet <jbrunet@baylibre.com> >>> >>> [ Upstream commit 22946f37557e27697aabc8e4f62642bfe4a17fd8 ] >>> >>> Reset the g12a hdmi codec glue on probe. This ensure a sane startup state. >>> >>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> >>> Link: https://lore.kernel.org/r/20200221121146.1498427-1-jbrunet@baylibre.com >>> Signed-off-by: Mark Brown <broonie@kernel.org> >>> Signed-off-by: Sasha Levin <sashal@kernel.org> >> >> Hi Sasha, >> >> The tohdmitx reset property is not in the amlogic g12a DT in v5.4. >> Backporting this patch on v5.4 would break the hdmi sound, and probably >> the related sound card since the reset is not optional. >> >> Could you please drop this from v5.4 stable ? > >Hi Sasha, > >I just received a notification that this patch has been applied to 5.4 >stable. > >As explained above, it will cause a regression. >Could you please drop it from v5.4 stable ? Hi Jerome, Sorry - I've missed your previous mail. Now dropped from all trees. -- Thanks, Sasha _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-22 19:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200316023411.1263-1-sashal@kernel.org>
2020-03-16 2:33 ` [PATCH AUTOSEL 5.4 08/35] ASoC: meson: g12a: add tohdmitx reset Sasha Levin
2020-03-16 8:28 ` Jerome Brunet
2020-03-22 18:31 ` Jerome Brunet
2020-03-22 19:39 ` Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox