* [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value [not found] <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> @ 2020-10-14 10:13 ` Serge Semin 2020-10-16 18:54 ` Rob Herring 2020-10-16 20:46 ` Martin Blumenstingl 2020-10-14 10:13 ` [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin 1 sibling, 2 replies; 6+ messages in thread From: Serge Semin @ 2020-10-14 10:13 UTC (permalink / raw) To: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Rob Herring, Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl Cc: devicetree, linux-snps-arc, linux-kernel, linux-mips, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Bjorn Andersson, Serge Semin, Manu Gautam, Andy Gross, Pavel Parkhomenko, linux-amlogic, Alexey Malahov, linuxppc-dev, linux-arm-kernel, Roger Quadros An empty snps,quirk-frame-length-adjustment won't cause any change performed by the driver. Moreover the DT schema validation will fail, since it expects the property being assigned with some value. So set fix the example by setting a valid FL-adj value in accordance with Neil Armstrong comment. Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/ Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Acked-by: Neil Armstrong <narmstrong@baylibre.com> --- Note the same problem is in the DT source file arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . --- .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml index 5b04a7dfa018..a4b44a16aaef 100644 --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml @@ -209,6 +209,6 @@ examples: interrupts = <30>; dr_mode = "host"; snps,dis_u2_susphy_quirk; - snps,quirk-frame-length-adjustment; + snps,quirk-frame-length-adjustment = <0x20>; }; }; -- 2.27.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value 2020-10-14 10:13 ` [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value Serge Semin @ 2020-10-16 18:54 ` Rob Herring 2020-10-16 20:46 ` Martin Blumenstingl 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2020-10-16 18:54 UTC (permalink / raw) To: Serge Semin Cc: Neil Armstrong, Bjorn Andersson, Pavel Parkhomenko, Jerome Brunet, Kevin Hilman, Andy Gross, linux-snps-arc, devicetree, Mathias Nyman, Martin Blumenstingl, Lad Prabhakar, Alexey Malahov, Rob Herring, linux-amlogic, linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin, linux-kernel, Manu Gautam, linuxppc-dev On Wed, 14 Oct 2020 13:13:56 +0300, Serge Semin wrote: > An empty snps,quirk-frame-length-adjustment won't cause any change > performed by the driver. Moreover the DT schema validation will fail, > since it expects the property being assigned with some value. So set > fix the example by setting a valid FL-adj value in accordance with > Neil Armstrong comment. > > Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/ > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Acked-by: Neil Armstrong <narmstrong@baylibre.com> > > --- > > Note the same problem is in the DT source file > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > --- > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value 2020-10-14 10:13 ` [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value Serge Semin 2020-10-16 18:54 ` Rob Herring @ 2020-10-16 20:46 ` Martin Blumenstingl 1 sibling, 0 replies; 6+ messages in thread From: Martin Blumenstingl @ 2020-10-16 20:46 UTC (permalink / raw) To: Serge Semin Cc: Neil Armstrong, Bjorn Andersson, Pavel Parkhomenko, Jerome Brunet, Kevin Hilman, Andy Gross, linux-snps-arc, devicetree, Mathias Nyman, Lad Prabhakar, Alexey Malahov, Rob Herring, linux-amlogic, linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin, linux-kernel, Manu Gautam, linuxppc-dev On Wed, Oct 14, 2020 at 12:14 PM Serge Semin <Sergey.Semin@baikalelectronics.ru> wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > performed by the driver. Moreover the DT schema validation will fail, > since it expects the property being assigned with some value. So set > fix the example by setting a valid FL-adj value in accordance with > Neil Armstrong comment. > > Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/ > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Acked-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes [not found] <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> 2020-10-14 10:13 ` [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value Serge Semin @ 2020-10-14 10:13 ` Serge Semin 2020-10-16 18:54 ` Rob Herring 2020-10-16 20:47 ` Martin Blumenstingl 1 sibling, 2 replies; 6+ messages in thread From: Serge Semin @ 2020-10-14 10:13 UTC (permalink / raw) To: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Rob Herring, Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl Cc: devicetree, linux-snps-arc, linux-kernel, linux-mips, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Bjorn Andersson, Serge Semin, Manu Gautam, Andy Gross, Pavel Parkhomenko, linux-amlogic, Alexey Malahov, linuxppc-dev, linux-arm-kernel, Roger Quadros Amlogic G12A USB DT sub-nodes are supposed to be compatible with the generic DWC USB2 and USB3 devices. Since now we've got DT schemas for both of the later IP cores let's make sure that the Amlogic G12A USB DT nodes are fully evaluated including the DWC sub-nodes. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> --- Changelog v2: - Use "oneOf: [dwc2.yaml#, snps,dwc3.yaml#]" instead of the bulky "if: properties: compatibe: ..." statement. --- .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml index a4b44a16aaef..7b2dc905c8ce 100644 --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml @@ -78,7 +78,9 @@ properties: patternProperties: "^usb@[0-9a-f]+$": - type: object + oneOf: + - $ref: dwc2.yaml# + - $ref: snps,dwc3.yaml# additionalProperties: false -- 2.27.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes 2020-10-14 10:13 ` [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin @ 2020-10-16 18:54 ` Rob Herring 2020-10-16 20:47 ` Martin Blumenstingl 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2020-10-16 18:54 UTC (permalink / raw) To: Serge Semin Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Jerome Brunet, Kevin Hilman, Andy Gross, linux-snps-arc, devicetree, Mathias Nyman, Martin Blumenstingl, Lad Prabhakar, Alexey Malahov, Rob Herring, linux-amlogic, Bjorn Andersson, linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin, Manu Gautam, linuxppc-dev On Wed, 14 Oct 2020 13:13:57 +0300, Serge Semin wrote: > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully evaluated including the DWC sub-nodes. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > > --- > > Changelog v2: > - Use "oneOf: [dwc2.yaml#, snps,dwc3.yaml#]" instead of the bulky "if: > properties: compatibe: ..." statement. > --- > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes 2020-10-14 10:13 ` [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin 2020-10-16 18:54 ` Rob Herring @ 2020-10-16 20:47 ` Martin Blumenstingl 1 sibling, 0 replies; 6+ messages in thread From: Martin Blumenstingl @ 2020-10-16 20:47 UTC (permalink / raw) To: Serge Semin Cc: Neil Armstrong, Bjorn Andersson, Pavel Parkhomenko, Jerome Brunet, Kevin Hilman, Andy Gross, linux-snps-arc, devicetree, Mathias Nyman, Lad Prabhakar, Alexey Malahov, Rob Herring, linux-amlogic, linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin, linux-kernel, Manu Gautam, linuxppc-dev On Wed, Oct 14, 2020 at 12:14 PM Serge Semin <Sergey.Semin@baikalelectronics.ru> wrote: > > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully evaluated including the DWC sub-nodes. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-16 20:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru>
2020-10-14 10:13 ` [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value Serge Semin
2020-10-16 18:54 ` Rob Herring
2020-10-16 20:46 ` Martin Blumenstingl
2020-10-14 10:13 ` [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin
2020-10-16 18:54 ` Rob Herring
2020-10-16 20:47 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox