* Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value
2020-10-20 11:59 ` [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin
@ 2020-10-20 12:34 ` Krzysztof Kozlowski
2020-10-20 12:44 ` Serge Semin
2020-10-20 13:06 ` Neil Armstrong
2020-10-20 19:38 ` Martin Blumenstingl
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-20 12:34 UTC (permalink / raw)
To: Serge Semin
Cc: Felipe Balbi, Florian Fainelli, Neil Armstrong,
Martin Blumenstingl, Kevin Hilman, linux-usb, linux-kernel,
Serge Semin, devicetree, Rob Herring, Greg Kroah-Hartman,
linux-amlogic, linux-arm-kernel, Jerome Brunet
On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the property is supposed to have
> uint32 type. It's erroneous from the DT schema and driver points of view
> to declare it as boolean.
I think the driver uses it as u32, so what do you mean by "declare" in
context of a driver?
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value
2020-10-20 12:34 ` Krzysztof Kozlowski
@ 2020-10-20 12:44 ` Serge Semin
2020-10-20 12:46 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Serge Semin @ 2020-10-20 12:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Felipe Balbi, Florian Fainelli, Neil Armstrong,
Martin Blumenstingl, Kevin Hilman, linux-usb, linux-kernel,
Serge Semin, devicetree, Rob Herring, Greg Kroah-Hartman,
linux-amlogic, linux-arm-kernel, Jerome Brunet
On Tue, Oct 20, 2020 at 02:34:04PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote:
> > In accordance with the DWC USB3 bindings the property is supposed to have
> > uint32 type. It's erroneous from the DT schema and driver points of view
> > to declare it as boolean.
>
> I think the driver uses it as u32, so what do you mean by "declare" in
> context of a driver?
I meant that both the driver and DT schema expects it to be uint32, while the
dts has got the property as boolean, which is wrong. The same problem has
been fixed in the Amlogic Meson-g12 DT schema example:
https://lore.kernel.org/linux-usb/20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru/T/#m225585212162b9f5cccb1a7088850fab8792b7b3
-Sergey
>
> Best regards,
> Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value
2020-10-20 12:44 ` Serge Semin
@ 2020-10-20 12:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-20 12:46 UTC (permalink / raw)
To: Serge Semin
Cc: Felipe Balbi, Florian Fainelli, Neil Armstrong,
Martin Blumenstingl, Kevin Hilman, linux-usb, linux-kernel,
Serge Semin, devicetree, Rob Herring, Greg Kroah-Hartman,
linux-amlogic, linux-arm-kernel, Jerome Brunet
On Tue, Oct 20, 2020 at 03:44:04PM +0300, Serge Semin wrote:
> On Tue, Oct 20, 2020 at 02:34:04PM +0200, Krzysztof Kozlowski wrote:
> > On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote:
> > > In accordance with the DWC USB3 bindings the property is supposed to have
> > > uint32 type. It's erroneous from the DT schema and driver points of view
> > > to declare it as boolean.
> >
>
> > I think the driver uses it as u32, so what do you mean by "declare" in
> > context of a driver?
>
> I meant that both the driver and DT schema expects it to be uint32, while the
> dts has got the property as boolean, which is wrong. The same problem has
> been fixed in the Amlogic Meson-g12 DT schema example:
> https://lore.kernel.org/linux-usb/20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru/T/#m225585212162b9f5cccb1a7088850fab8792b7b3
Ah, I got it.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value
2020-10-20 11:59 ` [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin
2020-10-20 12:34 ` Krzysztof Kozlowski
@ 2020-10-20 13:06 ` Neil Armstrong
2020-10-20 19:38 ` Martin Blumenstingl
2 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-10-20 13:06 UTC (permalink / raw)
To: Serge Semin, Felipe Balbi, Krzysztof Kozlowski, Florian Fainelli,
Rob Herring, Greg Kroah-Hartman, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: devicetree, linux-usb, linux-kernel, Serge Semin, linux-amlogic,
linux-arm-kernel
Hi Serge,
On 20/10/2020 13:59, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the property is supposed to have
> uint32 type. It's erroneous from the DT schema and driver points of view
> to declare it as boolean. As Neil suggested set it to 0x20 so not break
> the platform and to make the dtbs checker happy.
>
> Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 1e83ec5b8c91..3033ab2be1ff 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -2380,7 +2380,7 @@ dwc3: usb@ff500000 {
> interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> dr_mode = "host";
> snps,dis_u2_susphy_quirk;
> - snps,quirk-frame-length-adjustment;
> + snps,quirk-frame-length-adjustment = <0x20>;
> snps,parkmode-disable-ss-quirk;
> };
> };
>
You were faster than me !
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value
2020-10-20 11:59 ` [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin
2020-10-20 12:34 ` Krzysztof Kozlowski
2020-10-20 13:06 ` Neil Armstrong
@ 2020-10-20 19:38 ` Martin Blumenstingl
2 siblings, 0 replies; 6+ messages in thread
From: Martin Blumenstingl @ 2020-10-20 19:38 UTC (permalink / raw)
To: Serge Semin
Cc: Felipe Balbi, Florian Fainelli, Neil Armstrong, Kevin Hilman,
linux-usb, linux-kernel, Krzysztof Kozlowski, devicetree,
Rob Herring, Serge Semin, Greg Kroah-Hartman, linux-amlogic,
linux-arm-kernel, Jerome Brunet
On Tue, Oct 20, 2020 at 2:00 PM Serge Semin
<Sergey.Semin@baikalelectronics.ru> wrote:
>
> In accordance with the DWC USB3 bindings the property is supposed to have
> uint32 type. It's erroneous from the DT schema and driver points of view
> to declare it as boolean. As Neil suggested set it to 0x20 so not break
> the platform and to make the dtbs checker happy.
>
> Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread