From: Jonathan Cameron <jic23@kernel.org>
To: "Старк Георгий Николаевич" <GNStark@sberdevices.ru>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"khilman@baylibre.com" <khilman@baylibre.com>,
"jbrunet@baylibre.com" <jbrunet@baylibre.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"nuno.sa@analog.com" <nuno.sa@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v1] meson saradc: fix clock divider mask length
Date: Sat, 20 May 2023 16:46:18 +0100 [thread overview]
Message-ID: <20230520164618.08f26fd9@jic23-huawei> (raw)
In-Reply-To: <f0966e95-43c7-e6f6-8aeb-05f27691cec3@sberdevices.ru>
On Wed, 17 May 2023 16:47:59 +0000
Старк Георгий Николаевич <GNStark@sberdevices.ru> wrote:
> On 5/16/23 22:08, Martin Blumenstingl wrote:
> > Hi George,
> >
> > thank you for this patch!
> >
> > On Mon, May 15, 2023 at 11:06 PM George Stark <gnstark@sberdevices.ru> wrote:
> >> From: George Stark <GNStark@sberdevices.ru>
> >>
> >> According to datasheets of supported meson SOCs
> >> length of ADC_CLK_DIV field is 6 bits long
> > I have a question about this sentence which doesn't affect this patch
> > - it's only about managing expectations:
> > Which SoC are you referring to?
> > This divider is only relevant on older SoCs that predate GXBB (S905).
> > To my knowledge all SoCs from GXBB onwards place the divider in the
> > main or AO clock controller, so this bitmask is irrelevant there.
>
> Hello Martin
>
> I've checked datasheets of all chips listed in meson_sar_adc_of_match array in meson_saradc.c and everywhere this field is 6 bits long. According to driver code and existing dts files this patch affects all supported chips except meson8.
On that note, do we want to add any clarifying text on the scope to the
commit message?
Jonathan
>
> Best regards
> George
>
>
> >> Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs")
> >> Signed-off-by: George Stark <GNStark@sberdevices.ru>
> > Since my question above doesn't affect this patch:
> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> >
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-05-20 15:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 21:05 [PATCH v1] meson saradc: fix clock divider mask length George Stark
2023-05-16 8:22 ` neil.armstrong
2023-05-16 19:08 ` Martin Blumenstingl
2023-05-17 9:21 ` Dmitry Rokosov
2023-05-17 11:37 ` Vyacheslav
2023-05-17 19:28 ` Martin Blumenstingl
2023-05-22 9:04 ` Dmitry Rokosov
2023-05-22 15:47 ` Старк Георгий Николаевич
2023-05-29 20:41 ` Martin Blumenstingl
2023-05-31 11:33 ` George Stark
2023-06-01 20:52 ` George Stark
2023-06-05 20:18 ` Martin Blumenstingl
2023-06-06 12:53 ` George Stark
2023-05-17 16:47 ` Старк Георгий Николаевич
2023-05-20 15:46 ` Jonathan Cameron [this message]
2023-05-21 8:53 ` Andy Shevchenko
2023-05-22 9:11 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520164618.08f26fd9@jic23-huawei \
--to=jic23@kernel.org \
--cc=GNStark@sberdevices.ru \
--cc=andy.shevchenko@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox