From: neil.armstrong@linaro.org
To: George Stark <gnstark@sberdevices.ru>,
jic23@kernel.org, lars@metafoo.de, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
andy.shevchenko@gmail.com, nuno.sa@analog.com
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v1] meson saradc: fix clock divider mask length
Date: Tue, 16 May 2023 10:22:33 +0200 [thread overview]
Message-ID: <23cb7112-ce2e-cee6-2213-60fd599c998d@linaro.org> (raw)
In-Reply-To: <20230515210545.2100161-1-gnstark@sberdevices.ru>
On 15/05/2023 23:05, George Stark wrote:
> From: George Stark <GNStark@sberdevices.ru>
>
> According to datasheets of supported meson SOCs
> length of ADC_CLK_DIV field is 6 bits long
>
> Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs")
> Signed-off-by: George Stark <GNStark@sberdevices.ru>
> ---
> drivers/iio/adc/meson_saradc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 85b6826cc10c..b93ff42b8c19 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -72,7 +72,7 @@
> #define MESON_SAR_ADC_REG3_PANEL_DETECT_COUNT_MASK GENMASK(20, 18)
> #define MESON_SAR_ADC_REG3_PANEL_DETECT_FILTER_TB_MASK GENMASK(17, 16)
> #define MESON_SAR_ADC_REG3_ADC_CLK_DIV_SHIFT 10
> - #define MESON_SAR_ADC_REG3_ADC_CLK_DIV_WIDTH 5
> + #define MESON_SAR_ADC_REG3_ADC_CLK_DIV_WIDTH 6
> #define MESON_SAR_ADC_REG3_BLOCK_DLY_SEL_MASK GENMASK(9, 8)
> #define MESON_SAR_ADC_REG3_BLOCK_DLY_MASK GENMASK(7, 0)
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-05-16 8:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 21:05 [PATCH v1] meson saradc: fix clock divider mask length George Stark
2023-05-16 8:22 ` neil.armstrong [this message]
2023-05-16 19:08 ` Martin Blumenstingl
2023-05-17 9:21 ` Dmitry Rokosov
2023-05-17 11:37 ` Vyacheslav
2023-05-17 19:28 ` Martin Blumenstingl
2023-05-22 9:04 ` Dmitry Rokosov
2023-05-22 15:47 ` Старк Георгий Николаевич
2023-05-29 20:41 ` Martin Blumenstingl
2023-05-31 11:33 ` George Stark
2023-06-01 20:52 ` George Stark
2023-06-05 20:18 ` Martin Blumenstingl
2023-06-06 12:53 ` George Stark
2023-05-17 16:47 ` Старк Георгий Николаевич
2023-05-20 15:46 ` Jonathan Cameron
2023-05-21 8:53 ` Andy Shevchenko
2023-05-22 9:11 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23cb7112-ce2e-cee6-2213-60fd599c998d@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=gnstark@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox