Linux-Amlogic Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Add support for Amlogic T7 reset controller
@ 2024-04-22 11:11 Kelvin Zhang via B4 Relay
  2024-04-22 11:11 ` [PATCH v2 1/3] dt-bindings: reset: Add " Kelvin Zhang via B4 Relay
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Kelvin Zhang via B4 Relay @ 2024-04-22 11:11 UTC (permalink / raw)
  To: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong, Kelvin Zhang

Add a new compatible and device node for Amlogic T7 reset controller.
And modify the driver accordingly.

Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
---
Changes in v2:
- Drop the compatible comment in dt-binding.
- Move t7-reset.h to arch/arm64/boot/dts/amlogic.
- Link to v1: https://lore.kernel.org/r/20240329-t7-reset-v1-0-4c6e2e68359e@amlogic.com

---
Zelong Dong (3):
      dt-bindings: reset: Add Amlogic T7 reset controller
      reset: reset-meson: Add support for Amlogic T7 SoC reset controller
      arm64: dts: amlogic: Add Amlogic T7 reset controller

 .../bindings/reset/amlogic,meson-reset.yaml        |   1 +
 arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h     | 197 +++++++++++++++++++++
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi        |   7 +
 drivers/reset/reset-meson.c                        |   6 +
 4 files changed, 211 insertions(+)
---
base-commit: f529a6d274b3b8c75899e949649d231298f30a32
change-id: 20240329-t7-reset-f87e8346fadb

Best regards,
-- 
Kelvin Zhang <kelvin.zhang@amlogic.com>



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2 1/3] dt-bindings: reset: Add Amlogic T7 reset controller
  2024-04-22 11:11 [PATCH v2 0/3] Add support for Amlogic T7 reset controller Kelvin Zhang via B4 Relay
@ 2024-04-22 11:11 ` Kelvin Zhang via B4 Relay
  2024-04-22 15:31   ` Conor Dooley
  2024-04-22 11:11 ` [PATCH v2 2/3] reset: reset-meson: Add support for Amlogic T7 SoC " Kelvin Zhang via B4 Relay
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Kelvin Zhang via B4 Relay @ 2024-04-22 11:11 UTC (permalink / raw)
  To: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong, Kelvin Zhang

From: Zelong Dong <zelong.dong@amlogic.com>

Add a new compatible for Amlogic T7 reset controller.

Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
---
 Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
index f0c6c0df0ce3..695ef38a7bb3 100644
--- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
@@ -19,6 +19,7 @@ properties:
       - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
       - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
       - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
+      - amlogic,t7-reset
 
   reg:
     maxItems: 1

-- 
2.37.1



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 2/3] reset: reset-meson: Add support for Amlogic T7 SoC reset controller
  2024-04-22 11:11 [PATCH v2 0/3] Add support for Amlogic T7 reset controller Kelvin Zhang via B4 Relay
  2024-04-22 11:11 ` [PATCH v2 1/3] dt-bindings: reset: Add " Kelvin Zhang via B4 Relay
@ 2024-04-22 11:11 ` Kelvin Zhang via B4 Relay
  2024-04-22 11:11 ` [PATCH v2 3/3] arm64: dts: amlogic: Add Amlogic T7 " Kelvin Zhang via B4 Relay
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 12+ messages in thread
From: Kelvin Zhang via B4 Relay @ 2024-04-22 11:11 UTC (permalink / raw)
  To: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong, Kelvin Zhang

From: Zelong Dong <zelong.dong@amlogic.com>

There are 7 sets of Reset Source in Amlogic T7 SoC reset controller,
and the offset between base and level registers is 0x40.
Add a new compatible string and struct meson_reset_param to support
the reset controller on T7 SoC.

Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/reset/reset-meson.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
index f78be97898bc..1e9fca3e30e8 100644
--- a/drivers/reset/reset-meson.c
+++ b/drivers/reset/reset-meson.c
@@ -102,6 +102,11 @@ static const struct meson_reset_param meson_s4_param = {
 	.level_offset	= 0x40,
 };
 
+static const struct meson_reset_param t7_param = {
+	.reg_count      = 7,
+	.level_offset   = 0x40,
+};
+
 static const struct of_device_id meson_reset_dt_ids[] = {
 	 { .compatible = "amlogic,meson8b-reset",    .data = &meson8b_param},
 	 { .compatible = "amlogic,meson-gxbb-reset", .data = &meson8b_param},
@@ -109,6 +114,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
 	 { .compatible = "amlogic,meson-a1-reset",   .data = &meson_a1_param},
 	 { .compatible = "amlogic,meson-s4-reset",   .data = &meson_s4_param},
 	 { .compatible = "amlogic,c3-reset",   .data = &meson_s4_param},
+	 { .compatible = "amlogic,t7-reset",   .data = &t7_param},
 	 { /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, meson_reset_dt_ids);

-- 
2.37.1



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 3/3] arm64: dts: amlogic: Add Amlogic T7 reset controller
  2024-04-22 11:11 [PATCH v2 0/3] Add support for Amlogic T7 reset controller Kelvin Zhang via B4 Relay
  2024-04-22 11:11 ` [PATCH v2 1/3] dt-bindings: reset: Add " Kelvin Zhang via B4 Relay
  2024-04-22 11:11 ` [PATCH v2 2/3] reset: reset-meson: Add support for Amlogic T7 SoC " Kelvin Zhang via B4 Relay
@ 2024-04-22 11:11 ` Kelvin Zhang via B4 Relay
  2024-04-23  8:11 ` (subset) [PATCH v2 0/3] Add support for " Neil Armstrong
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 12+ messages in thread
From: Kelvin Zhang via B4 Relay @ 2024-04-22 11:11 UTC (permalink / raw)
  To: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong, Kelvin Zhang

From: Zelong Dong <zelong.dong@amlogic.com>

Add the device node and related header file
for Amlogic T7 reset controller.

Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h | 197 +++++++++++++++++++++++++
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi    |   7 +
 2 files changed, 204 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h b/arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h
new file mode 100644
index 000000000000..ec90a11df508
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h
@@ -0,0 +1,197 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
+/*
+ * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
+ */
+
+#ifndef __DTS_AMLOGIC_T7_RESET_H
+#define __DTS_AMLOGIC_T7_RESET_H
+
+/* RESET0 */
+/*					0-3	*/
+#define RESET_USB			4
+#define RESET_U2DRD			5
+#define RESET_U3DRD			6
+#define RESET_U3DRD_PIPE0		7
+#define RESET_U2PHY20			8
+#define RESET_U2PHY21			9
+#define RESET_GDC			10
+#define RESET_HDMI20_AES		11
+#define RESET_HDMIRX			12
+#define RESET_HDMIRX_APB		13
+#define RESET_DEWARP			14
+/*					15	*/
+#define RESET_HDMITX_CAPB3		16
+#define RESET_BRG_VCBUG_DEC		17
+#define RESET_VCBUS			18
+#define RESET_VID_PLL_DIV		19
+#define RESET_VDI6			20
+#define RESET_GE2D			21
+#define RESET_HDMITXPHY			22
+#define RESET_VID_LOCK			23
+#define RESET_VENC0			24
+#define RESET_VDAC			25
+#define RESET_VENC2			26
+#define RESET_VENC1			27
+#define RESET_RDMA			28
+#define RESET_HDMITX			29
+#define RESET_VIU			30
+#define RESET_VENC			31
+
+/* RESET1 */
+#define RESET_AUDIO			32
+#define RESET_MALI_CAPB3		33
+#define RESET_MALI			34
+#define RESET_DDR_APB			35
+#define RESET_DDR			36
+#define RESET_DOS_CAPB3			37
+#define RESET_DOS			38
+#define RESET_COMBO_DPHY_CHAN2		39
+#define RESET_DEBUG_B			40
+#define RESET_DEBUG_A			41
+#define RESET_DSP_B			42
+#define RESET_DSP_A			43
+#define RESET_PCIE_A			44
+#define RESET_PCIE_PHY			45
+#define RESET_PCIE_APB			46
+#define RESET_ANAKIN			47
+#define RESET_ETH			48
+#define RESET_EDP0_CTRL			49
+#define RESET_EDP1_CTRL			50
+#define RESET_COMBO_DPHY_CHAN0		51
+#define RESET_COMBO_DPHY_CHAN1		52
+#define RESET_DSI_LVDS_EDP_TOP		53
+#define RESET_PCIE1_PHY			54
+#define RESET_PCIE1_APB			55
+#define RESET_DDR_1			56
+/*					57	*/
+#define RESET_EDP1_PIPELINE		58
+#define RESET_EDP0_PIPELINE		59
+#define RESET_MIPI_DSI1_PHY		60
+#define RESET_MIPI_DSI0_PHY		61
+#define RESET_MIPI_DSI_A_HOST		62
+#define RESET_MIPI_DSI_B_HOST		63
+
+/* RESET2 */
+#define RESET_DEVICE_MMC_ARB		64
+#define RESET_IR_CTRL			65
+#define RESET_TS_A73			66
+#define RESET_TS_A53			67
+#define RESET_SPICC_2			68
+#define RESET_SPICC_3			69
+#define RESET_SPICC_4			70
+#define RESET_SPICC_5			71
+#define RESET_SMART_CARD		72
+#define RESET_SPICC_0			73
+#define RESET_SPICC_1			74
+#define RESET_RSA			75
+/*					76-79	*/
+#define RESET_MSR_CLK			80
+#define RESET_SPIFC			81
+#define RESET_SAR_ADC			82
+#define RESET_BT			83
+/*					84-87	*/
+#define RESET_ACODEC			88
+#define RESET_CEC			89
+#define RESET_AFIFO			90
+#define RESET_WATCHDOG			91
+/*					92-95	*/
+
+/* RESET3 */
+#define RESET_BRG_NIC1_GPV		96
+#define RESET_BRG_NIC2_GPV		97
+#define RESET_BRG_NIC3_GPV		98
+#define RESET_BRG_NIC4_GPV		99
+#define RESET_BRG_NIC5_GPV		100
+/*					101-121	*/
+#define RESET_MIPI_ISP			122
+#define RESET_BRG_ADB_MALI_1		123
+#define RESET_BRG_ADB_MALI_0		124
+#define RESET_BRG_ADB_A73		125
+#define RESET_BRG_ADB_A53		126
+#define RESET_BRG_CCI			127
+
+/* RESET4 */
+#define RESET_PWM_AO_AB			128
+#define RESET_PWM_AO_CD			129
+#define RESET_PWM_AO_EF			130
+#define RESET_PWM_AO_GH			131
+#define RESET_PWM_AB			132
+#define RESET_PWM_CD			133
+#define RESET_PWM_EF			134
+/*					135-137	*/
+#define RESET_UART_A			138
+#define RESET_UART_B			139
+#define RESET_UART_C			140
+#define RESET_UART_D			141
+#define RESET_UART_E			142
+#define RESET_UART_F			143
+#define RESET_I2C_S_A			144
+#define RESET_I2C_M_A			145
+#define RESET_I2C_M_B			146
+#define RESET_I2C_M_C			147
+#define RESET_I2C_M_D			148
+#define RESET_I2C_M_E			149
+#define RESET_I2C_M_F			150
+#define RESET_I2C_M_AO_A		151
+#define RESET_SD_EMMC_A			152
+#define RESET_SD_EMMC_B			153
+#define RESET_SD_EMMC_C			154
+#define RESET_I2C_M_AO_B		155
+#define RESET_TS_GPU			156
+#define RESET_TS_NNA			157
+#define RESET_TS_VPN			158
+#define RESET_TS_HEVC			159
+
+/* RESET5 */
+#define RESET_BRG_NOC_DDR_1		160
+#define RESET_BRG_NOC_DDR_0		161
+#define RESET_BRG_NOC_MAIN		162
+#define RESET_BRG_NOC_ALL		163
+/*					164-167	*/
+#define RESET_BRG_NIC2_SYS		168
+#define RESET_BRG_NIC2_MAIN		169
+#define RESET_BRG_NIC2_HDMI		170
+#define RESET_BRG_NIC2_ALL		171
+#define RESET_BRG_NIC3_WAVE		172
+#define RESET_BRG_NIC3_VDEC		173
+#define RESET_BRG_NIC3_HEVCF		174
+#define RESET_BRG_NIC3_HEVCB		175
+#define RESET_BRG_NIC3_HCODEC		176
+#define RESET_BRG_NIC3_GE2D		177
+#define RESET_BRG_NIC3_GDC		178
+#define RESET_BRG_NIC3_AMLOGIC		179
+#define RESET_BRG_NIC3_MAIN		180
+#define RESET_BRG_NIC3_ALL		181
+#define RESET_BRG_NIC5_VPU		182
+/*					183-185	*/
+#define RESET_BRG_NIC4_DSPB		186
+#define RESET_BRG_NIC4_DSPA		187
+#define RESET_BRG_NIC4_VAPB		188
+#define RESET_BRG_NIC4_CLK81		189
+#define RESET_BRG_NIC4_MAIN		190
+#define RESET_BRG_NIC4_ALL		191
+
+/* RESET6 */
+#define RESET_BRG_VDEC_PIPEL		192
+#define RESET_BRG_HEVCF_DMC_PIPEL	193
+#define RESET_BRG_NIC2TONIC4_PIPEL	194
+#define RESET_BRG_HDMIRXTONIC2_PIPEL	195
+#define RESET_BRG_SECTONIC4_PIPEL	196
+#define RESET_BRG_VPUTONOC_PIPEL	197
+#define RESET_BRG_NIC4TONOC_PIPEL	198
+#define RESET_BRG_NIC3TONOC_PIPEL	199
+#define RESET_BRG_NIC2TONOC_PIPEL	200
+#define RESET_BRG_NNATONOC_PIPEL	201
+#define RESET_BRG_FRISP3_PIPEL		202
+#define RESET_BRG_FRISP2_PIPEL		203
+#define RESET_BRG_FRISP1_PIPEL		204
+#define RESET_BRG_FRISP0_PIPEL		205
+/*					206-217	*/
+#define RESET_BRG_AMPIPE_NAND		218
+#define RESET_BRG_AMPIPE_ETH		219
+/*					220	*/
+#define RESET_BRG_AM2AXI0		221
+#define RESET_BRG_AM2AXI1		222
+#define RESET_BRG_AM2AXI2		223
+
+#endif /* ___DTS_AMLOGIC_T7_RESET_H */
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
index 5248bdf824ea..c23efc6c7ac0 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
@@ -5,6 +5,7 @@
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/amlogic,t7-pwrc.h>
+#include "amlogic-t7-reset.h"
 
 / {
 	interrupt-parent = <&gic>;
@@ -149,6 +150,12 @@ apb4: bus@fe000000 {
 			#size-cells = <2>;
 			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
 
+			reset: reset-controller@2000 {
+				compatible = "amlogic,t7-reset";
+				reg = <0x0 0x2000 0x0 0x98>;
+				#reset-cells = <1>;
+			};
+
 			watchdog@2100 {
 				compatible = "amlogic,t7-wdt";
 				reg = <0x0 0x2100 0x0 0x10>;

-- 
2.37.1



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: reset: Add Amlogic T7 reset controller
  2024-04-22 11:11 ` [PATCH v2 1/3] dt-bindings: reset: Add " Kelvin Zhang via B4 Relay
@ 2024-04-22 15:31   ` Conor Dooley
  0 siblings, 0 replies; 12+ messages in thread
From: Conor Dooley @ 2024-04-22 15:31 UTC (permalink / raw)
  To: kelvin.zhang
  Cc: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong


[-- Attachment #1.1: Type: text/plain, Size: 376 bytes --]

On Mon, Apr 22, 2024 at 07:11:43PM +0800, Kelvin Zhang via B4 Relay wrote:
> From: Zelong Dong <zelong.dong@amlogic.com>
> 
> Add a new compatible for Amlogic T7 reset controller.
> 
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: (subset) [PATCH v2 0/3] Add support for Amlogic T7 reset controller
  2024-04-22 11:11 [PATCH v2 0/3] Add support for Amlogic T7 reset controller Kelvin Zhang via B4 Relay
                   ` (2 preceding siblings ...)
  2024-04-22 11:11 ` [PATCH v2 3/3] arm64: dts: amlogic: Add Amlogic T7 " Kelvin Zhang via B4 Relay
@ 2024-04-23  8:11 ` Neil Armstrong
  2024-06-05 12:51 ` Neil Armstrong
  2024-09-02 10:10 ` Philipp Zabel
  5 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2024-04-23  8:11 UTC (permalink / raw)
  To: Philipp Zabel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Kelvin Zhang
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong

Hi,

On Mon, 22 Apr 2024 19:11:42 +0800, Kelvin Zhang wrote:
> Add a new compatible and device node for Amlogic T7 reset controller.
> And modify the driver accordingly.
> 
> 

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.10/arm64-dt)

[3/3] arm64: dts: amlogic: Add Amlogic T7 reset controller
      https://git.kernel.org/amlogic/c/a42f2e9ba13b8a4c556f43ed99e22ae14fb73130

These changes has been applied on the intermediate git tree [1].

The v6.10/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] Add support for Amlogic T7 reset controller
  2024-04-22 11:11 [PATCH v2 0/3] Add support for Amlogic T7 reset controller Kelvin Zhang via B4 Relay
                   ` (3 preceding siblings ...)
  2024-04-23  8:11 ` (subset) [PATCH v2 0/3] Add support for " Neil Armstrong
@ 2024-06-05 12:51 ` Neil Armstrong
  2024-07-11  9:21   ` Kelvin Zhang
  2024-08-28 10:00   ` Neil Armstrong
  2024-09-02 10:10 ` Philipp Zabel
  5 siblings, 2 replies; 12+ messages in thread
From: Neil Armstrong @ 2024-06-05 12:51 UTC (permalink / raw)
  To: kelvin.zhang, Philipp Zabel, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong

Hi Philipp,

On 22/04/2024 13:11, Kelvin Zhang via B4 Relay wrote:
> Add a new compatible and device node for Amlogic T7 reset controller.
> And modify the driver accordingly.
> 
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
> ---
> Changes in v2:
> - Drop the compatible comment in dt-binding.
> - Move t7-reset.h to arch/arm64/boot/dts/amlogic.
> - Link to v1: https://lore.kernel.org/r/20240329-t7-reset-v1-0-4c6e2e68359e@amlogic.com
> 
> ---
> Zelong Dong (3):
>        dt-bindings: reset: Add Amlogic T7 reset controller
>        reset: reset-meson: Add support for Amlogic T7 SoC reset controller
>        arm64: dts: amlogic: Add Amlogic T7 reset controller
> 
>   .../bindings/reset/amlogic,meson-reset.yaml        |   1 +
>   arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h     | 197 +++++++++++++++++++++
>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi        |   7 +

I applied the DT change, could you pick the bindings & driver change ?

Thanks,
Neil

>   drivers/reset/reset-meson.c                        |   6 +
>   4 files changed, 211 insertions(+)
> ---
> base-commit: f529a6d274b3b8c75899e949649d231298f30a32
> change-id: 20240329-t7-reset-f87e8346fadb
> 
> Best regards,


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] Add support for Amlogic T7 reset controller
  2024-06-05 12:51 ` Neil Armstrong
@ 2024-07-11  9:21   ` Kelvin Zhang
  2024-08-28 10:00   ` Neil Armstrong
  1 sibling, 0 replies; 12+ messages in thread
From: Kelvin Zhang @ 2024-07-11  9:21 UTC (permalink / raw)
  To: neil.armstrong, Philipp Zabel, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong

On 2024/6/5 20:51, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi Philipp,
> 
> On 22/04/2024 13:11, Kelvin Zhang via B4 Relay wrote:
>> Add a new compatible and device node for Amlogic T7 reset controller.
>> And modify the driver accordingly.
>>
>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
>> ---
>> Changes in v2:
>> - Drop the compatible comment in dt-binding.
>> - Move t7-reset.h to arch/arm64/boot/dts/amlogic.
>> - Link to v1: 
>> https://lore.kernel.org/r/20240329-t7-reset-v1-0-4c6e2e68359e@amlogic.com
>>
>> ---
>> Zelong Dong (3):
>>        dt-bindings: reset: Add Amlogic T7 reset controller
>>        reset: reset-meson: Add support for Amlogic T7 SoC reset 
>> controller
>>        arm64: dts: amlogic: Add Amlogic T7 reset controller
>>
>>   .../bindings/reset/amlogic,meson-reset.yaml        |   1 +
>>   arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h     | 197 
>> +++++++++++++++++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi        |   7 +
> 
> I applied the DT change, could you pick the bindings & driver change ?
> 
Hi Philipp,
Sorry to bother you.
For patch 1&2, is there anything that needs improvement?
Thanks very much!

> Thanks,
> Neil
> 
>>   drivers/reset/reset-meson.c                        |   6 +
>>   4 files changed, 211 insertions(+)
>> ---
>> base-commit: f529a6d274b3b8c75899e949649d231298f30a32
>> change-id: 20240329-t7-reset-f87e8346fadb
>>
>> Best regards,
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] Add support for Amlogic T7 reset controller
  2024-06-05 12:51 ` Neil Armstrong
  2024-07-11  9:21   ` Kelvin Zhang
@ 2024-08-28 10:00   ` Neil Armstrong
  1 sibling, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2024-08-28 10:00 UTC (permalink / raw)
  To: kelvin.zhang, Philipp Zabel, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong

Hi,

On 05/06/2024 14:51, Neil Armstrong wrote:
> Hi Philipp,
> 
> On 22/04/2024 13:11, Kelvin Zhang via B4 Relay wrote:
>> Add a new compatible and device node for Amlogic T7 reset controller.
>> And modify the driver accordingly.
>>
>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
>> ---
>> Changes in v2:
>> - Drop the compatible comment in dt-binding.
>> - Move t7-reset.h to arch/arm64/boot/dts/amlogic.
>> - Link to v1: https://lore.kernel.org/r/20240329-t7-reset-v1-0-4c6e2e68359e@amlogic.com
>>
>> ---
>> Zelong Dong (3):
>>        dt-bindings: reset: Add Amlogic T7 reset controller
>>        reset: reset-meson: Add support for Amlogic T7 SoC reset controller
>>        arm64: dts: amlogic: Add Amlogic T7 reset controller
>>
>>   .../bindings/reset/amlogic,meson-reset.yaml        |   1 +
>>   arch/arm64/boot/dts/amlogic/amlogic-t7-reset.h     | 197 +++++++++++++++++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi        |   7 +
> 
> I applied the DT change, could you pick the bindings & driver change ?

Gentle ping, could you apply the bindings & driver changes ?
If you lack time, please tell me if it's ok for you for me to apply the bindings via the amlogic tree ?

Neil

> 
> Thanks,
> Neil
> 
>>   drivers/reset/reset-meson.c                        |   6 +
>>   4 files changed, 211 insertions(+)
>> ---
>> base-commit: f529a6d274b3b8c75899e949649d231298f30a32
>> change-id: 20240329-t7-reset-f87e8346fadb
>>
>> Best regards,


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] Add support for Amlogic T7 reset controller
  2024-04-22 11:11 [PATCH v2 0/3] Add support for Amlogic T7 reset controller Kelvin Zhang via B4 Relay
                   ` (4 preceding siblings ...)
  2024-06-05 12:51 ` Neil Armstrong
@ 2024-09-02 10:10 ` Philipp Zabel
  2024-09-02 10:50   ` Zelong Dong
  2024-09-02 11:23   ` Neil Armstrong
  5 siblings, 2 replies; 12+ messages in thread
From: Philipp Zabel @ 2024-09-02 10:10 UTC (permalink / raw)
  To: kelvin.zhang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong

On Mo, 2024-04-22 at 19:11 +0800, Kelvin Zhang via B4 Relay wrote:
> Add a new compatible and device node for Amlogic T7 reset controller.
> And modify the driver accordingly.
> 
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>

Thank you, applied patches 1-2 to reset/next.

regards
Philipp

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] Add support for Amlogic T7 reset controller
  2024-09-02 10:10 ` Philipp Zabel
@ 2024-09-02 10:50   ` Zelong Dong
  2024-09-02 11:23   ` Neil Armstrong
  1 sibling, 0 replies; 12+ messages in thread
From: Zelong Dong @ 2024-09-02 10:50 UTC (permalink / raw)
  To: Philipp Zabel, kelvin.zhang, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Neil Armstrong, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel

Hi Philipp,

Thank, please let me know if you have any comments.

在 2024/9/2 18:10, Philipp Zabel 写道:
> 
> On Mo, 2024-04-22 at 19:11 +0800, Kelvin Zhang via B4 Relay wrote:
>> Add a new compatible and device node for Amlogic T7 reset controller.
>> And modify the driver accordingly.
>>
>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
> 
> Thank you, applied patches 1-2 to reset/next.
> 
> regards
> Philipp

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 0/3] Add support for Amlogic T7 reset controller
  2024-09-02 10:10 ` Philipp Zabel
  2024-09-02 10:50   ` Zelong Dong
@ 2024-09-02 11:23   ` Neil Armstrong
  1 sibling, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2024-09-02 11:23 UTC (permalink / raw)
  To: Philipp Zabel, kelvin.zhang, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
  Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
	Zelong Dong

On 02/09/2024 12:10, Philipp Zabel wrote:
> On Mo, 2024-04-22 at 19:11 +0800, Kelvin Zhang via B4 Relay wrote:
>> Add a new compatible and device node for Amlogic T7 reset controller.
>> And modify the driver accordingly.
>>
>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
> 
> Thank you, applied patches 1-2 to reset/next.

Thanks!

Neil

> 
> regards
> Philipp


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-09-02 11:23 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 11:11 [PATCH v2 0/3] Add support for Amlogic T7 reset controller Kelvin Zhang via B4 Relay
2024-04-22 11:11 ` [PATCH v2 1/3] dt-bindings: reset: Add " Kelvin Zhang via B4 Relay
2024-04-22 15:31   ` Conor Dooley
2024-04-22 11:11 ` [PATCH v2 2/3] reset: reset-meson: Add support for Amlogic T7 SoC " Kelvin Zhang via B4 Relay
2024-04-22 11:11 ` [PATCH v2 3/3] arm64: dts: amlogic: Add Amlogic T7 " Kelvin Zhang via B4 Relay
2024-04-23  8:11 ` (subset) [PATCH v2 0/3] Add support for " Neil Armstrong
2024-06-05 12:51 ` Neil Armstrong
2024-07-11  9:21   ` Kelvin Zhang
2024-08-28 10:00   ` Neil Armstrong
2024-09-02 10:10 ` Philipp Zabel
2024-09-02 10:50   ` Zelong Dong
2024-09-02 11:23   ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox