From: Christian Hewitt <christianshewitt@gmail.com>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linux Amlogic <linux-amlogic@lists.infradead.org>
Subject: Re: Regression caused by 066ecde6d826b443 ("mmc: meson-gx: add SDIO interrupt support")
Date: Sun, 12 Feb 2023 06:38:05 +0400 [thread overview]
Message-ID: <2CB0C2EC-B084-4185-843D-3DEADAC5864B@gmail.com> (raw)
In-Reply-To: <Y+g114kasLS6/x12@geday>
> On 12 Feb 2023, at 4:41 am, Geraldo Nascimento <geraldogabriel@gmail.com> wrote:
>
> On Sat, Feb 11, 2023 at 11:44:25PM +0100, Heiner Kallweit wrote:
>> On 11.02.2023 18:48, Geraldo Nascimento wrote:
>>> Hi Heiner and Ulf,
>>>
>>> After updating to kernel 6.2.0-rc7 from 5.19.1 my H96 Pro+ TV Box
>>> (Amlogic S912) failed to provide wifi. The module in question is a
>>> QCA9377 SDIO driven by ath10k.
>>>
>>> Reverting 066ecde6d826b443f492570e080cba3f2212280d
>>> ("mmc: meson-gx: add SDIO interrupt support")
>>> solves the problem and I have wifi again.
>>>
>>> Thanks,
>>> Geraldo Nascimento
>>
>> Supposedly this patch revealed an issue with incorrect interrupt
>> trigger types. A fix is currently in testing:
>> 87ef638d6557 ("TEST: arm64: dts: amlogic: Make mmc host controller interrupts level-sensitive")
>>
>
> Hi Heiner, and thanks for the quick reply.
>
> I reverted my revert and added the TEST patch about interrupts in the DT
> but still had no luck.
>
> What solved my problem was adding "cap-sdio-irq" to "sd_emmc_a" DT node.
> Now all is well.
Confirming that setting cap-sdio-irq resolved the continuing issues I’ve seen with an
QCA9337 module after restoring the SDIO irq changes and picking recent fixes to my
branch. Thanks Geraldo!
I’ve not observed issues with Broadcom modules, only QCA9377, but is this something
that should be defined for all sd_emmc_a nodes?
Christian
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-02-12 2:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 17:48 Regression caused by 066ecde6d826b443 ("mmc: meson-gx: add SDIO interrupt support") Geraldo Nascimento
2023-02-11 22:44 ` Heiner Kallweit
2023-02-12 0:41 ` Geraldo Nascimento
2023-02-12 2:38 ` Christian Hewitt [this message]
2023-02-12 11:55 ` Heiner Kallweit
2023-02-12 20:32 ` Geraldo Nascimento
2023-02-12 21:38 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2CB0C2EC-B084-4185-843D-3DEADAC5864B@gmail.com \
--to=christianshewitt@gmail.com \
--cc=geraldogabriel@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox