From: Heiner Kallweit <hkallweit1@gmail.com>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: Linux Amlogic <linux-amlogic@lists.infradead.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: Regression caused by 066ecde6d826b443 ("mmc: meson-gx: add SDIO interrupt support")
Date: Sun, 12 Feb 2023 22:38:11 +0100 [thread overview]
Message-ID: <d1e91460-1823-813a-82c7-90623829706c@gmail.com> (raw)
In-Reply-To: <Y+lM20XtiZ7CxftT@geday>
On 12.02.2023 21:32, Geraldo Nascimento wrote:
> On Sun, Feb 12, 2023 at 12:55:25PM +0100, Heiner Kallweit wrote:
>>
>> Could you please test whether the following fixes the issue for you
>> if cap-sdio-irq isn't set?
>>
>
> Hi Heiner,
>
> With this patch there are no problems even if cap-sdio-irq isn't set.
>
Thanks for testing and the feedback!
> But shouldn't we set this capability to take advantage of your new
> codepath? I noticed that on the old Amlogic BSP (downstream kernel) such
> capability was already being set on the DT, so it's not some sort of
> hack.
>
Right, next step is to add cap-sdio-irq to the chip family dtsi's.
My intention was to let users opt-in for SDIO IRQ mode and test,
before it's rolled out to all users.
> Thank you,
> Geraldo Nascimento
Heiner
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-02-12 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 17:48 Regression caused by 066ecde6d826b443 ("mmc: meson-gx: add SDIO interrupt support") Geraldo Nascimento
2023-02-11 22:44 ` Heiner Kallweit
2023-02-12 0:41 ` Geraldo Nascimento
2023-02-12 2:38 ` Christian Hewitt
2023-02-12 11:55 ` Heiner Kallweit
2023-02-12 20:32 ` Geraldo Nascimento
2023-02-12 21:38 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1e91460-1823-813a-82c7-90623829706c@gmail.com \
--to=hkallweit1@gmail.com \
--cc=geraldogabriel@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox