From: Neil Armstrong <neil.armstrong@linaro.org>
To: Sean Anderson <sanderson@brivo.com>,
Linus Walleij <linusw@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Qianggui Song <qianggui.song@amlogic.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] pinctrl: meson: Fix typo in s4 group name
Date: Thu, 27 Aug 2026 10:53:02 +0200 [thread overview]
Message-ID: <444d0f8f-e669-4267-b28c-697e205df51f@linaro.org> (raw)
In-Reply-To: <20260817162212.1890616-1-sanderson@brivo.com>
On 8/17/26 18:22, Sean Anderson wrote:
> One of the i2c pin groups has some junk at the end. The name should be
> i2c2_scl_h1, and indeed that's the name used by i2c2_pins3 in
> meson-s4.dtsi.
>
> Fixes: 775214d389c25 ("pinctrl: meson: add pinctrl driver support for Meson-S4 Soc")
> Signed-off-by: Sean Anderson <sanderson@brivo.com>
> ---
>
> drivers/pinctrl/meson/pinctrl-meson-s4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-s4.c b/drivers/pinctrl/meson/pinctrl-meson-s4.c
> index 872948699e9fe..365dafe457a9f 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-s4.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-s4.c
> @@ -854,7 +854,7 @@ static const char * const i2c1_groups[] = {
> static const char * const i2c2_groups[] = {
> "i2c2_sda_d", "i2c2_scl_d",
> "i2c2_sda_h8", "i2c2_scl_h9",
> - "i2c2_sda_h0", "i2c2_scl_h1l,"
> + "i2c2_sda_h0", "i2c2_scl_h1",
> };
>
> static const char * const i2c3_groups[] = {
> ---
> base-commit: 3b5f4b83c4abc0c9b0a7b9e2b44e816611b7f2ec
> branch: meson_pinctrl_group
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2026-08-27 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 16:22 [PATCH] pinctrl: meson: Fix typo in s4 group name Sean Anderson
2026-08-27 8:53 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444d0f8f-e669-4267-b28c-697e205df51f@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=qianggui.song@amlogic.com \
--cc=sanderson@brivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox