* [PATCH] pinctrl: meson: Fix typo in s4 group name
@ 2026-08-17 16:22 Sean Anderson
2026-08-27 8:53 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Sean Anderson @ 2026-08-17 16:22 UTC (permalink / raw)
To: Linus Walleij, Kevin Hilman, linux-gpio, linux-amlogic
Cc: Martin Blumenstingl, linux-arm-kernel, Neil Armstrong,
linux-kernel, Qianggui Song, Jerome Brunet, Sean Anderson
One of the i2c pin groups has some junk at the end. The name should be
i2c2_scl_h1, and indeed that's the name used by i2c2_pins3 in
meson-s4.dtsi.
Fixes: 775214d389c25 ("pinctrl: meson: add pinctrl driver support for Meson-S4 Soc")
Signed-off-by: Sean Anderson <sanderson@brivo.com>
---
drivers/pinctrl/meson/pinctrl-meson-s4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-s4.c b/drivers/pinctrl/meson/pinctrl-meson-s4.c
index 872948699e9fe..365dafe457a9f 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-s4.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-s4.c
@@ -854,7 +854,7 @@ static const char * const i2c1_groups[] = {
static const char * const i2c2_groups[] = {
"i2c2_sda_d", "i2c2_scl_d",
"i2c2_sda_h8", "i2c2_scl_h9",
- "i2c2_sda_h0", "i2c2_scl_h1l,"
+ "i2c2_sda_h0", "i2c2_scl_h1",
};
static const char * const i2c3_groups[] = {
---
base-commit: 3b5f4b83c4abc0c9b0a7b9e2b44e816611b7f2ec
branch: meson_pinctrl_group
--
2.53.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pinctrl: meson: Fix typo in s4 group name
2026-08-17 16:22 [PATCH] pinctrl: meson: Fix typo in s4 group name Sean Anderson
@ 2026-08-27 8:53 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2026-08-27 8:53 UTC (permalink / raw)
To: Sean Anderson, Linus Walleij, Kevin Hilman, linux-gpio,
linux-amlogic
Cc: Martin Blumenstingl, linux-arm-kernel, linux-kernel,
Qianggui Song, Jerome Brunet
On 8/17/26 18:22, Sean Anderson wrote:
> One of the i2c pin groups has some junk at the end. The name should be
> i2c2_scl_h1, and indeed that's the name used by i2c2_pins3 in
> meson-s4.dtsi.
>
> Fixes: 775214d389c25 ("pinctrl: meson: add pinctrl driver support for Meson-S4 Soc")
> Signed-off-by: Sean Anderson <sanderson@brivo.com>
> ---
>
> drivers/pinctrl/meson/pinctrl-meson-s4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-s4.c b/drivers/pinctrl/meson/pinctrl-meson-s4.c
> index 872948699e9fe..365dafe457a9f 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-s4.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-s4.c
> @@ -854,7 +854,7 @@ static const char * const i2c1_groups[] = {
> static const char * const i2c2_groups[] = {
> "i2c2_sda_d", "i2c2_scl_d",
> "i2c2_sda_h8", "i2c2_scl_h9",
> - "i2c2_sda_h0", "i2c2_scl_h1l,"
> + "i2c2_sda_h0", "i2c2_scl_h1",
> };
>
> static const char * const i2c3_groups[] = {
> ---
> base-commit: 3b5f4b83c4abc0c9b0a7b9e2b44e816611b7f2ec
> branch: meson_pinctrl_group
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-27 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-17 16:22 [PATCH] pinctrl: meson: Fix typo in s4 group name Sean Anderson
2026-08-27 8:53 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox