* [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars
@ 2020-08-31 10:23 Wolfram Sang
2020-08-31 18:35 ` Kevin Hilman
2020-09-02 9:03 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-08-31 10:23 UTC (permalink / raw)
To: linux-mmc
Cc: Ulf Hansson, Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
linux-kernel, Wolfram Sang, linux-amlogic, linux-arm-kernel,
Jerome Brunet
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Only buildtested. Found while analyzing retune-handling in the core.
drivers/mmc/host/meson-gx-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 08a3b1c05acb..a1db8685e30e 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
val |= ADJUST_ADJ_EN;
writel(val, host->regs + host->data->adjust);
- if (mmc->doing_retune)
+ if (mmc_doing_retune(mmc))
dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
else
dly = 0;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars
2020-08-31 10:23 [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars Wolfram Sang
@ 2020-08-31 18:35 ` Kevin Hilman
2020-09-02 9:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2020-08-31 18:35 UTC (permalink / raw)
To: Wolfram Sang, linux-mmc
Cc: Ulf Hansson, Neil Armstrong, Martin Blumenstingl, linux-kernel,
Wolfram Sang, linux-amlogic, linux-arm-kernel, Jerome Brunet
Wolfram Sang <wsa+renesas@sang-engineering.com> writes:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> ---
>
> Only buildtested. Found while analyzing retune-handling in the core.
>
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 08a3b1c05acb..a1db8685e30e 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
> val |= ADJUST_ADJ_EN;
> writel(val, host->regs + host->data->adjust);
>
> - if (mmc->doing_retune)
> + if (mmc_doing_retune(mmc))
> dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
> else
> dly = 0;
> --
> 2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars
2020-08-31 10:23 [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars Wolfram Sang
2020-08-31 18:35 ` Kevin Hilman
@ 2020-09-02 9:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-09-02 9:03 UTC (permalink / raw)
To: Wolfram Sang
Cc: Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
linux-mmc@vger.kernel.org, Linux Kernel Mailing List,
open list:ARM/Amlogic Meson..., Linux ARM, Jerome Brunet
On Mon, 31 Aug 2020 at 12:23, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> Only buildtested. Found while analyzing retune-handling in the core.
>
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 08a3b1c05acb..a1db8685e30e 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
> val |= ADJUST_ADJ_EN;
> writel(val, host->regs + host->data->adjust);
>
> - if (mmc->doing_retune)
> + if (mmc_doing_retune(mmc))
> dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
> else
> dly = 0;
> --
> 2.20.1
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-02 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-31 10:23 [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars Wolfram Sang
2020-08-31 18:35 ` Kevin Hilman
2020-09-02 9:03 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox