From: Neil Armstrong <narmstrong@baylibre.com>
To: Artem Lapkin <email2tema@gmail.com>
Cc: devicetree@vger.kernel.org, gouwa@khadas.com,
martin.blumenstingl@googlemail.com, khilman@baylibre.com,
christianshewitt@gmail.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, nick@khadas.com,
linux-amlogic@lists.infradead.org, art@khadas.com,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L
Date: Fri, 29 Jan 2021 09:57:55 +0100 [thread overview]
Message-ID: <c24ffddc-5e4b-d262-5ff4-e8771009af1c@baylibre.com> (raw)
In-Reply-To: <20210129085041.1408540-1-art@khadas.com>
Hi,
On 29/01/2021 09:50, Artem Lapkin wrote:
> move &sd_emmc_a ... from /* */ commented area, because cant load wifi fw
> without sd-uhs-sdr50 option on VIM3L
Seems it was an apply/merge issue here.
>
> [ 11.686590] brcmfmac: brcmf_chip_cores_check: CPU core not detected
> [ 11.696382] brcmfmac: brcmf_sdio_probe_attach: brcmf_chip_attach failed!
> [ 11.706240] brcmfmac: brcmf_sdio_probe: brcmf_sdio_probe_attach failed
> [ 11.715890] brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19...
> [ 13.718424] brcmfmac: brcmf_chip_recognition: chip backplane type 15 is not supported
>
Fixes: f1bb924e8f5b ("arm64: dts: meson: fix mmc0 tuning error on Khadas VIM3")
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> index 4b517ca72..29c785cf5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> @@ -89,13 +89,13 @@ &pcie {
> status = "okay";
> };
>
> -&sd_emmc_a {
> - sd-uhs-sdr50;
> -};
> -
> &usb {
> phys = <&usb2_phy0>, <&usb2_phy1>;
> phy-names = "usb2-phy0", "usb2-phy1";
> };
> */
>
> +&sd_emmc_a {
> + sd-uhs-sdr50;
> +};
> +
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-01-29 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 8:50 [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L Artem Lapkin
2021-01-29 8:57 ` Neil Armstrong [this message]
2021-02-03 19:27 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c24ffddc-5e4b-d262-5ff4-e8771009af1c@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox