* [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L
@ 2021-01-29 8:50 Artem Lapkin
2021-01-29 8:57 ` Neil Armstrong
2021-02-03 19:27 ` Kevin Hilman
0 siblings, 2 replies; 3+ messages in thread
From: Artem Lapkin @ 2021-01-29 8:50 UTC (permalink / raw)
To: narmstrong
Cc: devicetree, gouwa, martin.blumenstingl, khilman, christianshewitt,
linux-kernel, robh+dt, nick, linux-amlogic, art, linux-arm-kernel,
jbrunet
move &sd_emmc_a ... from /* */ commented area, because cant load wifi fw
without sd-uhs-sdr50 option on VIM3L
[ 11.686590] brcmfmac: brcmf_chip_cores_check: CPU core not detected
[ 11.696382] brcmfmac: brcmf_sdio_probe_attach: brcmf_chip_attach failed!
[ 11.706240] brcmfmac: brcmf_sdio_probe: brcmf_sdio_probe_attach failed
[ 11.715890] brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19...
[ 13.718424] brcmfmac: brcmf_chip_recognition: chip backplane type 15 is not supported
Signed-off-by: Artem Lapkin <art@khadas.com>
---
arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
index 4b517ca72..29c785cf5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
@@ -89,13 +89,13 @@ &pcie {
status = "okay";
};
-&sd_emmc_a {
- sd-uhs-sdr50;
-};
-
&usb {
phys = <&usb2_phy0>, <&usb2_phy1>;
phy-names = "usb2-phy0", "usb2-phy1";
};
*/
+&sd_emmc_a {
+ sd-uhs-sdr50;
+};
+
--
2.25.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L
2021-01-29 8:50 [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L Artem Lapkin
@ 2021-01-29 8:57 ` Neil Armstrong
2021-02-03 19:27 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2021-01-29 8:57 UTC (permalink / raw)
To: Artem Lapkin
Cc: devicetree, gouwa, martin.blumenstingl, khilman, christianshewitt,
linux-kernel, robh+dt, nick, linux-amlogic, art, linux-arm-kernel,
jbrunet
Hi,
On 29/01/2021 09:50, Artem Lapkin wrote:
> move &sd_emmc_a ... from /* */ commented area, because cant load wifi fw
> without sd-uhs-sdr50 option on VIM3L
Seems it was an apply/merge issue here.
>
> [ 11.686590] brcmfmac: brcmf_chip_cores_check: CPU core not detected
> [ 11.696382] brcmfmac: brcmf_sdio_probe_attach: brcmf_chip_attach failed!
> [ 11.706240] brcmfmac: brcmf_sdio_probe: brcmf_sdio_probe_attach failed
> [ 11.715890] brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19...
> [ 13.718424] brcmfmac: brcmf_chip_recognition: chip backplane type 15 is not supported
>
Fixes: f1bb924e8f5b ("arm64: dts: meson: fix mmc0 tuning error on Khadas VIM3")
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> index 4b517ca72..29c785cf5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> @@ -89,13 +89,13 @@ &pcie {
> status = "okay";
> };
>
> -&sd_emmc_a {
> - sd-uhs-sdr50;
> -};
> -
> &usb {
> phys = <&usb2_phy0>, <&usb2_phy1>;
> phy-names = "usb2-phy0", "usb2-phy1";
> };
> */
>
> +&sd_emmc_a {
> + sd-uhs-sdr50;
> +};
> +
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L
2021-01-29 8:50 [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L Artem Lapkin
2021-01-29 8:57 ` Neil Armstrong
@ 2021-02-03 19:27 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2021-02-03 19:27 UTC (permalink / raw)
To: Artem Lapkin, narmstrong
Cc: devicetree, gouwa, martin.blumenstingl, christianshewitt,
linux-kernel, robh+dt, nick, linux-amlogic, art, linux-arm-kernel,
jbrunet
On Fri, 29 Jan 2021 16:50:40 +0800, Artem Lapkin wrote:
> move &sd_emmc_a ... from /* */ commented area, because cant load wifi fw
> without sd-uhs-sdr50 option on VIM3L
>
> [ 11.686590] brcmfmac: brcmf_chip_cores_check: CPU core not detected
> [ 11.696382] brcmfmac: brcmf_sdio_probe_attach: brcmf_chip_attach failed!
> [ 11.706240] brcmfmac: brcmf_sdio_probe: brcmf_sdio_probe_attach failed
> [ 11.715890] brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19...
> [ 13.718424] brcmfmac: brcmf_chip_recognition: chip backplane type 15 is not supported
Applied, thanks!
[1/1] arm64: dts: meson: fix broken wifi node for Khadas VIM3L
commit: 39be8f441f78908e97ff913571e10ec03387a63a
Best regards,
--
Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-03 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-29 8:50 [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L Artem Lapkin
2021-01-29 8:57 ` Neil Armstrong
2021-02-03 19:27 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox