Linux-Amlogic Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1
@ 2026-11-15 22:29 Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 1/7] arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node Ronald Claveau via B4 Relay
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

Building the Amlogic device trees with W=1 CHECK_DTBS=y currently
produces several dtc warnings, all related to the same pattern:

  Warning (unit_address_vs_reg): /soc/bus@.../pinctrl@XXXX: node has a
  unit name, but no reg or ranges property
  Warning (simple_bus_reg): /soc/bus@.../pinctrl@XXXX: missing or
  empty reg/ranges property

The pinctrl nodes use an empty "ranges;" while having a unit address.

With this series applied, the Amlogic DTBs build without any warning
with:

  make ARCH=arm64 W=1 CHECK_DTBS=y amlogic/

Boot tested on Khadas VIM1 (GXL) and Khadas VIM4 (T7)

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
Ronald Claveau (7):
      arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node
      arm64: dts: amlogic: a1: Add ranges to periphs pinctrl node
      arm64: dts: amlogic: axg: Add ranges to periphs pinctrl node
      arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
      arm64: dts: amlogic: gxbb: Add ranges to periphs pinctrl node
      arm64: dts: amlogic: gxl: Add ranges to periphs pinctrl node
      arm64: dts: amlogic: s4: Add ranges to periphs pinctrl node

 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi       | 2 +-
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi         | 2 +-
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 5 +++--
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 ++----
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi       | 5 +++--
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi        | 5 +++--
 arch/arm64/boot/dts/amlogic/meson-s4.dtsi         | 2 +-
 7 files changed, 14 insertions(+), 13 deletions(-)
---
base-commit: 6d582d78fad9d828e575ca0cdcff8ea47a77220b
change-id: 20261115-fix-amlogic-dt-warnings-7cba2a4eb9d4

Best regards,
--  
Ronald Claveau <linux-kernel-dev@aliel.fr>



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/7] arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node
  2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
@ 2026-11-15 22:29 ` Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 2/7] arm64: dts: amlogic: a1: " Ronald Claveau via B4 Relay
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

From: Ronald Claveau <linux-kernel-dev@aliel.fr>

Building the amlogic DTBs with W=1 reports the following warnings
for the periphs pinctrl node:

  amlogic-t7.dtsi:317.34-615.6: Warning (unit_address_vs_reg):
  /soc/bus@fe000000/pinctrl@4000: node has a unit name, but no reg
  or ranges property
  amlogic-t7.dtsi:317.34-615.6: Warning (simple_bus_reg):
  /soc/bus@fe000000/pinctrl@4000: missing or empty reg/ranges property

The pinctrl node has no reg property of its own, and its empty
"ranges;" does not describe which address space is translated to the
children.

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
index 52e106d931db..aacdd0db1ca2 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
@@ -318,7 +318,7 @@ periphs_pinctrl: pinctrl@4000 {
 				compatible = "amlogic,t7-periphs-pinctrl";
 				#address-cells = <2>;
 				#size-cells = <2>;
-				ranges;
+				ranges = <0x0 0x4000 0x0 0x4000 0x0 0x2e0>;
 
 				gpio: bank@4000 {
 					reg = <0x0 0x4000 0x0 0x0064>,

-- 
2.43.0



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/7] arm64: dts: amlogic: a1: Add ranges to periphs pinctrl node
  2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 1/7] arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node Ronald Claveau via B4 Relay
@ 2026-11-15 22:29 ` Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 3/7] arm64: dts: amlogic: axg: " Ronald Claveau via B4 Relay
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

From: Ronald Claveau <linux-kernel-dev@aliel.fr>

Building the amlogic DTBs with W=1 reports the following warnings
for the periphs pinctrl node:

  meson-a1.dtsi:131.33-483.6: Warning (unit_address_vs_reg):
  /soc/bus@fe000000/pinctrl@400: node has a unit name, but no
  reg or ranges property
  meson-a1.dtsi:131.33-483.6: Warning (simple_bus_reg):
  /soc/bus@fe000000/pinctrl@400: missing or empty reg/ranges property

The pinctrl node has no reg property of its own, and its empty
"ranges;" does not describe which address space is translated to the
children.

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index 6f6a6145cba1..f59495c1885a 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -132,7 +132,7 @@ periphs_pinctrl: pinctrl@400 {
 				compatible = "amlogic,meson-a1-periphs-pinctrl";
 				#address-cells = <2>;
 				#size-cells = <2>;
-				ranges;
+				ranges = <0x0 0x400 0x0 0x400 0x0 0x198>;
 
 				gpio: bank@400 {
 					reg = <0x0 0x0400 0x0 0x003c>,

-- 
2.43.0



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/7] arm64: dts: amlogic: axg: Add ranges to periphs pinctrl node
  2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 1/7] arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 2/7] arm64: dts: amlogic: a1: " Ronald Claveau via B4 Relay
@ 2026-11-15 22:29 ` Ronald Claveau via B4 Relay
  2026-11-15 22:38   ` sashiko-bot
  2026-11-15 22:29 ` [PATCH 4/7] arm64: dts: amlogic: g12: " Ronald Claveau via B4 Relay
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

From: Ronald Claveau <linux-kernel-dev@aliel.fr>

  meson-axg.dtsi:360.33-1262.6: Warning (unit_address_vs_reg):
  /soc/bus@ff634000/pinctrl@480: node has a unit name, but no reg
  or ranges property
  meson-axg.dtsi:1609.30-1716.6: Warning (unit_address_vs_reg):
  /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
  or ranges property
  meson-axg.dtsi:360.33-1262.6: Warning (simple_bus_reg):
  /soc/bus@ff634000/pinctrl@480: missing or empty reg/ranges property
  meson-axg.dtsi:1609.30-1716.6: Warning (simple_bus_reg):
  /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 5b8ef98f6d03..dc932629c92c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -361,7 +361,8 @@ pinctrl_periphs: pinctrl@480 {
 				compatible = "amlogic,meson-axg-periphs-pinctrl";
 				#address-cells = <2>;
 				#size-cells = <2>;
-				ranges;
+				ranges = <0x0 0x480 0x0 0x480 0x0 0xb4>,
+					 <0x0 0x430 0x0 0x430 0x0 0x3c>;
 
 				gpio: bank@480 {
 					reg = <0x0 0x00480 0x0 0x40>,
@@ -1610,7 +1611,7 @@ pinctrl_aobus: pinctrl@14 {
 				compatible = "amlogic,meson-axg-aobus-pinctrl";
 				#address-cells = <2>;
 				#size-cells = <2>;
-				ranges;
+				ranges = <0x0 0x14 0x0 0x14 0x0 0x1c>;
 
 				gpio_ao: bank@14 {
 					reg = <0x0 0x00014 0x0 0x8>,

-- 
2.43.0



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/7] arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
  2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
                   ` (2 preceding siblings ...)
  2026-11-15 22:29 ` [PATCH 3/7] arm64: dts: amlogic: axg: " Ronald Claveau via B4 Relay
@ 2026-11-15 22:29 ` Ronald Claveau via B4 Relay
  2026-11-15 22:37   ` sashiko-bot
  2026-11-15 22:29 ` [PATCH 5/7] arm64: dts: amlogic: gxbb: " Ronald Claveau via B4 Relay
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

From: Ronald Claveau <linux-kernel-dev@aliel.fr>

Building the amlogic DTBs with W=1 reports the following warnings
for the periphs pinctrl node:

  meson-g12-common.dtsi:271.33-1554.7: Warning (unit_address_vs_reg):
  /soc/bus@ff600000/bus@34400/pinctrl@40: node has a unit name, but no
  reg or ranges property
  meson-g12-common.dtsi:1768.27-2040.6: Warning (unit_address_vs_reg):
  /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
  or ranges property
  meson-g12-common.dtsi:271.33-1554.7: Warning (simple_bus_reg):
  /soc/bus@ff600000/bus@34400/pinctrl@40: missing or empty reg/ranges
  property
  meson-g12-common.dtsi:1768.27-2040.6: Warning (simple_bus_reg):
  /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property
  meson-g12-common.dtsi:2239.23-2279.6: Warning
  (avoid_unnecessary_addr_size): /soc/bus@ffd00000/dsi@7000:
  unnecessary #address-cells/#size-cells without "ranges", "dma-ranges"
  or child "reg" or "ranges" property

The pinctrl node has no reg property of its own, and its empty
"ranges;" does not describe which address space is translated to the
children

  /soc/bus@ffd00000/dsi@7000: unnecessary #address-cells/#size-cells
  without "ranges", "dma-ranges" or child "reg" or "ranges" property

The DSI controller node has no child nodes with a reg property,
so #address-cells and #size-cells serve no purpose. Remove them.

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 3135566df880..434df25f6247 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -272,7 +272,7 @@ periphs_pinctrl: pinctrl@40 {
 					compatible = "amlogic,meson-g12a-periphs-pinctrl";
 					#address-cells = <2>;
 					#size-cells = <2>;
-					ranges;
+					ranges = <0x0 0x40 0x0 0x40 0x0 0x31c>;
 
 					gpio: bank@40 {
 						reg = <0x0 0x40  0x0 0x4c>,
@@ -1769,7 +1769,7 @@ ao_pinctrl: pinctrl@14 {
 				compatible = "amlogic,meson-g12a-aobus-pinctrl";
 				#address-cells = <2>;
 				#size-cells = <2>;
-				ranges;
+				ranges = <0x0 0x14 0x0 0x14 0x0 0x24>;
 
 				gpio_ao: bank@14 {
 					reg = <0x0 0x14 0x0 0x8>,
@@ -2247,8 +2247,6 @@ mipi_dsi: dsi@7000 {
 				clock-names = "pclk", "bit", "px";
 				phys = <&mipi_dphy>;
 				phy-names = "dphy";
-				#address-cells = <1>;
-				#size-cells = <0>;
 				status = "disabled";
 
 				assigned-clocks = <&clkc CLKID_MIPI_DSI_PXCLK_SEL>,

-- 
2.43.0



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 5/7] arm64: dts: amlogic: gxbb: Add ranges to periphs pinctrl node
  2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
                   ` (3 preceding siblings ...)
  2026-11-15 22:29 ` [PATCH 4/7] arm64: dts: amlogic: g12: " Ronald Claveau via B4 Relay
@ 2026-11-15 22:29 ` Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 6/7] arm64: dts: amlogic: gxl: " Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 7/7] arm64: dts: amlogic: s4: " Ronald Claveau via B4 Relay
  6 siblings, 0 replies; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

From: Ronald Claveau <linux-kernel-dev@aliel.fr>

  meson-gxbb.dtsi:88.28-265.4: Warning (unit_address_vs_reg):
  /soc/bus@c8100000/pinctrl@14: node has a unit name, but no reg
  or ranges property
  meson-gxbb.dtsi:367.31-739.4: Warning (unit_address_vs_reg):
  /soc/bus@c8834000/pinctrl@4b0: node has a unit name, but no reg
  or ranges property
  meson-gxbb.dtsi:88.28-265.4: Warning (simple_bus_reg):
  /soc/bus@c8100000/pinctrl@14: missing or empty reg/ranges property
  meson-gxbb.dtsi:367.31-739.4: Warning (simple_bus_reg):
  /soc/bus@c8834000/pinctrl@4b0: missing or empty reg/ranges property

The pinctrl node has no reg property of its own, and its empty
"ranges;" does not describe which address space is translated to the
children.

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 5c2fe9dc4f80..71bdb66e4f6d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -89,7 +89,7 @@ pinctrl_aobus: pinctrl@14 {
 		compatible = "amlogic,meson-gxbb-aobus-pinctrl";
 		#address-cells = <2>;
 		#size-cells = <2>;
-		ranges;
+		ranges = <0x0 0x14 0x0 0x14 0x0 0x1c>;
 
 		gpio_ao: bank@14 {
 			reg = <0x0 0x00014 0x0 0x8>,
@@ -368,7 +368,8 @@ pinctrl_periphs: pinctrl@4b0 {
 		compatible = "amlogic,meson-gxbb-periphs-pinctrl";
 		#address-cells = <2>;
 		#size-cells = <2>;
-		ranges;
+		ranges = <0x0 0x4b0 0x0 0x4b0 0x0 0x84>,
+			 <0x0 0x430 0x0 0x430 0x0 0x40>;
 
 		gpio: bank@4b0 {
 			reg = <0x0 0x004b0 0x0 0x28>,

-- 
2.43.0



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 6/7] arm64: dts: amlogic: gxl: Add ranges to periphs pinctrl node
  2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
                   ` (4 preceding siblings ...)
  2026-11-15 22:29 ` [PATCH 5/7] arm64: dts: amlogic: gxbb: " Ronald Claveau via B4 Relay
@ 2026-11-15 22:29 ` Ronald Claveau via B4 Relay
  2026-11-15 22:29 ` [PATCH 7/7] arm64: dts: amlogic: s4: " Ronald Claveau via B4 Relay
  6 siblings, 0 replies; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

From: Ronald Claveau <linux-kernel-dev@aliel.fr>

Building the amlogic DTBs with W=1 reports the following warnings
for the periphs pinctrl node:

  meson-gxl.dtsi:146.28-300.4: Warning (unit_address_vs_reg):
  /soc/bus@c8100000/pinctrl@14: node has a unit name, but no reg
  or ranges property
  meson-gxl.dtsi:369.31-780.4: Warning (unit_address_vs_reg):
  /soc/bus@c8834000/pinctrl@4b0: node has a unit name, but no reg
  or ranges property
  meson-gxl.dtsi:146.28-300.4: Warning (simple_bus_reg):
  /soc/bus@c8100000/pinctrl@14: missing or empty reg/ranges property
  meson-gxl.dtsi:369.31-780.4: Warning (simple_bus_reg):
  /soc/bus@c8834000/pinctrl@4b0: missing or empty reg/ranges property

The pinctrl node has no reg property of its own, and its empty
"ranges;" does not describe which address space is translated to the
children.

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index f257fe3860f7..59e7c6bb31e5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -147,7 +147,7 @@ pinctrl_aobus: pinctrl@14 {
 		compatible = "amlogic,meson-gxl-aobus-pinctrl";
 		#address-cells = <2>;
 		#size-cells = <2>;
-		ranges;
+		ranges = <0x0 0x14 0x0 0x14 0x0 0x1c>;
 
 		gpio_ao: bank@14 {
 			reg = <0x0 0x00014 0x0 0x8>,
@@ -370,7 +370,8 @@ pinctrl_periphs: pinctrl@4b0 {
 		compatible = "amlogic,meson-gxl-periphs-pinctrl";
 		#address-cells = <2>;
 		#size-cells = <2>;
-		ranges;
+		ranges = <0x0 0x4b0 0x0 0x4b0 0x0 0x84>,
+			 <0x0 0x430 0x0 0x430 0x0 0x40>;
 
 		gpio: bank@4b0 {
 			reg = <0x0 0x004b0 0x0 0x28>,

-- 
2.43.0



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 7/7] arm64: dts: amlogic: s4: Add ranges to periphs pinctrl node
  2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
                   ` (5 preceding siblings ...)
  2026-11-15 22:29 ` [PATCH 6/7] arm64: dts: amlogic: gxl: " Ronald Claveau via B4 Relay
@ 2026-11-15 22:29 ` Ronald Claveau via B4 Relay
  6 siblings, 0 replies; 10+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-11-15 22:29 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, linux-amlogic, devicetree, linux-kernel,
	Ronald Claveau

From: Ronald Claveau <linux-kernel-dev@aliel.fr>

Building the amlogic DTBs with W=1 reports the following warnings
for the periphs pinctrl node:

  meson-s4.dtsi:162.34-622.6: Warning (unit_address_vs_reg):
  /soc/bus@fe000000/pinctrl@4000: node has a unit name, but no reg
  or ranges property
  meson-s4.dtsi:162.34-622.6: Warning (simple_bus_reg):
  /soc/bus@fe000000/pinctrl@4000: missing or empty reg/ranges property

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
index 2a6fbd530836..a0b47c505ab5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
@@ -163,7 +163,7 @@ periphs_pinctrl: pinctrl@4000 {
 				compatible = "amlogic,meson-s4-periphs-pinctrl";
 				#address-cells = <2>;
 				#size-cells = <2>;
-				ranges;
+				ranges = <0x0 0x4000 0x0 0x4000 0x0 0x2e0>;
 
 				gpio: bank@4000 {
 					reg = <0x0 0x4000 0x0 0x004c>,

-- 
2.43.0



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/7] arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
  2026-11-15 22:29 ` [PATCH 4/7] arm64: dts: amlogic: g12: " Ronald Claveau via B4 Relay
@ 2026-11-15 22:37   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-15 22:37 UTC (permalink / raw)
  To: Ronald Claveau; +Cc: linux-amlogic, devicetree, robh, conor+dt, neil.armstrong

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: amlogic: commit subject and message mismatch with
  modified nodes
--

commit d018b851d0b76ba5915a6bfa884a1b1c4be5d03e
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

> arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
>
> Building the amlogic DTBs with W=1 reports the following warnings
> for the periphs pinctrl node:
>
>   meson-g12-common.dtsi:271.33-1554.7: Warning (unit_address_vs_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: node has a unit name, but no
>   reg or ranges property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (unit_address_vs_reg):
>   /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
>   or ranges property
>   meson-g12-common.dtsi:271.33-1554.7: Warning (simple_bus_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: missing or empty reg/ranges
>   property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (simple_bus_reg):
>   /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property
>   meson-g12-common.dtsi:2239.23-2279.6: Warning
>   (avoid_unnecessary_addr_size): /soc/bus@ffd00000/dsi@7000:
>   unnecessary #address-cells/#size-cells without "ranges", "dma-ranges"
>   or child "reg" or "ranges" property
>
> The pinctrl node has no reg property of its own, and its empty
> "ranges;" does not describe which address space is translated to the
> children
>
>   /soc/bus@ffd00000/dsi@7000: unnecessary #address-cells/#size-cells
>   without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> The DSI controller node has no child nodes with a reg property,
> so #address-cells and #size-cells serve no purpose. Remove them.
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

[Severity: Low]
This isn't a bug, but the commit subject and opening sentence only mention
the periphs_pinctrl node (pinctrl@40), whereas the patch also adds ranges to
ao_pinctrl (pinctrl@14) and removes #address-cells and #size-cells from the
unrelated mipi_dsi node (dsi@7000).

Should the mipi_dsi change be split into a separate commit (or reflected in
the subject alongside ao_pinctrl), and the duplicated dsi@7000 warning text
after the unpunctuated sentence ("...translated to the children") be cleaned
up?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-fix-amlogic-dt-warnings-v1-0-94cbd67a32ea@aliel.fr?part=4

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/7] arm64: dts: amlogic: axg: Add ranges to periphs pinctrl node
  2026-11-15 22:29 ` [PATCH 3/7] arm64: dts: amlogic: axg: " Ronald Claveau via B4 Relay
@ 2026-11-15 22:38   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-15 22:38 UTC (permalink / raw)
  To: Ronald Claveau; +Cc: linux-amlogic, devicetree, robh, conor+dt, neil.armstrong

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: amlogic: axg: commit message omits aobus pinctrl and
  explanation
--

commit df9ef90a65237fd0736035350fd16e31683b3d10
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

> arm64: dts: amlogic: axg: Add ranges to periphs pinctrl node
>
>   meson-axg.dtsi:360.33-1262.6: Warning (unit_address_vs_reg):
>   /soc/bus@ff634000/pinctrl@480: node has a unit name, but no reg
>   or ranges property
>   meson-axg.dtsi:1609.30-1716.6: Warning (unit_address_vs_reg):
>   /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
>   or ranges property
>   meson-axg.dtsi:360.33-1262.6: Warning (simple_bus_reg):
>   /soc/bus@ff634000/pinctrl@480: missing or empty reg/ranges property
>   meson-axg.dtsi:1609.30-1716.6: Warning (simple_bus_reg):
>   /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

[Severity: Low]
This isn't a bug, but the commit subject only mentions the periphs pinctrl
node even though the patch also updates pinctrl_aobus (pinctrl@14).  The
commit message body also consists only of the raw dtc warnings without
explaining why replacing the empty ranges properties with explicit address
ranges resolves them.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-fix-amlogic-dt-warnings-v1-0-94cbd67a32ea@aliel.fr?part=3

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-11-15 22:39 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 1/7] arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 2/7] arm64: dts: amlogic: a1: " Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 3/7] arm64: dts: amlogic: axg: " Ronald Claveau via B4 Relay
2026-11-15 22:38   ` sashiko-bot
2026-11-15 22:29 ` [PATCH 4/7] arm64: dts: amlogic: g12: " Ronald Claveau via B4 Relay
2026-11-15 22:37   ` sashiko-bot
2026-11-15 22:29 ` [PATCH 5/7] arm64: dts: amlogic: gxbb: " Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 6/7] arm64: dts: amlogic: gxl: " Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 7/7] arm64: dts: amlogic: s4: " Ronald Claveau via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox