From: netdev-bot+sashiko@kernel.org
To: zypulsecore@gmail.com
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
stephen@networkplumber.org, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH net 1/2] ipv4: accept nexthop dump attributes in route deletes
Date: Sun, 22 Nov 2026 09:50:11 +0000 [thread overview]
Message-ID: <179534101163.3135.4888476897314424157@kernel.org> (raw)
In-Reply-To: <20261118084510.332821-2-zypulsecore@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 1 · Medium: 0 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] The patch fixes `ip route flush` of nexthop-object routes for
IPv4 only.
- [Low] The commit message says the failure occurs "with nexthop
compatibility mode enabled" and gives a reproducer "in a fresh network…
--
ipv4: accept nexthop dump attributes in route deletes
This commit skips the check in rtm_to_fib_config() that makes RTA_NH_ID
and the expanded nexthop attributes mutually exclusive, but only for
RTM_DELROUTE requests. This lets ip route flush delete routes that use
nexthop objects when the dump carries both. The check stays in place for
RTM_NEWROUTE.
Link: https://lists.openwall.net/netdev/2026/10/26/186
> ip route flush reuses route dump messages as RTM_DELROUTE requests.
> With nexthop compatibility mode enabled, the dump includes RTA_NH_ID
> alongside expanded nexthop attributes. rtm_to_fib_config() rejects the
> combination with -EINVAL, leaving the routes installed.
[ ... ]
> report below. An unmodified kernel and iproute2 reproduced it without
> fault injection in a fresh network namespace with compatibility mode
> enabled.
[Severity: Low]
This isn't a bug, but "with nexthop compatibility mode enabled" reads like
an opt-in setting. Isn't compat mode already on by default in every network
namespace?
net/ipv4/af_inet.c:inet_init_net() {
...
net->ipv4.sysctl_nexthop_compat_mode = 1;
...
}
fib_dump_info() leaves out the expanded attributes only when compat mode
has been set to 0, so default configurations hit this bug.
Could the commit message say that default configurations are affected? That
would help with stable triage.
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index 8c123b111b3d8..6b012c8c6ea30 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -868,7 +868,10 @@ static int rtm_to_fib_config(struct net *net, struct sk_buff *skb,
> goto errout;
> }
>
> - if (cfg->fc_nh_id) {
> + /* Dumps can include both a nexthop ID and compatibility attributes.
> + * On deletion, fib_nh_match() uses the ID to match the nexthop.
> + */
> + if (cfg->fc_nh_id && nlh->nlmsg_type != RTM_DELROUTE) {
> if (cfg->fc_oif || cfg->fc_gw_family ||
> cfg->fc_encap || cfg->fc_mp) {
> NL_SET_ERR_MSG(extack,
[Severity: High]
Does IPv6 need the same change? rtm_to_fib6_config() in net/ipv6/route.c
still runs this check for every message type, including RTM_DELROUTE:
net/ipv6/route.c:rtm_to_fib6_config() {
...
if (tb[RTA_NH_ID]) {
if (tb[RTA_GATEWAY] || tb[RTA_OIF] ||
tb[RTA_MULTIPATH] || tb[RTA_ENCAP]) {
NL_SET_ERR_MSG(extack,
"Nexthop specification and nexthop id are mutually exclusive");
goto errout;
}
cfg->fc_nh_id = nla_get_u32(tb[RTA_NH_ID]);
}
...
}
err is already -EINVAL at this point.
In compat mode, rt6_fill_node() adds RTA_NH_ID to the dump and then calls
rt6_fill_node_nexthop(). For a group, that adds RTA_MULTIPATH. For a single
nexthop, fib_nexthop_info() adds RTA_OIF, plus RTA_GATEWAY when there is a
gateway. IPv6 nexthops always have a device, so RTA_OIF is always there.
When iproute2 sends that message back as RTM_DELROUTE, won't ip -6 route
flush on nhid routes fail with -EINVAL the same way, and leave the routes
installed?
ip6_route_del() already matches on the nexthop ID:
if (rt->nh && cfg->fc_nh_id &&
rt->nh->id != cfg->fc_nh_id)
continue;
It also skips routes without a nexthop object when fc_nh_id is set. That
suggests the same RTM_DELROUTE exemption would be safe in
rtm_to_fib6_config().
The commit message also says:
The IPv4 group and IPv6 compatibility selftests also passed with the fix.
This could be read as saying IPv6 is not affected. However, those selftests
never run ip -6 route flush, and this patch leaves the IPv6 path unchanged.
The later patch in the series ("selftests: net: test flushing IPv4 nexthop
routes in compat mode") also covers only IPv4 and does not touch
net/ipv6/route.c.
Could the series be extended to cover the IPv6 parser too?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118084510.332821-1-zypulsecore%40gmail.com
next prev parent reply other threads:[~2026-11-22 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:45 [PATCH net 0/2] ipv4: allow route dump replay with nexthop IDs Yuen Su
2026-11-18 8:45 ` [PATCH net 1/2] ipv4: accept nexthop dump attributes in route deletes Yuen Su
2026-11-18 12:21 ` Ido Schimmel
2026-11-19 15:47 ` David Ahern
2026-11-22 9:50 ` netdev-bot+sashiko [this message]
2026-11-18 8:45 ` [PATCH net 2/2] selftests: net: test flushing IPv4 nexthop routes in compat mode Yuen Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179534101163.3135.4888476897314424157@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=zypulsecore@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox