[PATCH v6 0/3] Enable PPI sysfs interface for TPM 2.0

[PATCH v6 0/3] Enable PPI sysfs interface for TPM 2.0

[Jarkko Sakkinen]

Changes since v5:
* Updated documentation.

Changes since v4:
* Removed dangling export of kernfs_remove_by_name_ns() from the sysfs
  patch.

Changes since v3:
* Use sysfs_remove_link()

Changes since v2:
* Fixed to_tpm_chip() macro.
* Split into two patches.
* Renamed sysfs_link_group_to_kobj to sysfs_link_entry_to_kobj
* Only create the "backwards compatibility" symlink for TPM 1.x devices.

Jarkko Sakkinen (3):
  sysfs: added sysfs_link_entry_to_kobj()
  tpm: move the PPI attributes to character device directory.
  tpm: update PPI documentation to address the location change.

 Documentation/ABI/testing/sysfs-driver-ppi | 19 +++++++++-----
 drivers/char/tpm/tpm-chip.c                | 24 +++++++++++------
 drivers/char/tpm/tpm.h                     | 17 +++++-------
 drivers/char/tpm/tpm_ppi.c                 | 34 ++++++++----------------
 fs/sysfs/group.c                           | 42 ++++++++++++++++++++++++++++++
 include/linux/sysfs.h                      |  8 ++++++
 6 files changed, 95 insertions(+), 49 deletions(-)

-- 
2.1.4

[PATCH v6 3/3] tpm: update PPI documentation to address the location change.

[Jarkko Sakkinen]

Updated Documentation/ABI/testing/sysfs-driver-ppi in order to explain
where PPI attributes are located and how backwards compatiblity is
addressed.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 Documentation/ABI/testing/sysfs-driver-ppi | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-driver-ppi b/Documentation/ABI/testing/sysfs-driver-ppi
index 7d1435b..9921ef2 100644
--- a/Documentation/ABI/testing/sysfs-driver-ppi
+++ b/Documentation/ABI/testing/sysfs-driver-ppi
@@ -1,4 +1,4 @@
-What:		/sys/devices/pnp0/<bus-num>/ppi/
+What:		/sys/class/tpm/tpmX/ppi/
 Date:		August 2012
 Kernel Version:	3.6
 Contact:	xiaoyan.zhang@intel.com
@@ -8,9 +8,14 @@ Description:
 		folder makes sense. The folder path can be got by command
 		'find /sys/ -name 'pcrs''. For the detail information of PPI,
 		please refer to the PPI specification from
+
 		http://www.trustedcomputinggroup.org/
 
-What:		/sys/devices/pnp0/<bus-num>/ppi/version
+		In Linux 4.2 ppi was moved to the character device directory.
+		A symlink from tpmX/device/ppi to tpmX/ppi to provide backwards
+		compatibility.
+
+What:		/sys/class/tpm/tpmX/ppi/version
 Date:		August 2012
 Contact:	xiaoyan.zhang@intel.com
 Description:
@@ -18,7 +23,7 @@ Description:
 		platform.
 		This file is readonly.
 
-What:		/sys/devices/pnp0/<bus-num>/ppi/request
+What:		/sys/class/tpm/tpmX/ppi/request
 Date:		August 2012
 Contact:	xiaoyan.zhang@intel.com
 Description:
@@ -28,7 +33,7 @@ Description:
 		integer value range from 1 to 160, and 0 means no request.
 		This file can be read and written.
 
-What:		/sys/devices/pnp0/00:<bus-num>/ppi/response
+What:		/sys/class/tpm/tpmX/ppi/response
 Date:		August 2012
 Contact:	xiaoyan.zhang@intel.com
 Description:
@@ -37,7 +42,7 @@ Description:
 		: <response description>".
 		This file is readonly.
 
-What:		/sys/devices/pnp0/<bus-num>/ppi/transition_action
+What:		/sys/class/tpm/tpmX/ppi/transition_action
 Date:		August 2012
 Contact:	xiaoyan.zhang@intel.com
 Description:
@@ -47,7 +52,7 @@ Description:
 		description>".
 		This file is readonly.
 
-What:		/sys/devices/pnp0/<bus-num>/ppi/tcg_operations
+What:		/sys/class/tpm/tpmX/ppi/tcg_operations
 Date:		August 2012
 Contact:	xiaoyan.zhang@intel.com
 Description:
@@ -58,7 +63,7 @@ Description:
 		This attribute is only supported by PPI version 1.2+.
 		This file is readonly.
 
-What:		/sys/devices/pnp0/<bus-num>/ppi/vs_operations
+What:		/sys/class/tpm/tpmX/ppi/vs_operations
 Date:		August 2012
 Contact:	xiaoyan.zhang@intel.com
 Description:
-- 
2.1.4

Re: [PATCH v6 0/3] Enable PPI sysfs interface for TPM 2.0

[Jarkko Sakkinen]

Hi

Any feedback on this?

/Jarkko

On Wed, May 20, 2015 at 04:49:21PM +0300, Jarkko Sakkinen wrote:
> Changes since v5:
> * Updated documentation.
> 
> Changes since v4:
> * Removed dangling export of kernfs_remove_by_name_ns() from the sysfs
>   patch.
> 
> Changes since v3:
> * Use sysfs_remove_link()
> 
> Changes since v2:
> * Fixed to_tpm_chip() macro.
> * Split into two patches.
> * Renamed sysfs_link_group_to_kobj to sysfs_link_entry_to_kobj
> * Only create the "backwards compatibility" symlink for TPM 1.x devices.
> 
> Jarkko Sakkinen (3):
>   sysfs: added sysfs_link_entry_to_kobj()
>   tpm: move the PPI attributes to character device directory.
>   tpm: update PPI documentation to address the location change.
> 
>  Documentation/ABI/testing/sysfs-driver-ppi | 19 +++++++++-----
>  drivers/char/tpm/tpm-chip.c                | 24 +++++++++++------
>  drivers/char/tpm/tpm.h                     | 17 +++++-------
>  drivers/char/tpm/tpm_ppi.c                 | 34 ++++++++----------------
>  fs/sysfs/group.c                           | 42 ++++++++++++++++++++++++++++++
>  include/linux/sysfs.h                      |  8 ++++++
>  6 files changed, 95 insertions(+), 49 deletions(-)
> 
> -- 
> 2.1.4
>