From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: dann frazier
<dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Shuah Khan <shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM
Date: Tue, 06 Jan 2015 13:03:12 -0700 [thread overview]
Message-ID: <54AC3F80.5060406@osg.samsung.com> (raw)
In-Reply-To: <1420512880-392-1-git-send-email-dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
On 01/05/2015 07:54 PM, dann frazier wrote:
> We can't use a char type to check for a negative return value since char
> isn't guaranteed to be signed. Indeed, the char type tends to be unsigned on
> ARM.
>
> Signed-off-by: dann frazier <dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
> tools/testing/selftests/mqueue/mq_perf_tests.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
> index 94dae65..8519e9e 100644
> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
> @@ -536,10 +536,9 @@ int main(int argc, char *argv[])
> {
> struct mq_attr attr;
> char *option, *next_option;
> - int i, cpu;
> + int i, cpu, rc;
> struct sigaction sa;
> poptContext popt_context;
> - char rc;
> void *retval;
>
> main_thread = pthread_self();
>
Thanks. Applied to kernel/git/shuah/linux-kselftest fixes branch
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
prev parent reply other threads:[~2015-01-06 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 2:54 [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM dann frazier
[not found] ` <1420512880-392-1-git-send-email-dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2015-01-06 20:03 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AC3F80.5060406@osg.samsung.com \
--to=shuahkh-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
--cc=dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox