[PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM

[PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM

[dann frazier]

We can't use a char type to check for a negative return value since char
isn't guaranteed to be signed. Indeed, the char type tends to be unsigned on
ARM.

Signed-off-by: dann frazier <dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
---
 tools/testing/selftests/mqueue/mq_perf_tests.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
index 94dae65..8519e9e 100644
--- a/tools/testing/selftests/mqueue/mq_perf_tests.c
+++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
@@ -536,10 +536,9 @@ int main(int argc, char *argv[])
 {
 	struct mq_attr attr;
 	char *option, *next_option;
-	int i, cpu;
+	int i, cpu, rc;
 	struct sigaction sa;
 	poptContext popt_context;
-	char rc;
 	void *retval;
 
 	main_thread = pthread_self();
-- 
2.1.4

Re: [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM

[Shuah Khan]

On 01/05/2015 07:54 PM, dann frazier wrote:
> We can't use a char type to check for a negative return value since char
> isn't guaranteed to be signed. Indeed, the char type tends to be unsigned on
> ARM.
> 
> Signed-off-by: dann frazier <dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
>  tools/testing/selftests/mqueue/mq_perf_tests.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
> index 94dae65..8519e9e 100644
> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
> @@ -536,10 +536,9 @@ int main(int argc, char *argv[])
>  {
>  	struct mq_attr attr;
>  	char *option, *next_option;
> -	int i, cpu;
> +	int i, cpu, rc;
>  	struct sigaction sa;
>  	poptContext popt_context;
> -	char rc;
>  	void *retval;
>  
>  	main_thread = pthread_self();
> 

Thanks. Applied to kernel/git/shuah/linux-kselftest fixes branch

-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978