* [PATCH] pidfd: restrict pidfd_getfd() to the caller's pid namespace
@ 2026-11-17 15:23 Jiwoo Kim
2026-11-17 16:20 ` Bradley Morgan
0 siblings, 1 reply; 2+ messages in thread
From: Jiwoo Kim @ 2026-11-17 15:23 UTC (permalink / raw)
To: Christian Brauner
Cc: Sargun Dhillon, Arnd Bergmann, Jann Horn, Chen Linxuan,
linux-fsdevel, linux-api, linux-kernel
pidfds can cross pid namespace boundaries: a task can obtain one for a
process outside of its own pid namespace hierarchy through SO_PASSPIDFD
or SO_PEERPIDFD, via SCM_RIGHTS, or through file descriptor
inheritance.
Commit ee8323fdc827 ("pidfd: restrict task access ioctls to the caller's
pid namespace") made the pidfs namespace ioctls fail with -EREMOTE
unless the target is visible in the caller's active pid namespace, as
PIDFD_GET_INFO already does, following the rule that operations which
grant access to additional resources of the target require this [1].
pidfd_getfd() grants access to the target's open files, but it only
performs the ptrace access check, which does not take the pid namespace
relationship between the caller and the target into account. With the
caller in a child pid namespace and in the same user namespace as the
target, PIDFD_GET_INFO and PIDFD_GET_UTS_NAMESPACE fail with -EREMOTE
for such a pidfd, while pidfd_getfd() on the same pidfd returns a
duplicate of the target's file descriptor.
Apply the same rule to pidfd_getfd() and fail with -EREMOTE unless the
target is visible in the caller's active pid namespace. Callers in
ancestor pid namespaces are unaffected.
This was found with an AI coding assistant, which also drafted this
patch and its changelog. The problem was reproduced in a QEMU guest,
and the fix was tested there.
Link: https://lore.kernel.org/all/20260925-gewischt-auftrag-tierzucht-c153cb3f9f74@brauner/ [1]
Fixes: 8649c322f75c ("pid: Implement pidfd_getfd syscall")
Cc: stable@vger.kernel.org
Signed-off-by: Jiwoo Kim <arpe1618@gmail.com>
---
-EREMOTE is a new error for pidfd_getfd(). The check is done before the
task lookup, so, as with PIDFD_GET_INFO, a reaped target outside of the
caller's pid namespace hierarchy gives -EREMOTE rather than -ESRCH, and
the check comes before the ptrace access check.
setns() also accepts such pidfds without this check, but it requires
CAP_SYS_ADMIN over the namespaces being joined, so it is left alone
here.
A reproducer is available on request.
kernel/pid.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/kernel/pid.c b/kernel/pid.c
index adf721606768..4f9a29eb29de 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -893,6 +893,13 @@ static int pidfd_getfd(struct pid *pid, int fd)
struct file *file;
int ret;
+ /*
+ * Require the target to be visible in the caller's pid namespace,
+ * like the pidfs ioctls that grant access to its resources.
+ */
+ if (!pid_vnr(pid))
+ return -EREMOTE;
+
task = get_pid_task(pid, PIDTYPE_PID);
if (!task)
return -ESRCH;
@@ -917,9 +924,10 @@ static int pidfd_getfd(struct pid *pid, int fd)
*
* This syscall gets a copy of a file descriptor from another process
* based on the pidfd, and file descriptor number. It requires that
- * the calling process has the ability to ptrace the process represented
- * by the pidfd. The process which is having its file descriptor copied
- * is otherwise unaffected.
+ * the process represented by the pidfd is visible in the caller's pid
+ * namespace and that the calling process has the ability to ptrace it.
+ * The process which is having its file descriptor copied is otherwise
+ * unaffected.
*
* Return: On success, a cloexec file descriptor is returned.
* On error, a negative errno number will be returned.
base-commit: 44cc27050381e92de64cc3d7836376eda4d92a5f
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pidfd: restrict pidfd_getfd() to the caller's pid namespace
2026-11-17 15:23 [PATCH] pidfd: restrict pidfd_getfd() to the caller's pid namespace Jiwoo Kim
@ 2026-11-17 16:20 ` Bradley Morgan
0 siblings, 0 replies; 2+ messages in thread
From: Bradley Morgan @ 2026-11-17 16:20 UTC (permalink / raw)
To: arpe1618
Cc: arnd, brauner, jannh, linux-api, linux-fsdevel, linux-kernel, me,
sargun
On 17 November 2026 15:23:32 GMT, Jiwoo Kim <arpe1618@gmail.com> wrote:
>pidfds can cross pid namespace boundaries: a task can obtain one for a
>process outside of its own pid namespace hierarchy through SO_PASSPIDFD
>or SO_PEERPIDFD, via SCM_RIGHTS, or through file descriptor
>inheritance.
>
>Commit ee8323fdc827 ("pidfd: restrict task access ioctls to the caller's
>pid namespace") made the pidfs namespace ioctls fail with -EREMOTE
>unless the target is visible in the caller's active pid namespace, as
>PIDFD_GET_INFO already does, following the rule that operations which
>grant access to additional resources of the target require this [1].
>
>pidfd_getfd() grants access to the target's open files, but it only
>performs the ptrace access check, which does not take the pid namespace
>relationship between the caller and the target into account. With the
>caller in a child pid namespace and in the same user namespace as the
>target, PIDFD_GET_INFO and PIDFD_GET_UTS_NAMESPACE fail with -EREMOTE
>for such a pidfd, while pidfd_getfd() on the same pidfd returns a
>duplicate of the target's file descriptor.
>
>Apply the same rule to pidfd_getfd() and fail with -EREMOTE unless the
>target is visible in the caller's active pid namespace. Callers in
>ancestor pid namespaces are unaffected.
>
>This was found with an AI coding assistant, which also drafted this
>patch and its changelog. The problem was reproduced in a QEMU guest,
>and the fix was tested there.
>
>Link: https://lore.kernel.org/all/20260925-gewischt-auftrag-tierzucht-c153cb3f9f74@brauner/ [1]
>Fixes: 8649c322f75c ("pid: Implement pidfd_getfd syscall")
>Cc: stable@vger.kernel.org
Reviewed-by: Bradley Morgan <bradley.morgan@linux.dev>
>Signed-off-by: Jiwoo Kim <arpe1618@gmail.com>
>---
>-EREMOTE is a new error for pidfd_getfd(). The check is done before the
>task lookup, so, as with PIDFD_GET_INFO, a reaped target outside of the
>caller's pid namespace hierarchy gives -EREMOTE rather than -ESRCH, and
>the check comes before the ptrace access check.
>
>setns() also accepts such pidfds without this check, but it requires
>CAP_SYS_ADMIN over the namespaces being joined, so it is left alone
>here.
>
>A reproducer is available on request.
>
> kernel/pid.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
>diff --git a/kernel/pid.c b/kernel/pid.c
>index adf721606768..4f9a29eb29de 100644
>--- a/kernel/pid.c
>+++ b/kernel/pid.c
>@@ -893,6 +893,13 @@ static int pidfd_getfd(struct pid *pid, int fd)
> struct file *file;
> int ret;
>
>+ /*
>+ * Require the target to be visible in the caller's pid namespace,
>+ * like the pidfs ioctls that grant access to its resources.
>+ */
>+ if (!pid_vnr(pid))
>+ return -EREMOTE;
>+
> task = get_pid_task(pid, PIDTYPE_PID);
> if (!task)
> return -ESRCH;
>@@ -917,9 +924,10 @@ static int pidfd_getfd(struct pid *pid, int fd)
> *
> * This syscall gets a copy of a file descriptor from another process
> * based on the pidfd, and file descriptor number. It requires that
>- * the calling process has the ability to ptrace the process represented
>- * by the pidfd. The process which is having its file descriptor copied
>- * is otherwise unaffected.
>+ * the process represented by the pidfd is visible in the caller's pid
>+ * namespace and that the calling process has the ability to ptrace it.
>+ * The process which is having its file descriptor copied is otherwise
>+ * unaffected.
> *
> * Return: On success, a cloexec file descriptor is returned.
> * On error, a negative errno number will be returned.
>
>base-commit: 44cc27050381e92de64cc3d7836376eda4d92a5f
>
--- Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 15:23 [PATCH] pidfd: restrict pidfd_getfd() to the caller's pid namespace Jiwoo Kim
2026-11-17 16:20 ` Bradley Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox