From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Cc: james.bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
santoshsy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-scsi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
gbroner-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
draviv-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
Noa Rubens <noag-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Raviv Shvili <rshvili-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Vinayak Holikatti
<vinholikatti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"James E.J. Bottomley" <jbottomley-wo1vFcy6AUs@public.gmane.org>,
"open list:ABI/API"
<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] scsi: ufs: add ioctl interface for query request
Date: Wed, 07 Oct 2015 14:37:35 +0200 [thread overview]
Message-ID: <7161690.NZs9VETTEZ@wuerfel> (raw)
In-Reply-To: <c154d3ff11646f056401afd4fa348d1b.squirrel-mMfbam+mt9083fI46fginR2eb7JE58TQ@public.gmane.org>
On Wednesday 07 October 2015 12:27:54 ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote:
>
> >> +
> >> +/*
> >> + * IOCTL opcode for ufs queries has the following opcode after
> >> + * SCSI_IOCTL_GET_PCI
> >> + */
> >> +#define UFS_IOCTL_QUERY 0x5388
> >
> > Use _IOWR() to define that number with the correct argument length
>
> i'd rather leave it as is, to be compatible with the SCSI_IOCTL
> opcodes that are defined in scsi_ioctl.h
Do you mean you require this code to work on SunOS? ;-)
If not, better use the normal conventions that Linux and BSD have for
new ioctls.
Note that the 0x53xx ioctl command numbers are also used by
include/uapi/linux/cdrom.h, this one would be right in the middle
of that.
Arnd
prev parent reply other threads:[~2015-10-07 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 7:54 [PATCH v2] scsi: ufs: add ioctl interface for query request Yaniv Gardi
2015-10-07 8:11 ` Arnd Bergmann
2015-10-07 12:27 ` ygardi-sgV2jX0FEOL9JmXXK+q4OQ
[not found] ` <c154d3ff11646f056401afd4fa348d1b.squirrel-mMfbam+mt9083fI46fginR2eb7JE58TQ@public.gmane.org>
2015-10-07 12:37 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7161690.NZs9VETTEZ@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=draviv-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gbroner-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=james.bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=jbottomley-wo1vFcy6AUs@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=noag-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=rshvili-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=santoshsy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=vinholikatti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox