From: Eric B Munson <emunson@mgebm.net>
To: avi@redhat.com
Cc: mingo@redhat.com, x86@kernel.org, hpa@zytor.com,
mtosatti@redhat.com, arnd@arndb.de, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, linux-arch@vger.kernel.org,
ryanh@linux.vnet.ibm.com, aliguori@us.ibm.com,
Eric B Munson <emunson@mgebm.net>
Subject: [PATCH 5/6] Add check for suspended vm in softlockup detector
Date: Tue, 25 Oct 2011 15:26:18 -0400 [thread overview]
Message-ID: <1319570779-8907-6-git-send-email-emunson@mgebm.net> (raw)
In-Reply-To: <1319570779-8907-1-git-send-email-emunson@mgebm.net>
A suspended VM can cause spurious soft lockup warnings. To avoid these, the
watchdog now checks if the kernel knows it was stopped by the host and skips
the warning if so.
Signed-off-by: Eric B Munson <emunson@mgebm.net>
---
kernel/watchdog.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..8107ba7 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -25,6 +25,7 @@
#include <linux/sysctl.h>
#include <asm/irq_regs.h>
+#include <asm/pvclock.h>
#include <linux/perf_event.h>
int watchdog_enabled = 1;
@@ -292,6 +293,14 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
*/
duration = is_softlockup(touch_ts);
if (unlikely(duration)) {
+ /*
+ * If a virtual machine is stopped by the host it can look to
+ * the watchdog like a soft lockup, check to see if the host
+ * stopped the vm before we issue the warning
+ */
+ if (kvm_check_and_clear_host_stopped(smp_processor_id()))
+ return HRTIMER_RESTART;
+
/* only warn once */
if (__this_cpu_read(soft_watchdog_warn) == true)
return HRTIMER_RESTART;
--
1.7.5.4
next prev parent reply other threads:[~2011-10-25 19:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 19:26 [PATCH 0/6] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2011-10-25 19:26 ` [PATCH 1/6] Add flag to indicate that a vm was stopped by the host Eric B Munson
2011-10-25 19:26 ` Eric B Munson
2011-10-25 19:26 ` [PATCH 2/6] Add functions to check if the host has stopped the vm Eric B Munson
2011-10-25 19:26 ` Eric B Munson
2011-10-25 19:26 ` [PATCH 3/6] Add ioctl for KVM_GUEST_STOPPED Eric B Munson
2011-10-25 19:26 ` Eric B Munson
2011-10-28 1:52 ` Marcelo Tosatti
2011-10-28 13:11 ` Eric B Munson
2011-10-25 19:26 ` [PATCH 4/6] Add generic stubs for kvm stop check functions Eric B Munson
2011-10-25 19:26 ` Eric B Munson
2011-10-25 19:26 ` Eric B Munson [this message]
2011-10-25 19:26 ` [PATCH 5/6] Add check for suspended vm in softlockup detector Eric B Munson
2011-10-25 19:26 ` [PATCH 6/6] Add age out of guest paused flag Eric B Munson
2011-10-28 2:14 ` Marcelo Tosatti
2011-10-28 2:14 ` Marcelo Tosatti
2011-10-28 13:21 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319570779-8907-6-git-send-email-emunson@mgebm.net \
--to=emunson@mgebm.net \
--cc=aliguori@us.ibm.com \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=ryanh@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox