From: David Howells <dhowells@redhat.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: dhowells@redhat.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Hirokazu Takata <takata@linux-m32r.org>,
Greg Ungerer <gerg@uclinux.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [RFC PATCH] Remove flush_icache_user_range()
Date: Fri, 11 Apr 2014 09:53:08 +0100 [thread overview]
Message-ID: <19350.1397206388@warthog.procyon.org.uk> (raw)
In-Reply-To: <20140409100150.GO16119@n2100.arm.linux.org.uk>
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> --- a/arch/frv/include/asm/cacheflush.h
> +++ b/arch/frv/include/asm/cacheflush.h
> @@ -95,7 +95,9 @@ static inline void flush_icache_page(struct vm_area_struct *vma, struct page *pa
> */
> #define copy_to_user_page(vma, page, vaddr, dst, src, len) \
> do { \
> + unsigned long _vaddr = vaddr; \
> memcpy((dst), (src), (len)); \
> + frv_cache_wback_inv(_vaddr, _vaddr + (len)); \
> flush_icache_user_range((vma), (page), (vaddr), (len)); \
> } while(0)
FRV's flush_icache_user_range() does frv_cache_wback_inv().
If we can guarantee that vaddr is always mapped to the page, I should be able
to get rid of the kmap_atomic bits in flush_icache_user_range().
David
prev parent reply other threads:[~2014-04-11 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 10:01 [RFC PATCH] Remove flush_icache_user_range() Russell King - ARM Linux
2014-04-09 10:01 ` Russell King - ARM Linux
2014-04-09 16:09 ` David Miller
2014-04-09 16:15 ` Russell King - ARM Linux
2014-04-09 16:15 ` Russell King - ARM Linux
2014-04-09 16:33 ` David Miller
2014-04-09 16:33 ` David Miller
2014-04-09 16:36 ` Russell King - ARM Linux
2014-04-11 8:53 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19350.1397206388@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=ink@jurassic.park.msu.ru \
--cc=jesper.nilsson@axis.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mattst88@gmail.com \
--cc=monstr@monstr.eu \
--cc=rth@twiddle.net \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tony.luck@intel.com \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox