Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Benjamin Herrenschmidt
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux-Arch <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
Date: Fri, 18 Apr 2008 00:07:17 -0700	[thread overview]
Message-ID: <20080418000717.5a9c9758.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080418065728.31AF4DE255-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>

On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> wrote:

> Use the __weak macro instead of the longer __attribute__ ((weak)) form
> 
> Signed-off-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
> --
> 
>  init/main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-work.orig/init/main.c	2008-04-18 16:44:32.000000000 +1000
> +++ linux-work/init/main.c	2008-04-18 16:44:37.000000000 +1000
> @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
>  	cpu_set(cpu, cpu_possible_map);
>  }
>  
> -void __init __attribute__((weak)) smp_setup_processor_id(void)
> +void __init __weak smp_setup_processor_id(void)
>  {
>  }

ack on all three. Please fold #3 into #1 and add both to git-powerpc.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
Date: Fri, 18 Apr 2008 00:07:17 -0700	[thread overview]
Message-ID: <20080418000717.5a9c9758.akpm@linux-foundation.org> (raw)
Message-ID: <20080418070717.SLMJ7qR76T7uDZi4Sict1xHuSPnrojWGxnZBei8GdyY@z> (raw)
In-Reply-To: <20080418065728.31AF4DE255@ozlabs.org>

On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> Use the __weak macro instead of the longer __attribute__ ((weak)) form
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> --
> 
>  init/main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-work.orig/init/main.c	2008-04-18 16:44:32.000000000 +1000
> +++ linux-work/init/main.c	2008-04-18 16:44:37.000000000 +1000
> @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
>  	cpu_set(cpu, cpu_possible_map);
>  }
>  
> -void __init __attribute__((weak)) smp_setup_processor_id(void)
> +void __init __weak smp_setup_processor_id(void)
>  {
>  }

ack on all three. Please fold #3 into #1 and add both to git-powerpc.

  parent reply	other threads:[~2008-04-18  7:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18  6:56 [PATCH 3/3] Use __weak macro for smp_setup_processor_id Benjamin Herrenschmidt
2008-04-18  6:56 ` Benjamin Herrenschmidt
     [not found] ` <20080418065728.31AF4DE255-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
2008-04-18  7:07   ` Andrew Morton [this message]
2008-04-18  7:07     ` Andrew Morton
2008-04-18  8:19     ` Benjamin Herrenschmidt
2008-04-18  8:19       ` Benjamin Herrenschmidt
2008-04-18  8:38       ` Andrew Morton
2008-04-18  8:38         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080418000717.5a9c9758.akpm@linux-foundation.org \
    --to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
    --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox