Re: [next:akpm 205/376] mm/huge_memory.c:716:2: error: implicit declaration of function 'pfn_pmd'

Re: [next:akpm 205/376] mm/huge_memory.c:716:2: error: implicit declaration of function 'pfn_pmd'

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 2629 bytes --]

On Thu, Nov 15, 2012 at 02:27:28PM -0800, Andrew Morton wrote:
> On Thu, 15 Nov 2012 18:23:01 +0800
> kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> > head:   d3faae60d84f586ff8937b77c8476bca1b5f8ec6
> > commit: 165a1669c89b5fa2f6c54bf609b408a592f024b3 [205/376] thp: copy_huge_pmd(): copy huge zero page
> > config: make ARCH=mips allmodconfig
> > 
> > All error/warnings:
> > 
> > mm/huge_memory.c: In function 'set_huge_zero_page':
> > mm/huge_memory.c:716:2: error: implicit declaration of function 'pfn_pmd' [-Werror=implicit-function-declaration]
> > mm/huge_memory.c:716:8: error: incompatible types when assigning to type 'pmd_t' from type 'int'
> > mm/huge_memory.c: In function 'do_huge_pmd_numa_page':
> > mm/huge_memory.c:825:2: error: incompatible type for argument 3 of 'update_mmu_cache_pmd'
> > In file included from include/linux/mm.h:44:0,
> >                  from mm/huge_memory.c:8:
> > arch/mips/include/asm/pgtable.h:385:20: note: expected 'struct pmd_t *' but argument is of type 'pmd_t'
> > mm/huge_memory.c:895:2: error: incompatible type for argument 3 of 'update_mmu_cache_pmd'
> > In file included from include/linux/mm.h:44:0,
> >                  from mm/huge_memory.c:8:
> > arch/mips/include/asm/pgtable.h:385:20: note: expected 'struct pmd_t *' but argument is of type 'pmd_t'
> > cc1: some warnings being treated as errors
> > 
> > vim +716 +/pfn_pmd mm/huge_memory.c
> > 
> > 0bbbc0b3 Andrea Arcangeli   2011-01-13  710  #endif
> > 71e3aac0 Andrea Arcangeli   2011-01-13  711  
> > 165a1669 Kirill A. Shutemov 2012-11-15  712  static void set_huge_zero_page(pgtable_t pgtable, struct mm_struct *mm,
> > 165a1669 Kirill A. Shutemov 2012-11-15  713  		struct vm_area_struct *vma, unsigned long haddr, pmd_t *pmd)
> > 165a1669 Kirill A. Shutemov 2012-11-15  714  {
> > 165a1669 Kirill A. Shutemov 2012-11-15  715  	pmd_t entry;
> > 165a1669 Kirill A. Shutemov 2012-11-15 @716  	entry = pfn_pmd(huge_zero_pfn, vma->vm_page_prot);
> > 165a1669 Kirill A. Shutemov 2012-11-15  717  	entry = pmd_wrprotect(entry);
> > 165a1669 Kirill A. Shutemov 2012-11-15  718  	entry = pmd_mkhuge(entry);
> > 165a1669 Kirill A. Shutemov 2012-11-15  719  	set_pmd_at(mm, haddr, pmd, entry);
> 
> hm.  mips doesn't implement pfn_pmd() - quite a few architectures
> don't.

I think it would be easier to fix it on arch side. Ralf?

> Not sure about the update_mmu_cache_pmd() thing.

I'll send a patchset to fix it. (it's not related to huge zero page)

-- 
 Kirill A. Shutemov

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [next:akpm 205/376] mm/huge_memory.c:716:2: error: implicit declaration of function 'pfn_pmd'

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 2629 bytes --]

On Thu, Nov 15, 2012 at 02:27:28PM -0800, Andrew Morton wrote:
> On Thu, 15 Nov 2012 18:23:01 +0800
> kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> > head:   d3faae60d84f586ff8937b77c8476bca1b5f8ec6
> > commit: 165a1669c89b5fa2f6c54bf609b408a592f024b3 [205/376] thp: copy_huge_pmd(): copy huge zero page
> > config: make ARCH=mips allmodconfig
> > 
> > All error/warnings:
> > 
> > mm/huge_memory.c: In function 'set_huge_zero_page':
> > mm/huge_memory.c:716:2: error: implicit declaration of function 'pfn_pmd' [-Werror=implicit-function-declaration]
> > mm/huge_memory.c:716:8: error: incompatible types when assigning to type 'pmd_t' from type 'int'
> > mm/huge_memory.c: In function 'do_huge_pmd_numa_page':
> > mm/huge_memory.c:825:2: error: incompatible type for argument 3 of 'update_mmu_cache_pmd'
> > In file included from include/linux/mm.h:44:0,
> >                  from mm/huge_memory.c:8:
> > arch/mips/include/asm/pgtable.h:385:20: note: expected 'struct pmd_t *' but argument is of type 'pmd_t'
> > mm/huge_memory.c:895:2: error: incompatible type for argument 3 of 'update_mmu_cache_pmd'
> > In file included from include/linux/mm.h:44:0,
> >                  from mm/huge_memory.c:8:
> > arch/mips/include/asm/pgtable.h:385:20: note: expected 'struct pmd_t *' but argument is of type 'pmd_t'
> > cc1: some warnings being treated as errors
> > 
> > vim +716 +/pfn_pmd mm/huge_memory.c
> > 
> > 0bbbc0b3 Andrea Arcangeli   2011-01-13  710  #endif
> > 71e3aac0 Andrea Arcangeli   2011-01-13  711  
> > 165a1669 Kirill A. Shutemov 2012-11-15  712  static void set_huge_zero_page(pgtable_t pgtable, struct mm_struct *mm,
> > 165a1669 Kirill A. Shutemov 2012-11-15  713  		struct vm_area_struct *vma, unsigned long haddr, pmd_t *pmd)
> > 165a1669 Kirill A. Shutemov 2012-11-15  714  {
> > 165a1669 Kirill A. Shutemov 2012-11-15  715  	pmd_t entry;
> > 165a1669 Kirill A. Shutemov 2012-11-15 @716  	entry = pfn_pmd(huge_zero_pfn, vma->vm_page_prot);
> > 165a1669 Kirill A. Shutemov 2012-11-15  717  	entry = pmd_wrprotect(entry);
> > 165a1669 Kirill A. Shutemov 2012-11-15  718  	entry = pmd_mkhuge(entry);
> > 165a1669 Kirill A. Shutemov 2012-11-15  719  	set_pmd_at(mm, haddr, pmd, entry);
> 
> hm.  mips doesn't implement pfn_pmd() - quite a few architectures
> don't.

I think it would be easier to fix it on arch side. Ralf?

> Not sure about the update_mmu_cache_pmd() thing.

I'll send a patchset to fix it. (it's not related to huge zero page)

-- 
 Kirill A. Shutemov

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]