Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@caviumnetworks.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "open list:GENERIC INCLUDE/ASM HEADER FILES"
	<linux-arch@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Dave Gerlach <d-gerlach@ti.com>, Tony Lindgren <tony@atomide.com>,
	Keerthy J <j-keerthy@ti.com>, Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	open list <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Catalin Marinas <catalin.marinas@arm.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-omap@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation
Date: Mon, 19 Jun 2017 18:18:18 +0300	[thread overview]
Message-ID: <20170619151818.pvjygbdvm6arvarq@yury-thinkpad> (raw)
In-Reply-To: <20170618235108.peaxdi367jpkt542@yury-thinkpad>

On Mon, Jun 19, 2017 at 02:51:08AM +0300, Yury Norov wrote:
> Hi Florian,
> 
> Some questions and thoughts inline.
> 
> Yury
> 
> On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote:
> > Define a generic fncpy() implementation largely based on the ARM version
> > that requires an 8 bytes alignment for the destination address where to
> > copy this function as well as the function's own address.
> > 
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> >  include/asm-generic/fncpy.h | 93 +++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> >  create mode 100644 include/asm-generic/fncpy.h

One else thing I forgot to ask - now you have the generic
implementation for fncpy(), so do you really need to save arm
version of it?

Yury

WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <ynorov@caviumnetworks.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "open list:GENERIC INCLUDE/ASM HEADER FILES"
	<linux-arch@vger.kernel.org>, Keerthy J <j-keerthy@ti.com>,
	Arnd Bergmann <arnd@arndb.de>, Dave Gerlach <d-gerlach@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	open list <linux-kernel@vger.kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-omap@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation
Date: Mon, 19 Jun 2017 18:18:18 +0300	[thread overview]
Message-ID: <20170619151818.pvjygbdvm6arvarq@yury-thinkpad> (raw)
Message-ID: <20170619151818.0RuwWk2SUeNY3UPIq_bb-pSkLM76hTtENpUW1cnVwbc@z> (raw)
In-Reply-To: <20170618235108.peaxdi367jpkt542@yury-thinkpad>

On Mon, Jun 19, 2017 at 02:51:08AM +0300, Yury Norov wrote:
> Hi Florian,
> 
> Some questions and thoughts inline.
> 
> Yury
> 
> On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote:
> > Define a generic fncpy() implementation largely based on the ARM version
> > that requires an 8 bytes alignment for the destination address where to
> > copy this function as well as the function's own address.
> > 
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> >  include/asm-generic/fncpy.h | 93 +++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> >  create mode 100644 include/asm-generic/fncpy.h

One else thing I forgot to ask - now you have the generic
implementation for fncpy(), so do you really need to save arm
version of it?

Yury

  parent reply	other threads:[~2017-06-19 15:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17  0:07 [PATCH v3 0/4] Generalize fncpy availability Florian Fainelli
2017-06-17  0:07 ` [PATCH v3 1/4] ARM: fncpy: Rename include guards Florian Fainelli
2017-06-17  0:07 ` [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation Florian Fainelli
2017-06-17  0:07   ` Florian Fainelli
2017-06-18 23:51   ` Yury Norov
2017-06-18 23:51     ` Yury Norov
2017-06-19  1:11     ` Yury Norov
2017-06-19 15:18     ` Yury Norov [this message]
2017-06-19 15:18       ` Yury Norov
2017-06-19 17:27       ` Florian Fainelli
2017-06-19 17:43       ` Russell King - ARM Linux
2017-06-20 14:27         ` Yury Norov
2017-06-20 14:27           ` Yury Norov
2017-06-19 20:58     ` Florian Fainelli
2017-06-20 14:24       ` Yury Norov
2017-06-17  0:07 ` [PATCH v3 3/4] arm64: Provide a fncpy implementation Florian Fainelli
2017-06-17  0:07   ` Florian Fainelli
2017-06-17  0:07 ` [PATCH v3 4/4] misc: sram: Allow ARM64 to select SRAM_EXEC Florian Fainelli
2017-06-17  0:07   ` Florian Fainelli
2017-06-28 14:55   ` Mark Rutland
2017-06-28 14:55     ` Mark Rutland
2017-06-19 12:24 ` [PATCH v3 0/4] Generalize fncpy availability Mark Rutland
2017-06-19 13:53   ` Tony Lindgren
2017-06-19 13:53     ` Tony Lindgren
2017-06-19 17:32   ` Florian Fainelli
2017-06-19 17:32     ` Florian Fainelli
2017-06-20  9:10     ` Lorenzo Pieralisi
2017-06-20  9:10       ` Lorenzo Pieralisi
2017-06-20 16:20       ` Florian Fainelli
2017-06-20 16:46         ` Lorenzo Pieralisi
2017-06-20 16:54         ` Sudeep Holla
2017-06-20 16:54           ` Sudeep Holla
2017-06-20 17:03           ` Florian Fainelli
2017-06-20 17:03             ` Florian Fainelli
2017-06-19 13:34 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619151818.pvjygbdvm6arvarq@yury-thinkpad \
    --to=ynorov@caviumnetworks.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=d-gerlach@ti.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=shawnguo@kernel.org \
    --cc=tony@atomide.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox