* [PATCH] xtensa: shut up gcc-8 warnings
@ 2018-01-02 11:00 Arnd Bergmann
2018-01-02 11:29 ` Max Filippov
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-01-02 11:00 UTC (permalink / raw)
To: Andrew Morton, Chris Zankel, Max Filippov
Cc: linux-arch, Arnd Bergmann, linux-kernel
Many uses of strncpy() on xtensa causes a warning like
arch/xtensa/include/asm/string.h:56:42: warning: array subscript is above array bounds [-Warray-bounds]
: "0" (__dest), "1" (__src), "r" (__src+__n)
This avoids the warning by turning the pointer arithmetic into an
integer operation that does not get checked the same way.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/xtensa/include/asm/string.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/xtensa/include/asm/string.h b/arch/xtensa/include/asm/string.h
index 586bad9fe187..89b51a0c752f 100644
--- a/arch/xtensa/include/asm/string.h
+++ b/arch/xtensa/include/asm/string.h
@@ -53,7 +53,7 @@ static inline char *strncpy(char *__dest, const char *__src, size_t __n)
"bne %1, %5, 1b\n"
"2:"
: "=r" (__dest), "=r" (__src), "=&r" (__dummy)
- : "0" (__dest), "1" (__src), "r" (__src+__n)
+ : "0" (__dest), "1" (__src), "r" ((uintptr_t)__src+__n)
: "memory");
return __xdest;
@@ -101,7 +101,7 @@ static inline int strncmp(const char *__cs, const char *__ct, size_t __n)
"2:\n\t"
"sub %2, %2, %3"
: "=r" (__cs), "=r" (__ct), "=&r" (__res), "=&r" (__dummy)
- : "0" (__cs), "1" (__ct), "r" (__cs+__n));
+ : "0" (__cs), "1" (__ct), "r" ((uintptr_t)__cs+__n));
return __res;
}
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xtensa: shut up gcc-8 warnings
2018-01-02 11:00 [PATCH] xtensa: shut up gcc-8 warnings Arnd Bergmann
@ 2018-01-02 11:29 ` Max Filippov
0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2018-01-02 11:29 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Andrew Morton, Chris Zankel, Linux-Arch, LKML
On Tue, Jan 2, 2018 at 3:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> Many uses of strncpy() on xtensa causes a warning like
>
> arch/xtensa/include/asm/string.h:56:42: warning: array subscript is above array bounds [-Warray-bounds]
> : "0" (__dest), "1" (__src), "r" (__src+__n)
>
> This avoids the warning by turning the pointer arithmetic into an
> integer operation that does not get checked the same way.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/xtensa/include/asm/string.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my xtensa tree.
-- Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-02 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 11:00 [PATCH] xtensa: shut up gcc-8 warnings Arnd Bergmann
2018-01-02 11:29 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox