From: Mark Rutland <mark.rutland@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Mark Salyzyn <salyzyn@android.com>,
Paul Burton <paul.burton@mips.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Collingbourne <pcc@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 11/23] arm64: compat: Generate asm offsets for signals
Date: Fri, 22 Feb 2019 14:22:05 +0000 [thread overview]
Message-ID: <20190222142204.GK42419@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190222122430.21180-12-vincenzo.frascino@arm.com>
On Fri, Feb 22, 2019 at 12:24:18PM +0000, Vincenzo Frascino wrote:
> diff --git a/arch/arm64/include/asm/signal32.h b/arch/arm64/include/asm/signal32.h
> index 1f05268f4c6d..a6fd7be1b22a 100644
> --- a/arch/arm64/include/asm/signal32.h
> +++ b/arch/arm64/include/asm/signal32.h
> @@ -52,7 +52,7 @@ struct compat_ucontext {
> compat_stack_t uc_stack;
> struct compat_sigcontext uc_mcontext;
> compat_sigset_t uc_sigmask;
> - int __unused[32 - (sizeof(compat_sigset_t) / sizeof(int))];
> + int __unused[32 - (sizeof(compat_sigset_t) / sizeof(int))];
Spurious whitespace change?
> +/* Macros for asm-offsets.c */
> +#define OFFSET_OF_COMPAT_SIGFRAME_REGS ( \
> + offsetof(struct compat_sigframe, uc) + \
> + offsetof(struct compat_ucontext, uc_mcontext) + \
> + offsetof(struct compat_sigcontext, arm_r0))
> +
> +#define OFFSET_OF_COMPAT_RT_SIGFRAME_REGS ( \
> + offsetof(struct compat_rt_sigframe, sig) + \
> + offsetof(struct compat_sigframe, uc) + \
> + offsetof(struct compat_ucontext, uc_mcontext) + \
> + offsetof(struct compat_sigcontext, arm_r0))
> +
> int compat_setup_frame(int usig, struct ksignal *ksig, sigset_t *set,
> struct pt_regs *regs);
> int compat_setup_rt_frame(int usig, struct ksignal *ksig, sigset_t *set,
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index 4adb52190a90..afd28ccda174 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -30,6 +30,7 @@
> #include <asm/fixmap.h>
> #include <asm/thread_info.h>
> #include <asm/memory.h>
> +#include <asm/signal32.h>
> #include <asm/smp_plat.h>
> #include <asm/suspend.h>
> #include <linux/kbuild.h>
> @@ -84,6 +85,11 @@ int main(void)
> DEFINE(S_STACKFRAME, offsetof(struct pt_regs, stackframe));
> DEFINE(S_FRAME_SIZE, sizeof(struct pt_regs));
> BLANK();
> +#ifdef CONFIG_COMPAT
> + DEFINE(COMPAT_SIGFRAME_REGS_OFFSET, OFFSET_OF_COMPAT_SIGFRAME_REGS);
> + DEFINE(COMPAT_RT_SIGFRAME_REGS_OFFSET, OFFSET_OF_COMPAT_RT_SIGFRAME_REGS);
Can't we do:
DEFINE(COMPAT_SIGFRAME_REGS_OFFSET, offsetof(struct compat_sigframe, uc.us_mcontext.arm_r0)
DEFINE(COMPAT_RT_SIGFRAME_REGS_OFFSET, offsetof(struct compat_rt_sigframe, sig.uc.us_mcontext.arm_r0)
... and avoid the OFFSET_OF_* macros entirely?
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Salyzyn <salyzyn@android.com>,
Peter Collingbourne <pcc@google.com>,
Shuah Khan <shuah@kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v5 11/23] arm64: compat: Generate asm offsets for signals
Date: Fri, 22 Feb 2019 14:22:05 +0000 [thread overview]
Message-ID: <20190222142204.GK42419@lakrids.cambridge.arm.com> (raw)
Message-ID: <20190222142205.yZXRsXixH1rt5I3OH1WfmM_injIfrkAhmK6-PaekdZE@z> (raw)
In-Reply-To: <20190222122430.21180-12-vincenzo.frascino@arm.com>
On Fri, Feb 22, 2019 at 12:24:18PM +0000, Vincenzo Frascino wrote:
> diff --git a/arch/arm64/include/asm/signal32.h b/arch/arm64/include/asm/signal32.h
> index 1f05268f4c6d..a6fd7be1b22a 100644
> --- a/arch/arm64/include/asm/signal32.h
> +++ b/arch/arm64/include/asm/signal32.h
> @@ -52,7 +52,7 @@ struct compat_ucontext {
> compat_stack_t uc_stack;
> struct compat_sigcontext uc_mcontext;
> compat_sigset_t uc_sigmask;
> - int __unused[32 - (sizeof(compat_sigset_t) / sizeof(int))];
> + int __unused[32 - (sizeof(compat_sigset_t) / sizeof(int))];
Spurious whitespace change?
> +/* Macros for asm-offsets.c */
> +#define OFFSET_OF_COMPAT_SIGFRAME_REGS ( \
> + offsetof(struct compat_sigframe, uc) + \
> + offsetof(struct compat_ucontext, uc_mcontext) + \
> + offsetof(struct compat_sigcontext, arm_r0))
> +
> +#define OFFSET_OF_COMPAT_RT_SIGFRAME_REGS ( \
> + offsetof(struct compat_rt_sigframe, sig) + \
> + offsetof(struct compat_sigframe, uc) + \
> + offsetof(struct compat_ucontext, uc_mcontext) + \
> + offsetof(struct compat_sigcontext, arm_r0))
> +
> int compat_setup_frame(int usig, struct ksignal *ksig, sigset_t *set,
> struct pt_regs *regs);
> int compat_setup_rt_frame(int usig, struct ksignal *ksig, sigset_t *set,
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index 4adb52190a90..afd28ccda174 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -30,6 +30,7 @@
> #include <asm/fixmap.h>
> #include <asm/thread_info.h>
> #include <asm/memory.h>
> +#include <asm/signal32.h>
> #include <asm/smp_plat.h>
> #include <asm/suspend.h>
> #include <linux/kbuild.h>
> @@ -84,6 +85,11 @@ int main(void)
> DEFINE(S_STACKFRAME, offsetof(struct pt_regs, stackframe));
> DEFINE(S_FRAME_SIZE, sizeof(struct pt_regs));
> BLANK();
> +#ifdef CONFIG_COMPAT
> + DEFINE(COMPAT_SIGFRAME_REGS_OFFSET, OFFSET_OF_COMPAT_SIGFRAME_REGS);
> + DEFINE(COMPAT_RT_SIGFRAME_REGS_OFFSET, OFFSET_OF_COMPAT_RT_SIGFRAME_REGS);
Can't we do:
DEFINE(COMPAT_SIGFRAME_REGS_OFFSET, offsetof(struct compat_sigframe, uc.us_mcontext.arm_r0)
DEFINE(COMPAT_RT_SIGFRAME_REGS_OFFSET, offsetof(struct compat_rt_sigframe, sig.uc.us_mcontext.arm_r0)
... and avoid the OFFSET_OF_* macros entirely?
Thanks,
Mark.
next prev parent reply other threads:[~2019-02-22 14:22 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 12:24 [PATCH v5 00/23] Unify vDSOs across more architectures Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 01/23] kernel: Standardize vdso_datapage Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:58 ` Mark Rutland
2019-02-22 12:58 ` Mark Rutland
2019-02-23 16:51 ` Thomas Gleixner
2019-02-23 16:51 ` Thomas Gleixner
2019-02-27 14:23 ` Vincenzo Frascino
2019-02-27 14:23 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 02/23] kernel: Define gettimeofday vdso common code Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 13:34 ` Mark Rutland
2019-02-22 13:34 ` Mark Rutland
2019-02-22 13:49 ` Arnd Bergmann
2019-02-22 13:49 ` Arnd Bergmann
2019-02-22 14:36 ` Arnd Bergmann
2019-02-22 14:36 ` Arnd Bergmann
2019-02-27 14:52 ` Vincenzo Frascino
2019-02-27 14:52 ` Vincenzo Frascino
2019-02-28 9:29 ` Arnd Bergmann
2019-02-28 9:29 ` Arnd Bergmann
2019-02-28 11:58 ` [PATCH 1/2] vdso: use fixed-size time types Arnd Bergmann
2019-02-28 11:58 ` Arnd Bergmann
2019-02-28 11:58 ` [PATCH 2/2] vdso: add clock_gettime64 Arnd Bergmann
2019-02-28 11:58 ` Arnd Bergmann
2019-02-28 13:42 ` [PATCH 1/2] vdso: use fixed-size time types Thomas Gleixner
2019-02-28 13:42 ` Thomas Gleixner
2019-02-28 13:45 ` Vincenzo Frascino
2019-02-28 13:45 ` Vincenzo Frascino
2019-02-23 10:34 ` [PATCH v5 02/23] kernel: Define gettimeofday vdso common code Thomas Gleixner
2019-02-23 10:34 ` Thomas Gleixner
2019-02-25 14:09 ` Vincenzo Frascino
2019-02-25 14:09 ` Vincenzo Frascino
2019-02-23 17:31 ` Thomas Gleixner
2019-02-23 17:31 ` Thomas Gleixner
2019-02-27 13:47 ` Vincenzo Frascino
2019-02-27 13:47 ` Vincenzo Frascino
2019-02-27 15:49 ` Thomas Gleixner
2019-02-27 15:49 ` Thomas Gleixner
2019-02-27 16:06 ` Vincenzo Frascino
2019-02-27 16:06 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 03/23] arm64: Build vDSO with -ffixed-x18 Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 04/23] arm64: Substitute gettimeofday with C implementation Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 13:42 ` Mark Rutland
2019-02-22 13:42 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 05/23] arm64: compat: Alloc separate pages for vectors and sigpage Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 06/23] arm64: compat: Split kuser32 Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 07/23] arm64: compat: Refactor aarch32_alloc_vdso_pages() Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 08/23] arm64: compat: Add KUSER_HELPERS config option Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:04 ` Mark Rutland
2019-02-22 14:04 ` Mark Rutland
2019-02-22 14:09 ` Russell King - ARM Linux admin
2019-02-22 14:09 ` Russell King - ARM Linux admin
2019-02-26 12:10 ` Vincenzo Frascino
2019-02-26 12:10 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 09/23] arm64: compat: Add missing syscall numbers Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 10/23] arm64: compat: Expose signal related structures Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 11/23] arm64: compat: Generate asm offsets for signals Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:22 ` Mark Rutland [this message]
2019-02-22 14:22 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 12/23] lib: vdso: Add compat support Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 13/23] arm64: compat: Add vDSO Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:32 ` Mark Rutland
2019-02-22 14:32 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 14/23] arm64: Refactor vDSO code Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:37 ` Mark Rutland
2019-02-22 14:37 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 15/23] arm64: compat: vDSO setup for compat layer Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 16/23] arm64: elf: vDSO code page discovery Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 17/23] arm64: compat: Get sigreturn trampolines from vDSO Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 18/23] arm64: Add vDSO compat support Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 19/23] arm64: Enable compat vDSO support Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:39 ` Mark Rutland
2019-02-22 14:39 ` Mark Rutland
2019-02-22 14:41 ` Mark Rutland
2019-02-22 14:41 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 20/23] arm: Add support for generic vDSO Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 21/23] mips: " Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 22/23] x86: " Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-23 10:45 ` Thomas Gleixner
2019-02-23 10:45 ` Thomas Gleixner
2019-02-27 16:18 ` Vincenzo Frascino
2019-02-27 16:18 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 23/23] kselftest: Extend vDSO selftest Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-23 17:39 ` [PATCH v5 00/23] Unify vDSOs across more architectures Thomas Gleixner
2019-02-23 17:39 ` Thomas Gleixner
2019-02-28 11:40 ` Arnd Bergmann
2019-02-28 11:40 ` Arnd Bergmann
2019-02-28 12:09 ` Vincenzo Frascino
2019-02-28 12:09 ` Vincenzo Frascino
2019-02-28 12:38 ` Arnd Bergmann
2019-02-28 12:38 ` Arnd Bergmann
2019-02-28 12:42 ` Vincenzo Frascino
2019-02-28 12:42 ` Vincenzo Frascino
2019-02-28 13:54 ` Arnd Bergmann
2019-02-28 13:54 ` Arnd Bergmann
2019-02-28 15:51 ` Vincenzo Frascino
2019-02-28 15:51 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222142204.GK42419@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=0x7f454c46@gmail.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=paul.burton@mips.com \
--cc=pcc@google.com \
--cc=ralf@linux-mips.org \
--cc=salyzyn@android.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox