Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Will Deacon <will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Dave Martin <Dave.Martin-5wv7dgnIgG8@public.gmane.org>
Cc: Michael Kerrisk
	<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Amit Daniel Kachhap <amit.kachhap-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH v2 5/6] prctl.2: Add PR_PAC_RESET_KEYS (arm64)
Date: Tue, 9 Jun 2020 11:02:03 +0100	[thread overview]
Message-ID: <20200609100202.GB25362@willie-the-truck> (raw)
In-Reply-To: <1590614258-24728-6-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>

On Wed, May 27, 2020 at 10:17:37PM +0100, Dave Martin wrote:
> Add documentation for the PR_PAC_RESET_KEYS ioctl added in Linux
> 5.0 for arm64.

[...]

> +If the arguments are invalid,
> +and in particular if
> +.I arg2
> +contains set bits that are unrecognized
> +or that correspond to a key not available on this platform,
> +the call fails with error
> +.BR EINVAL .
> +.IP
> +.B Warning:
> +Because the compiler or run-time environment
> +may be using some or all of the keys,
> +a successful
> +.IP
> +For more information, see the kernel source file
> +.I Documentation/arm64/pointer\-authentication.rst
> +.\"commit b693d0b372afb39432e1c49ad7b3454855bc6bed
> +(or
> +.I Documentation/arm64/pointer\-authentication.txt
> +before Linux 5.3).
> +.B PR_PAC_RESET_KEYS
> +may crash the calling process.

I might be misreading this, but this looks like the kernel reference appears
mid-sentence. Regardless, I think we should drop the kernel doc reference,
as I mentioned on the SVE patches.

With that:

Acked-by: Will Deacon <will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
	linux-man@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Amit Daniel Kachhap <amit.kachhap@arm.com>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 5/6] prctl.2: Add PR_PAC_RESET_KEYS (arm64)
Date: Tue, 9 Jun 2020 11:02:03 +0100	[thread overview]
Message-ID: <20200609100202.GB25362@willie-the-truck> (raw)
Message-ID: <20200609100203.IfHKuz-jM5YnK4D1qFJUaZoIp7ffdRG8W1lK4JeOyFU@z> (raw)
In-Reply-To: <1590614258-24728-6-git-send-email-Dave.Martin@arm.com>

On Wed, May 27, 2020 at 10:17:37PM +0100, Dave Martin wrote:
> Add documentation for the PR_PAC_RESET_KEYS ioctl added in Linux
> 5.0 for arm64.

[...]

> +If the arguments are invalid,
> +and in particular if
> +.I arg2
> +contains set bits that are unrecognized
> +or that correspond to a key not available on this platform,
> +the call fails with error
> +.BR EINVAL .
> +.IP
> +.B Warning:
> +Because the compiler or run-time environment
> +may be using some or all of the keys,
> +a successful
> +.IP
> +For more information, see the kernel source file
> +.I Documentation/arm64/pointer\-authentication.rst
> +.\"commit b693d0b372afb39432e1c49ad7b3454855bc6bed
> +(or
> +.I Documentation/arm64/pointer\-authentication.txt
> +before Linux 5.3).
> +.B PR_PAC_RESET_KEYS
> +may crash the calling process.

I might be misreading this, but this looks like the kernel reference appears
mid-sentence. Regardless, I think we should drop the kernel doc reference,
as I mentioned on the SVE patches.

With that:

Acked-by: Will Deacon <will@kernel.org>

Will

  parent reply	other threads:[~2020-06-09 10:02 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 21:17 [PATCH v2 0/6] prctl.2 man page updates for Linux 5.6 Dave Martin
2020-05-27 21:17 ` Dave Martin
2020-05-27 21:17 ` [PATCH v2 1/6] prctl.2: ffix use literal hyphens when referencing kernel docs Dave Martin
     [not found]   ` <1590614258-24728-2-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>
2020-05-28  6:05     ` Michael Kerrisk (man-pages)
2020-05-28  6:05       ` Michael Kerrisk (man-pages)
2020-05-27 21:17 ` [PATCH v2 2/6] prctl.2: Add PR_SPEC_INDIRECT_BRANCH for SPECULATION_CTRL prctls Dave Martin
     [not found]   ` <1590614258-24728-3-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>
2020-05-28  7:01     ` Michael Kerrisk (man-pages)
2020-05-28  7:01       ` Michael Kerrisk (man-pages)
2020-06-01 13:51       ` Dave Martin
     [not found]         ` <20200601135112.GB5031-5wv7dgnIgG8@public.gmane.org>
2020-06-09 11:00           ` Michael Kerrisk (man-pages)
2020-06-09 11:00             ` Michael Kerrisk (man-pages)
     [not found] ` <1590614258-24728-1-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>
2020-05-27 21:17   ` [PATCH v2 3/6] prctl.2: Add PR_SPEC_DISABLE_NOEXEC " Dave Martin
2020-05-27 21:17     ` Dave Martin
     [not found]     ` <1590614258-24728-4-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>
2020-05-28  6:57       ` Michael Kerrisk (man-pages)
2020-05-28  6:57         ` Michael Kerrisk (man-pages)
2020-05-28 13:45       ` Waiman Long
2020-05-28 13:45         ` Waiman Long
2020-05-27 21:17   ` [PATCH v2 4/6] prctl.2: Add SVE prctls (arm64) Dave Martin
2020-05-27 21:17     ` Dave Martin
     [not found]     ` <1590614258-24728-5-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>
2020-06-09  9:57       ` Will Deacon
2020-06-09  9:57         ` Will Deacon
2020-06-09 14:11         ` Dave Martin
2020-06-09 14:49           ` Will Deacon
2020-06-10  9:44             ` Dave Martin
2020-06-10  9:44               ` Dave Martin
2020-06-10 10:16               ` Will Deacon
2020-06-10 12:48                 ` Dave Martin
2020-06-09 11:39       ` Michael Kerrisk (man-pages)
2020-06-09 11:39         ` Michael Kerrisk (man-pages)
     [not found]         ` <77b02e4a-bfcf-90ef-90ca-73e878b7b649-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-10  9:45           ` Dave Martin
2020-06-10  9:45             ` Dave Martin
2020-05-27 21:17   ` [RFC PATCH v2 6/6] prctl.2: Add tagged address ABI control " Dave Martin
2020-05-27 21:17     ` Dave Martin
     [not found]     ` <1590614258-24728-7-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>
2020-06-09 11:04       ` Michael Kerrisk (man-pages)
2020-06-09 11:04         ` Michael Kerrisk (man-pages)
     [not found]         ` <88ac761e-64b3-e1e3-3cdc-1f413a6d69d6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-09 13:38           ` Will Deacon
2020-06-09 13:38             ` Will Deacon
2020-06-09 17:22     ` Catalin Marinas
     [not found]       ` <20200609172232.GA63286-ryiLQoaaaizILnBEAk/BfazUEOm+Xw19@public.gmane.org>
2020-06-10 10:06         ` Dave Martin
2020-06-10 10:06           ` Dave Martin
     [not found]           ` <20200610100641.GF25945-5wv7dgnIgG8@public.gmane.org>
2020-06-10 15:26             ` Catalin Marinas
2020-06-10 15:26               ` Catalin Marinas
2020-06-10 16:42               ` Dave Martin
     [not found]                 ` <20200610164209.GH25945-5wv7dgnIgG8@public.gmane.org>
2020-06-10 17:42                   ` Catalin Marinas
2020-06-10 17:42                     ` Catalin Marinas
2020-06-15 14:51                     ` Dave Martin
2020-06-15 14:51                       ` Dave Martin
     [not found]                       ` <20200615145115.GL25945-5wv7dgnIgG8@public.gmane.org>
2020-06-24  9:54                         ` Michael Kerrisk (man-pages)
2020-06-24  9:54                           ` Michael Kerrisk (man-pages)
     [not found]                           ` <CAKgNAkgnH7f4bNiF8q-GOY_xz1x9gYnDjMTw=vpR7ONxoL=cdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-06-24 10:29                             ` Dave Martin
2020-06-24 10:29                               ` Dave Martin
2020-05-27 21:17 ` [PATCH v2 5/6] prctl.2: Add PR_PAC_RESET_KEYS (arm64) Dave Martin
     [not found]   ` <1590614258-24728-6-git-send-email-Dave.Martin-5wv7dgnIgG8@public.gmane.org>
2020-06-09 10:02     ` Will Deacon [this message]
2020-06-09 10:02       ` Will Deacon
2020-06-09 11:03       ` Michael Kerrisk (man-pages)
2020-06-09 11:03         ` Michael Kerrisk (man-pages)
2020-06-09 11:36     ` Michael Kerrisk (man-pages)
2020-06-09 11:36       ` Michael Kerrisk (man-pages)
2020-06-09 14:16       ` Dave Martin
2020-06-09 18:11         ` Michael Kerrisk (man-pages)
2020-05-28  7:11 ` [PATCH v2 0/6] prctl.2 man page updates for Linux 5.6 Michael Kerrisk (man-pages)
2020-05-28  7:11   ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609100202.GB25362@willie-the-truck \
    --to=will-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=Dave.Martin-5wv7dgnIgG8@public.gmane.org \
    --cc=amit.kachhap-5wv7dgnIgG8@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox