From: Greg KH <gregkh@linuxfoundation.org>
To: guoren@kernel.org
Cc: palmer@rivosinc.com, paul.walmsley@sifive.com,
falcon@tinylab.org, bjorn@kernel.org, conor.dooley@microchip.com,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, stable@vger.kernel.org,
Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH 2/2] riscv: stack: Fixup independent softirq stack for CONFIG_FRAME_POINTER=n
Date: Sat, 15 Jul 2023 16:19:33 +0200 [thread overview]
Message-ID: <2023071528-traverse-parting-14b2@gregkh> (raw)
In-Reply-To: <20230715134552.3437933-3-guoren@kernel.org>
On Sat, Jul 15, 2023 at 09:45:52AM -0400, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> The independent softirq stack uses s0 to save & restore sp, but s0 would
> be corrupted when CONFIG_FRAME_POINTER=n. So add s0 in the clobber list
> to fix the problem.
>
> Fixes: dd69d07a5a6c ("riscv: stack: Support HAVE_SOFTIRQ_ON_OWN_STACK")
> Reported-by: Zhangjin Wu <falcon@tinylab.org>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> ---
> arch/riscv/kernel/irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c
> index d0577cc6a081..0b58720109db 100644
> --- a/arch/riscv/kernel/irq.c
> +++ b/arch/riscv/kernel/irq.c
> @@ -83,7 +83,7 @@ void do_softirq_own_stack(void)
> :
> : [sp] "r" (sp)
> : "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7",
> - "t0", "t1", "t2", "t3", "t4", "t5", "t6",
> + "t0", "t1", "t2", "t3", "t4", "t5", "t6", "s0",
> "memory");
> } else
> #endif
> --
> 2.36.1
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2023-07-15 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 13:45 [PATCH 0/2] riscv: stack: Fixup independent softirq/irq stack for CONFIG_FRAME_POINTER=n guoren
2023-07-15 13:45 ` [PATCH 1/2] riscv: stack: Fixup independent irq " guoren
2023-07-15 13:45 ` [PATCH 2/2] riscv: stack: Fixup independent softirq " guoren
2023-07-15 14:19 ` Greg KH [this message]
2023-07-16 0:18 ` [PATCH 0/2] riscv: stack: Fixup independent softirq/irq " Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071528-traverse-parting-14b2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bjorn@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=falcon@tinylab.org \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox