From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>
Cc: linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [RFC PATCH v2 4/8] ext4: Use dax_is_supported()
Date: Tue, 30 Jan 2024 11:52:51 -0500 [thread overview]
Message-ID: <20240130165255.212591-5-mathieu.desnoyers@efficios.com> (raw)
In-Reply-To: <20240130165255.212591-1-mathieu.desnoyers@efficios.com>
Use dax_is_supported() to validate whether the architecture has
virtually aliased data caches at mount time. Mount fails if dax=always
is requested as a mount option on an architecture which does not support
DAX.
This is relevant for architectures which require a dynamic check
to validate whether they have virtually aliased data caches.
Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches")
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-arch@vger.kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <linux@armlinux.org.uk>
Cc: nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
---
fs/ext4/super.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index c5fcf377ab1f..f2c11ae3ec29 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4743,7 +4743,10 @@ static int ext4_check_feature_compatibility(struct super_block *sb,
}
if (sbi->s_mount_opt & EXT4_MOUNT_DAX_ALWAYS) {
- if (ext4_has_feature_inline_data(sb)) {
+ if (!dax_is_supported()) {
+ ext4_msg(sb, KERN_ERR, "DAX unsupported by architecture.");
+ return -EINVAL;
+ } else if (ext4_has_feature_inline_data(sb)) {
ext4_msg(sb, KERN_ERR, "Cannot use DAX on a filesystem"
" that may contain inline data");
return -EINVAL;
--
2.39.2
next prev parent reply other threads:[~2024-01-30 16:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 16:52 [RFC PATCH v2 0/8] Introduce dcache_is_aliasing() to fix DAX regression Mathieu Desnoyers
2024-01-30 16:52 ` [RFC PATCH v2 1/8] dax: Introduce dax_is_supported() Mathieu Desnoyers
2024-01-31 2:38 ` Dave Chinner
2024-01-30 16:52 ` [RFC PATCH v2 2/8] erofs: Use dax_is_supported() Mathieu Desnoyers
2024-01-30 16:52 ` [RFC PATCH v2 3/8] ext2: " Mathieu Desnoyers
2024-01-30 21:40 ` Jan Kara
2024-01-30 16:52 ` Mathieu Desnoyers [this message]
2024-01-30 16:52 ` [RFC PATCH v2 5/8] fuse: " Mathieu Desnoyers
2024-01-30 16:52 ` [RFC PATCH v2 6/8] xfs: " Mathieu Desnoyers
2024-01-30 16:52 ` [RFC PATCH v2 7/8] Introduce dcache_is_aliasing() across all architectures Mathieu Desnoyers
2024-01-31 2:48 ` Dave Chinner
2024-01-31 14:58 ` Mathieu Desnoyers
2024-01-31 20:42 ` Dave Chinner
2024-01-30 16:52 ` [RFC PATCH v2 8/8] dax: Fix incorrect list of dcache aliasing architectures Mathieu Desnoyers
2024-01-31 2:54 ` Dave Chinner
2024-01-31 3:13 ` Dan Williams
2024-01-31 15:14 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130165255.212591-5-mathieu.desnoyers@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=nvdimm@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox