[PATCH] fix prototypes of reads[bwl]() on sparc64

[PATCH] fix prototypes of reads[bwl]() on sparc64

[Al Viro]

Conventions for readsl() are the same as for readl() - any __iomem
pointer is acceptable, both const and volatile ones being OK.  Same
for readsb() and readsw().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/arch/sparc/include/asm/io_64.h b/arch/sparc/include/asm/io_64.h
index c9528e4719cd..d8ed296624af 100644
--- a/arch/sparc/include/asm/io_64.h
+++ b/arch/sparc/include/asm/io_64.h
@@ -250,19 +250,19 @@ void insl(unsigned long, void *, unsigned long);
 #define insw insw
 #define insl insl
 
-static inline void readsb(void __iomem *port, void *buf, unsigned long count)
+static inline void readsb(const volatile void __iomem *port, void *buf, unsigned long count)
 {
 	insb((unsigned long __force)port, buf, count);
 }
 #define readsb readsb
 
-static inline void readsw(void __iomem *port, void *buf, unsigned long count)
+static inline void readsw(const volatile void __iomem *port, void *buf, unsigned long count)
 {
 	insw((unsigned long __force)port, buf, count);
 }
 #define readsw readsw
 
-static inline void readsl(void __iomem *port, void *buf, unsigned long count)
+static inline void readsl(const volatile void __iomem *port, void *buf, unsigned long count)
 {
 	insl((unsigned long __force)port, buf, count);
 }

Re: [PATCH] fix prototypes of reads[bwl]() on sparc64

[Andreas Larsson]

On 2025-08-10 05:42, Al Viro wrote:
> Conventions for readsl() are the same as for readl() - any __iomem
> pointer is acceptable, both const and volatile ones being OK.  Same
> for readsb() and readsw().
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/arch/sparc/include/asm/io_64.h b/arch/sparc/include/asm/io_64.h
> index c9528e4719cd..d8ed296624af 100644
> --- a/arch/sparc/include/asm/io_64.h
> +++ b/arch/sparc/include/asm/io_64.h
> @@ -250,19 +250,19 @@ void insl(unsigned long, void *, unsigned long);
>  #define insw insw
>  #define insl insl
>  
> -static inline void readsb(void __iomem *port, void *buf, unsigned long count)
> +static inline void readsb(const volatile void __iomem *port, void *buf, unsigned long count)
>  {
>  	insb((unsigned long __force)port, buf, count);
>  }
>  #define readsb readsb
>  
> -static inline void readsw(void __iomem *port, void *buf, unsigned long count)
> +static inline void readsw(const volatile void __iomem *port, void *buf, unsigned long count)
>  {
>  	insw((unsigned long __force)port, buf, count);
>  }
>  #define readsw readsw
>  
> -static inline void readsl(void __iomem *port, void *buf, unsigned long count)
> +static inline void readsl(const volatile void __iomem *port, void *buf, unsigned long count)
>  {
>  	insl((unsigned long __force)port, buf, count);
>  }

Reviewed-by: Andreas Larsson <andreas@gaisler.com>

Picking this up to my for-next.

Thanks,
Andreas

Re: [PATCH] fix prototypes of reads[bwl]() on sparc64

[Andreas Larsson]

On 2025-09-19 20:02, Andreas Larsson wrote:
> Picking this up to my for-next.

...and swapping sparc64 to subject be prefix:

sparc64: fix prototypes of reads[bwl]()

Cheers,
Andreas