From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
sched-ext@lists.linux.dev, netdev@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Andrea Righi <arighi@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Ben Segall <bsegall@google.com>,
Breno Leitao <leitao@debian.org>,
Changwoo Min <changwoo@igalia.com>,
David Vernet <void@manifault.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Eric Dumazet <edumazet@google.com>,
Ingo Molnar <mingo@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
John Ogness <john.ogness@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Simon Horman <horms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Vlad Poenaru <vlad.wing@gmail.com>
Subject: Re: [PATCH 1/2] bug: Provide WARN_ON.*DEFERRED() macros for console deferred output
Date: Wed, 24 Jun 2026 08:26:42 +0200 [thread overview]
Message-ID: <20260624062642.5DER6vrP@linutronix.de> (raw)
In-Reply-To: <038a11a7-4ced-49ae-b605-2058733e841a@amd.com>
On 2026-06-23 20:24:02 [+0530], K Prateek Nayak wrote:
> Hello Sebastian,
Hi Prateek,
> nit.
>
> Instead of replicating these bits, can we replace that return with a
> "goto out" ...
sure
…
> ... and replace this return with a:
>
> return (warning) ? BUG_TRAP_TYPE_WARN : BUG_TRAP_TYPE_BUG;
>
> Looks a tab bit cleaner to my eyes. Thoughts?
It sure does.
I wait for PeterZ' executive order to either do this and sprinkle sched/
_or_ make legacy consoles deferred as it is done on RT.
Petr, was there a big push back doing it unconditionally?
> > }
> >
Sebastian
next prev parent reply other threads:[~2026-06-24 6:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 14:26 [PATCH 0/2] sched: Introduce and use deferred WARNs in sched Sebastian Andrzej Siewior
2026-06-23 14:26 ` [PATCH 1/2] bug: Provide WARN_ON.*DEFERRED() macros for console deferred output Sebastian Andrzej Siewior
2026-06-23 14:54 ` K Prateek Nayak
2026-06-24 6:26 ` Sebastian Andrzej Siewior [this message]
2026-06-24 9:17 ` Petr Mladek
2026-06-23 15:12 ` Andrew Morton
2026-06-23 15:49 ` Petr Mladek
2026-06-24 8:37 ` Breno Leitao
2026-06-24 11:03 ` Sebastian Andrzej Siewior
2026-06-24 9:31 ` Peter Zijlstra
2026-06-24 10:08 ` Sebastian Andrzej Siewior
2026-06-23 14:26 ` [PATCH 2/2] sched: Use WARN_ON.*_DEFERRED() Sebastian Andrzej Siewior
2026-06-24 9:33 ` [PATCH 0/2] sched: Introduce and use deferred WARNs in sched Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624062642.5DER6vrP@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=arighi@nvidia.com \
--cc=arnd@arndb.de \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=davem@davemloft.net \
--cc=dietmar.eggemann@arm.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=senozhatsky@chromium.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vlad.wing@gmail.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox