* Re: [PATCH 09/10] sched/preempt: fix duplicate extern declarations
@ 2026-11-13 12:02 Safocl
2026-11-13 12:36 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Safocl @ 2026-11-13 12:02 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-arch, linux-kernel, Safocl
but it contains `asmlinkage`, which includes `extern "C"` when
`__cplusplus` is defined...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 09/10] sched/preempt: fix duplicate extern declarations
@ 2026-11-13 12:48 Safocl
0 siblings, 0 replies; 5+ messages in thread
From: Safocl @ 2026-11-13 12:48 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-arch, linux-kernel, Safocl
Perhaps it’s worth making a change now to ensure some consistency? At
your discretion, you could remove such `extern` specifiers for
functions entirely (along with `asmlinkage`), as they are redundant —
or, alternatively, remove just one of them.
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20261113001432.128201-1-safocl88@gmail.com>]
* [PATCH 09/10] sched/preempt: fix duplicate extern declarations
[not found] <20261113001432.128201-1-safocl88@gmail.com>
@ 2026-11-13 0:14 ` Safocl Stollmannovic
2026-11-13 8:37 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Safocl Stollmannovic @ 2026-11-13 0:14 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-kernel, linux-arch
Compiling a kernel module with a C++ compiler results in a duplicate
echo ‘extern’ specifier error.
This occurs because the code contains , and
expands to when processed by a C++ compiler.
The specifier must be removed.
https://bugzilla.kernel.org/show_bug.cgi?id=222257
Signed-off-by: Safocl Stollmannovic <safocl88@gmail.com>
---
include/asm-generic/preempt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/asm-generic/preempt.h b/include/asm-generic/preempt.h
index 1adddeab8..fc0da591d 100644
--- a/include/asm-generic/preempt.h
+++ b/include/asm-generic/preempt.h
@@ -93,8 +93,8 @@ static __always_inline bool should_resched(int preempt_offset)
}
#ifdef CONFIG_PREEMPTION
-extern asmlinkage void preempt_schedule(void);
-extern asmlinkage void preempt_schedule_notrace(void);
+asmlinkage void preempt_schedule(void);
+asmlinkage void preempt_schedule_notrace(void);
#define __preempt_schedule() preempt_schedule()
#define __preempt_schedule_notrace() preempt_schedule_notrace()
--
2.56.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-13 12:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13 12:02 [PATCH 09/10] sched/preempt: fix duplicate extern declarations Safocl
2026-11-13 12:36 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2026-11-13 12:48 Safocl
[not found] <20261113001432.128201-1-safocl88@gmail.com>
2026-11-13 0:14 ` Safocl Stollmannovic
2026-11-13 8:37 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox