From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-kernel@vger.kernel.org, "Baoquan He" <bhe@redhat.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
regressions@lists.linux.dev
Subject: Re: [REGRESSION] mipsel: no RTC CMOS on the Malta platform in QEMU
Date: Tue, 14 Jan 2025 11:30:12 +0100 [thread overview]
Message-ID: <599d4ef2-38dc-431f-a65d-c76fc81f02b3@app.fastmail.com> (raw)
In-Reply-To: <12aa35c3-3f74-40bf-9fa1-7540aa4292c3@app.fastmail.com>
On Tue, Jan 14, 2025, at 11:09, Jiaxun Yang wrote:
> 在2025年1月14日一月 上午8:02，Geert Uytterhoeven写道：
>>
>> Shouldn't arch/mips/include/asm/io.h do
>>
>> #define PCI_IOBASE mips_io_port_base
>>
>> unconditionally, _before_ including <asm-generic/io.h>?
>
> The problem here is defining PCI_IOBASE implied use of logic_pio and VM mapped
> io access, which is not true for many MIPS systems...
>
I don't think that was ever meant to be the intention of the
#ifdef in drivers/pci/pci.c. Checking for PCI_IOBASE there
should mainly ensure the default
pci_pio_to_address/pci_address_to_pio don't cause a link
failure on architectures that don't have any memory mapped
PIO at all.
For MIPS platforms that don't need logic_pio because all of
the PIO space is mapped to a fixed physical address, the
default pci_remap_iospace/pci_pio_to_address/pci_address_to_pio/
pci_register_io_range could just be replaced with a trivial
architecture/platform specific version.
Arnd
prev parent reply other threads:[~2025-01-14 10:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 22:16 [REGRESSION] mipsel: no RTC CMOS on the Malta platform in QEMU Mateusz Jończyk
2025-01-13 23:29 ` Jiaxun Yang
2025-01-14 7:01 ` Arnd Bergmann
2025-01-14 8:02 ` Geert Uytterhoeven
2025-01-14 9:59 ` Arnd Bergmann
2025-01-14 10:22 ` Jiaxun Yang
2025-01-14 16:11 ` Maciej W. Rozycki
2025-01-14 17:04 ` Arnd Bergmann
2025-01-14 19:10 ` Maciej W. Rozycki
2025-01-15 8:15 ` Arnd Bergmann
2025-01-14 17:56 ` Jiaxun Yang
2025-01-14 10:09 ` Jiaxun Yang
2025-01-14 10:30 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599d4ef2-38dc-431f-a65d-c76fc81f02b3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexandre.belloni@bootlin.com \
--cc=bhe@redhat.com \
--cc=geert@linux-m68k.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=regressions@lists.linux.dev \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox