From: "Arnd Bergmann" <arnd@arndb.de>
To: "Anshuman Khandual" <anshuman.khandual@arm.com>,
linux-kernel@vger.kernel.org
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Yury Norov" <yury.norov@gmail.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
Linux-Arch <linux-arch@vger.kernel.org>,
"Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH V2 0/2] uapi: Add support for GENMASK_U128()
Date: Tue, 30 Jul 2024 14:29:44 +0200 [thread overview]
Message-ID: <79960e1a-6fa1-4d15-b842-0dc4d6a2bc1b@app.fastmail.com> (raw)
In-Reply-To: <08e6c85e-2c82-4c15-bfe7-d42900d1c68f@arm.com>
On Tue, Jul 30, 2024, at 06:29, Anshuman Khandual wrote:
> On 7/25/24 11:18, Anshuman Khandual wrote:
>>
>> - Wrapped genmask_u128_test() with CONFIG_ARCH_SUPPORTS_INT128
>> - Defined __BITS_PER_U128 unconditionally as 128
>> - Defined __GENMASK_U128() via new _BIT128()
>> - Dropped _U128() and _AC128()
>
> Does the changed series look good ? Please do let me know if something
> further needs to be changed. Thank you.
Yes, these look fine to me, please add
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
One detail: You are not actually using __BITS_PER_U128 at
all now, so I think it would be better to not add it at all.
next prev parent reply other threads:[~2024-07-30 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 5:48 [PATCH V2 0/2] uapi: Add support for GENMASK_U128() Anshuman Khandual
2024-07-25 5:48 ` [PATCH V2 1/2] uapi: Define GENMASK_U128 Anshuman Khandual
2024-07-30 18:15 ` Yury Norov
2024-07-31 3:44 ` Anshuman Khandual
2024-07-31 16:38 ` Yury Norov
2024-07-31 17:16 ` Arnd Bergmann
2024-07-25 5:48 ` [PATCH V2 2/2] lib/test_bits.c: Add tests for GENMASK_U128() Anshuman Khandual
2024-07-30 18:20 ` Yury Norov
2024-07-31 4:11 ` Anshuman Khandual
2024-07-25 21:05 ` [PATCH V2 0/2] uapi: Add support " Andrew Morton
2024-07-26 3:34 ` Anshuman Khandual
2024-07-30 4:29 ` Anshuman Khandual
2024-07-30 12:29 ` Arnd Bergmann [this message]
2024-07-31 2:39 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79960e1a-6fa1-4d15-b842-0dc4d6a2bc1b@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox