From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Yuxuan Shui <yshuiv7@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH] ptrace: restore the previous single step reporting behavior
Date: Wed, 27 Jan 2021 20:55:20 -0300 [thread overview]
Message-ID: <87zh0u540n.fsf@collabora.com> (raw)
In-Reply-To: <877do3gaq9.fsf@m5Zedd9JOGzJrf0> (Yuxuan Shui's message of "Sat, 23 Jan 2021 03:21:32 -0800 (PST)")
Yuxuan Shui <yshuiv7@gmail.com> writes:
> Commit 64eb35f701f04b30706e21d1b02636b5d31a37d2 changed when single step
> is reported.
>
> Specifically, the report_single_step is changed so that single steps are
> only reported when both SYSCALL_EMU and _TIF_SINGLESTEP are set, while
> previously they are reported when _TIF_SINGLESTEP is set without
> _TIF_SYSCALL_EMU being set.
>
> This behavior change breaks rr [1]
>
> This commit restores the old behavior.
>
> [1]: https://github.com/rr-debugger/rr/issues/2793
>
> Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Looks correct to me.
To gather the right attention, you should directly CC the correct maintainers.
Fixes: 64eb35f701f0 ("ptrace: Migrate TIF_SYSCALL_EMU to use SYSCALL_WORK flag")
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2021-01-27 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 11:21 [PATCH] ptrace: restore the previous single step reporting behavior Yuxuan Shui
2021-01-27 23:55 ` Gabriel Krisman Bertazi [this message]
2021-01-28 0:16 ` Yuxuan Shui
2021-01-28 12:40 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2021-01-27 23:10 Kyle Huey
[not found] ` <CAHk-=wiVj-0zV8ePHZ2rGFErJAYkRb3FZ8K9aYus6is0bALL5A@mail.gmail.com>
2021-01-28 20:15 ` Kyle Huey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh0u540n.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox