* Re: linux-next: build failure after merge of the final tree (staging related)
[not found] ` <20110610160548.529797c7.sfr@canb.auug.org.au>
@ 2011-06-15 12:05 ` Geert Uytterhoeven
2011-06-15 12:05 ` Geert Uytterhoeven
2011-06-15 15:47 ` Greg KH
2011-06-15 14:35 ` [PATCH] arch/tile: remove useless set_fixmap_nocache() macro Chris Metcalf
1 sibling, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2011-06-15 12:05 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, brudley, henryp, rvossen, linux-next, linux-kernel,
Linus, sparclinux, Linux-Arch
On Fri, Jun 10, 2011 at 08:05, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Thu, 9 Jun 2011 12:22:43 -0700 Greg KH <greg@kroah.com> wrote:
>> On Thu, Jun 09, 2011 at 11:41:27AM -0700, Greg KH wrote:
>> > > Also in several other files in drivers/staging/brcm80211/
>> > >
>> > > Also:
>> > >
>> > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
>> > > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
I have my doubts
#ifdef PAGE_KERNEL_NOCACHE
vmap(pages, n_pages, VM_MAP, PAGE_KERNEL_NOCACHE);
#else
vmap(pages, n_pages, VM_MAP, PAGE_KERNEL);
#endif
is the right "fix" for this...
BTW, PAGE_KERNEL_NOCACHE is defined on frv, m32r, mn10300, sh, and x86 only.
Strangely, both sparc and tile have
/*
* Some hardware wants to get fixmapped without caching.
*/
#define set_fixmap_nocache(idx, phys) \
__set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE)
in their <asm/fixmap.h>, without having PAGE_KERNEL_NOCACHE...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the final tree (staging related)
2011-06-15 12:05 ` linux-next: build failure after merge of the final tree (staging related) Geert Uytterhoeven
@ 2011-06-15 12:05 ` Geert Uytterhoeven
2011-06-15 15:47 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2011-06-15 12:05 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, brudley, henryp, rvossen, linux-next, linux-kernel,
Linus, sparclinux, Linux-Arch
On Fri, Jun 10, 2011 at 08:05, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Thu, 9 Jun 2011 12:22:43 -0700 Greg KH <greg@kroah.com> wrote:
>> On Thu, Jun 09, 2011 at 11:41:27AM -0700, Greg KH wrote:
>> > > Also in several other files in drivers/staging/brcm80211/
>> > >
>> > > Also:
>> > >
>> > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
>> > > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
I have my doubts
#ifdef PAGE_KERNEL_NOCACHE
vmap(pages, n_pages, VM_MAP, PAGE_KERNEL_NOCACHE);
#else
vmap(pages, n_pages, VM_MAP, PAGE_KERNEL);
#endif
is the right "fix" for this...
BTW, PAGE_KERNEL_NOCACHE is defined on frv, m32r, mn10300, sh, and x86 only.
Strangely, both sparc and tile have
/*
* Some hardware wants to get fixmapped without caching.
*/
#define set_fixmap_nocache(idx, phys) \
__set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE)
in their <asm/fixmap.h>, without having PAGE_KERNEL_NOCACHE...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arch/tile: remove useless set_fixmap_nocache() macro
[not found] ` <20110610160548.529797c7.sfr@canb.auug.org.au>
2011-06-15 12:05 ` linux-next: build failure after merge of the final tree (staging related) Geert Uytterhoeven
@ 2011-06-15 14:35 ` Chris Metcalf
2011-06-15 14:35 ` Chris Metcalf
1 sibling, 1 reply; 6+ messages in thread
From: Chris Metcalf @ 2011-06-15 14:35 UTC (permalink / raw)
To: Geert Uytterhoeven, Stephen Rothwell, Greg KH, brudley, henryp,
rvossen
TILE doesn't support PAGE_KERNEL_NOCACHE so the macro isn't useful;
it's a copy-and-paste from the first version of this header in 2007.
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
arch/tile/include/asm/fixmap.h | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/arch/tile/include/asm/fixmap.h b/arch/tile/include/asm/fixmap.h
index 51537ff..c66f793 100644
--- a/arch/tile/include/asm/fixmap.h
+++ b/arch/tile/include/asm/fixmap.h
@@ -75,12 +75,6 @@ extern void __set_fixmap(enum fixed_addresses idx,
#define set_fixmap(idx, phys) \
__set_fixmap(idx, phys, PAGE_KERNEL)
-/*
- * Some hardware wants to get fixmapped without caching.
- */
-#define set_fixmap_nocache(idx, phys) \
- __set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE)
-
#define clear_fixmap(idx) \
__set_fixmap(idx, 0, __pgprot(0))
--
1.6.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arch/tile: remove useless set_fixmap_nocache() macro
2011-06-15 14:35 ` [PATCH] arch/tile: remove useless set_fixmap_nocache() macro Chris Metcalf
@ 2011-06-15 14:35 ` Chris Metcalf
0 siblings, 0 replies; 6+ messages in thread
From: Chris Metcalf @ 2011-06-15 14:35 UTC (permalink / raw)
To: Geert Uytterhoeven, Stephen Rothwell, Greg KH, brudley, henryp,
rvossen, linux-next, linux-kernel, Linus, sparclinux, Linux-Arch
TILE doesn't support PAGE_KERNEL_NOCACHE so the macro isn't useful;
it's a copy-and-paste from the first version of this header in 2007.
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
arch/tile/include/asm/fixmap.h | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/arch/tile/include/asm/fixmap.h b/arch/tile/include/asm/fixmap.h
index 51537ff..c66f793 100644
--- a/arch/tile/include/asm/fixmap.h
+++ b/arch/tile/include/asm/fixmap.h
@@ -75,12 +75,6 @@ extern void __set_fixmap(enum fixed_addresses idx,
#define set_fixmap(idx, phys) \
__set_fixmap(idx, phys, PAGE_KERNEL)
-/*
- * Some hardware wants to get fixmapped without caching.
- */
-#define set_fixmap_nocache(idx, phys) \
- __set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE)
-
#define clear_fixmap(idx) \
__set_fixmap(idx, 0, __pgprot(0))
--
1.6.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the final tree (staging related)
2011-06-15 12:05 ` linux-next: build failure after merge of the final tree (staging related) Geert Uytterhoeven
2011-06-15 12:05 ` Geert Uytterhoeven
@ 2011-06-15 15:47 ` Greg KH
2011-06-15 15:47 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-06-15 15:47 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Stephen Rothwell, brudley, henryp, rvossen, linux-next,
linux-kernel, Linus, sparclinux, Linux-Arch
On Wed, Jun 15, 2011 at 02:05:29PM +0200, Geert Uytterhoeven wrote:
> On Fri, Jun 10, 2011 at 08:05, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Thu, 9 Jun 2011 12:22:43 -0700 Greg KH <greg@kroah.com> wrote:
> >> On Thu, Jun 09, 2011 at 11:41:27AM -0700, Greg KH wrote:
> >> > > Also in several other files in drivers/staging/brcm80211/
> >> > >
> >> > > Also:
> >> > >
> >> > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> >> > > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
>
> I have my doubts
>
> #ifdef PAGE_KERNEL_NOCACHE
> vmap(pages, n_pages, VM_MAP, PAGE_KERNEL_NOCACHE);
> #else
> vmap(pages, n_pages, VM_MAP, PAGE_KERNEL);
> #endif
>
> is the right "fix" for this...
>
> BTW, PAGE_KERNEL_NOCACHE is defined on frv, m32r, mn10300, sh, and x86 only.
>
> Strangely, both sparc and tile have
>
> /*
> * Some hardware wants to get fixmapped without caching.
> */
> #define set_fixmap_nocache(idx, phys) \
> __set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE)
>
> in their <asm/fixmap.h>, without having PAGE_KERNEL_NOCACHE...
So, what should the correct fix here be?
confused,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the final tree (staging related)
2011-06-15 15:47 ` Greg KH
@ 2011-06-15 15:47 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2011-06-15 15:47 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Stephen Rothwell, brudley, henryp, rvossen, linux-next,
linux-kernel, Linus, sparclinux, Linux-Arch
On Wed, Jun 15, 2011 at 02:05:29PM +0200, Geert Uytterhoeven wrote:
> On Fri, Jun 10, 2011 at 08:05, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Thu, 9 Jun 2011 12:22:43 -0700 Greg KH <greg@kroah.com> wrote:
> >> On Thu, Jun 09, 2011 at 11:41:27AM -0700, Greg KH wrote:
> >> > > Also in several other files in drivers/staging/brcm80211/
> >> > >
> >> > > Also:
> >> > >
> >> > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> >> > > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
>
> I have my doubts
>
> #ifdef PAGE_KERNEL_NOCACHE
> vmap(pages, n_pages, VM_MAP, PAGE_KERNEL_NOCACHE);
> #else
> vmap(pages, n_pages, VM_MAP, PAGE_KERNEL);
> #endif
>
> is the right "fix" for this...
>
> BTW, PAGE_KERNEL_NOCACHE is defined on frv, m32r, mn10300, sh, and x86 only.
>
> Strangely, both sparc and tile have
>
> /*
> * Some hardware wants to get fixmapped without caching.
> */
> #define set_fixmap_nocache(idx, phys) \
> __set_fixmap(idx, phys, PAGE_KERNEL_NOCACHE)
>
> in their <asm/fixmap.h>, without having PAGE_KERNEL_NOCACHE...
So, what should the correct fix here be?
confused,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-15 15:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110609172745.dfd3a298.sfr@canb.auug.org.au>
[not found] ` <20110609184127.GA2760@kroah.com>
[not found] ` <20110609192243.GA3980@kroah.com>
[not found] ` <20110610160548.529797c7.sfr@canb.auug.org.au>
2011-06-15 12:05 ` linux-next: build failure after merge of the final tree (staging related) Geert Uytterhoeven
2011-06-15 12:05 ` Geert Uytterhoeven
2011-06-15 15:47 ` Greg KH
2011-06-15 15:47 ` Greg KH
2011-06-15 14:35 ` [PATCH] arch/tile: remove useless set_fixmap_nocache() macro Chris Metcalf
2011-06-15 14:35 ` Chris Metcalf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox