From: Nadav Amit <namit@vmware.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: X86 ML <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Richard Biener <rguenther@suse.de>,
Segher Boessenkool <segher@kernel.crashing.org>,
Peter Zijlstra <peterz@infradead.org>,
Juergen Gross <jgross@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Alok Kataria <akataria@vmware.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jann Horn <jannh@google.co>
Subject: Re: [PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code
Date: Tue, 18 Dec 2018 19:43:29 +0000 [thread overview]
Message-ID: <C6D4A9B6-EED6-4DF7-8085-B1D3D221D25A@vmware.com> (raw)
In-Reply-To: <1545062607-8599-1-git-send-email-yamada.masahiro@socionext.com>
> On Dec 17, 2018, at 8:03 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> This series reverts the in-kernel workarounds for inlining issues.
>
> The commit description of 77b0bf55bc67 mentioned
> "We also hope that GCC will eventually get fixed,..."
>
> Now, GCC provides a solution.
>
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.org%2Fonlinedocs%2Fgcc%2FExtended-Asm.html&data=02%7C01%7Cnamit%40vmware.com%7Cc43f433d8c6244de15f108d6643a49e4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636806598899962669&sdata=88UJ25RoiHik9vTCJKZV6%2F7xpzCGsvKb9LFg1kfEYL0%3D&reserved=0
> explains the new "asm inline" syntax.
>
> The performance issue will be eventually solved.
>
> [About Code cleanups]
>
> I know Nadam Amit is opposed to the full revert.
My name is Nadav.
> He also claims his motivation for macrofying was not only
> performance, but also cleanups.
Masahiro, I understand your concerns and criticism, and indeed various
alternative solutions exist. I do have my reservations about the one you
propose, since it makes coding more complicated to simplify the Make system.
Yet, more important, starting this discussion suddenly now after RC7 is
strange. Anyhow, since it’s obviously not my call, please don’t make it
sound as if I am a side in the decision.
WARNING: multiple messages have this Message-ID (diff)
From: Nadav Amit <namit@vmware.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: X86 ML <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Richard Biener <rguenther@suse.de>,
Segher Boessenkool <segher@kernel.crashing.org>,
Peter Zijlstra <peterz@infradead.org>,
Juergen Gross <jgross@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Alok Kataria <akataria@vmware.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jann Horn <jannh@google.com>,
linux-arch <linux-arch@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
"linux-sparse@vger.kernel.org" <linux-sparse@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Yonghong Song <yhs@fb.com>,
Michal Marek <michal.lkml@markovi.net>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jan Beulich <JBeulich@suse.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Alexei Starovoitov <ast@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code
Date: Tue, 18 Dec 2018 19:43:29 +0000 [thread overview]
Message-ID: <C6D4A9B6-EED6-4DF7-8085-B1D3D221D25A@vmware.com> (raw)
Message-ID: <20181218194329.0J104_rPsPZmdFapnAdcr4rmxKnpeiNOy9cmHM2jjBI@z> (raw)
In-Reply-To: <1545062607-8599-1-git-send-email-yamada.masahiro@socionext.com>
> On Dec 17, 2018, at 8:03 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> This series reverts the in-kernel workarounds for inlining issues.
>
> The commit description of 77b0bf55bc67 mentioned
> "We also hope that GCC will eventually get fixed,..."
>
> Now, GCC provides a solution.
>
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.org%2Fonlinedocs%2Fgcc%2FExtended-Asm.html&data=02%7C01%7Cnamit%40vmware.com%7Cc43f433d8c6244de15f108d6643a49e4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636806598899962669&sdata=88UJ25RoiHik9vTCJKZV6%2F7xpzCGsvKb9LFg1kfEYL0%3D&reserved=0
> explains the new "asm inline" syntax.
>
> The performance issue will be eventually solved.
>
> [About Code cleanups]
>
> I know Nadam Amit is opposed to the full revert.
My name is Nadav.
> He also claims his motivation for macrofying was not only
> performance, but also cleanups.
Masahiro, I understand your concerns and criticism, and indeed various
alternative solutions exist. I do have my reservations about the one you
propose, since it makes coding more complicated to simplify the Make system.
Yet, more important, starting this discussion suddenly now after RC7 is
strange. Anyhow, since it’s obviously not my call, please don’t make it
sound as if I am a side in the decision.
next prev parent reply other threads:[~2018-12-18 19:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 16:03 [PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code Masahiro Yamada
2018-12-17 16:03 ` Masahiro Yamada
2018-12-17 16:03 ` [PATCH v3 05/12] Revert "x86/bug: Macrofy the BUG table section handling, to work around GCC inlining bugs" Masahiro Yamada
2018-12-17 16:03 ` Masahiro Yamada
2018-12-18 19:43 ` Nadav Amit [this message]
2018-12-18 19:43 ` [PATCH v3 00/12] x86, kbuild: revert macrofying inline assembly code Nadav Amit
2018-12-19 3:19 ` Masahiro Yamada
2018-12-19 3:19 ` Masahiro Yamada
2018-12-19 11:20 ` Ingo Molnar
2018-12-19 11:20 ` Ingo Molnar
2018-12-19 14:33 ` Masahiro Yamada
2018-12-19 14:33 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6D4A9B6-EED6-4DF7-8085-B1D3D221D25A@vmware.com \
--to=namit@vmware.com \
--cc=akataria@vmware.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jannh@google.co \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rguenther@suse.de \
--cc=segher@kernel.crashing.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox