* Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull
[not found] <73ec95f40cafbbb69bdfb43a7f53876fd845b0ce.1620990479.git.christophe.leroy@csgroup.eu>
@ 2021-05-14 21:42 ` Andrew Morton
2021-05-15 3:58 ` Nathan Chancellor
2021-05-15 6:28 ` Christophe Leroy
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Morton @ 2021-05-14 21:42 UTC (permalink / raw)
To: Christophe Leroy
Cc: Nicholas Piggin, Mike Kravetz, Mike Rapoport, naresh.kamboju,
linux-arch, linuxppc-dev, linux-kernel, linux-arm-kernel,
sparclinux, linux-mm
On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> When PUD and/or PMD are folded, those functions are useless
> and we now have a stub in linux/pgtable.h
OK, help me out here please. What patch does this fix?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull
2021-05-14 21:42 ` [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull Andrew Morton
@ 2021-05-15 3:58 ` Nathan Chancellor
2021-05-15 6:28 ` Christophe Leroy
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-05-15 3:58 UTC (permalink / raw)
To: Andrew Morton
Cc: Christophe Leroy, Nicholas Piggin, Mike Kravetz, Mike Rapoport,
naresh.kamboju, linux-arch, linuxppc-dev, linux-kernel,
linux-arm-kernel, sparclinux, linux-mm
On Fri, May 14, 2021 at 02:42:00PM -0700, Andrew Morton wrote:
> On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
>
> > When PUD and/or PMD are folded, those functions are useless
> > and we now have a stub in linux/pgtable.h
>
> OK, help me out here please. What patch does this fix?
>
Naresh's original report is here it seems:
https://lore.kernel.org/r/CA+G9fYv79t0+2W4Rt3wDkBShc4eY3M3utC5BHqUgGDwMYExYMw@mail.gmail.com/
I can reproduce the failure that he reported with
ARCH=arm64 allmodconfig and this patch resolves it for me.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull
2021-05-14 21:42 ` [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull Andrew Morton
2021-05-15 3:58 ` Nathan Chancellor
@ 2021-05-15 6:28 ` Christophe Leroy
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy @ 2021-05-15 6:28 UTC (permalink / raw)
To: Andrew Morton
Cc: Nicholas Piggin, Mike Kravetz, Mike Rapoport, naresh.kamboju,
linux-arch, linuxppc-dev, linux-kernel, linux-arm-kernel,
sparclinux, linux-mm
Le 14/05/2021 à 23:42, Andrew Morton a écrit :
> On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
>
>> When PUD and/or PMD are folded, those functions are useless
>> and we now have a stub in linux/pgtable.h
>
> OK, help me out here please. What patch does this fix?
>
Both this one and the x86 one from the day before fix 1cff41494b15cd82c1ec418bb5c ("mm/pgtable: add
stubs for {pmd/pub}_{set/clear}_huge")
I think both the x86 fix and the arm64 fix should be squashed into that patch at the end.
I checked, the only other architecture involving pud_set_huge() and friends is powerpc, and powerpc
doesn't have this problem as it only defined those for book3s/64 platforms which have 4 level page
tables by definition.
Thanks
Christophe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-15 6:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <73ec95f40cafbbb69bdfb43a7f53876fd845b0ce.1620990479.git.christophe.leroy@csgroup.eu>
2021-05-14 21:42 ` [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull Andrew Morton
2021-05-15 3:58 ` Nathan Chancellor
2021-05-15 6:28 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox